CT code now calls X509_free() after calling SSL_get_peer_certificate()
authorRob Percival <robpercival@google.com>
Mon, 7 Mar 2016 17:23:39 +0000 (17:23 +0000)
committerRich Salz <rsalz@openssl.org>
Mon, 7 Mar 2016 19:44:04 +0000 (14:44 -0500)
Without this, the peer certificate would never be deleted, resulting in
a memory leak.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
ssl/ssl_lib.c

index 40c4171..65558e0 100644 (file)
@@ -3941,6 +3941,7 @@ static int ct_extract_x509v3_extension_scts(SSL *s)
             ct_move_scts(&s->scts, scts, SCT_SOURCE_X509V3_EXTENSION);
 
         SCT_LIST_free(scts);
+        X509_free(cert);
     }
 
     return scts_extracted;
@@ -4071,6 +4072,7 @@ int SSL_validate_ct(SSL *s)
 
 end:
     CT_POLICY_EVAL_CTX_free(ctx);
+    X509_free(cert);
     return ret;
 }