CT code now calls X509_free() after calling SSL_get_peer_certificate()

Without this, the peer certificate would never be deleted, resulting in
a memory leak.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>

diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c
index 40c4171dec95fcb5317aa4371af069d4acdb0492..65558e01743e550c0864712f9f29cf6ec5d4abe5 100644 (file)
--- a/ssl/ssl_lib.c
+++ b/ssl/ssl_lib.c
@@ -3941,6 +3941,7 @@ static int ct_extract_x509v3_extension_scts(SSL *s)
             ct_move_scts(&s->scts, scts, SCT_SOURCE_X509V3_EXTENSION);
 
         SCT_LIST_free(scts);
             ct_move_scts(&s->scts, scts, SCT_SOURCE_X509V3_EXTENSION);
 
         SCT_LIST_free(scts);

+        X509_free(cert);

     }
 
     return scts_extracted;
     }
 
     return scts_extracted;


@@ -4071,6 +4072,7 @@ int SSL_validate_ct(SSL *s)
 
 end:
     CT_POLICY_EVAL_CTX_free(ctx);
 
 end:
     CT_POLICY_EVAL_CTX_free(ctx);

+    X509_free(cert);

     return ret;
 }
 
     return ret;
 }