Ensure we build ub sanitizer builds with -DPEDANTIC
authorMatt Caswell <matt@openssl.org>
Mon, 15 Aug 2022 11:07:37 +0000 (12:07 +0100)
committerHugo Landau <hlandau@openssl.org>
Wed, 17 Aug 2022 15:48:55 +0000 (16:48 +0100)
Otherwise we may get spurious results from ub sanitizer. For example we
assume we can tolerate some unaligned write without this define that ub
sanitizer will complain about.

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18983)

(cherry picked from commit 17b94de3df327e6619e52529e345a340d4a0a100)

.github/workflows/ci.yml

index 29a502a8d7d5b38f42c8bf65520fb174ce297cf6..533f3bbec6adeb1841ee7998a15618b5d374540a 100644 (file)
@@ -144,7 +144,7 @@ jobs:
     steps:
     - uses: actions/checkout@v2
     - name: config
-      run: ./config --banner=Configured --debug enable-asan enable-ubsan enable-rc5 enable-md2 enable-ec_nistp_64_gcc_128 enable-fips -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION && perl configdata.pm --dump
+      run: ./config --banner=Configured --debug enable-asan enable-ubsan enable-rc5 enable-md2 enable-ec_nistp_64_gcc_128 enable-fips -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -DPEDANTIC && perl configdata.pm --dump
     - name: make
       run: make -s -j4
     - name: make test