Don't incorrectly skip the multiblock test
authorMatt Caswell <matt@openssl.org>
Thu, 11 Aug 2022 11:02:44 +0000 (12:02 +0100)
committerHugo Landau <hlandau@openssl.org>
Wed, 17 Aug 2022 15:47:37 +0000 (16:47 +0100)
sslapitest has a test for multiblock writes. Since multiblock writing is
only available on some platforms the multiblock test checks whether we are
on such a platform first, and skips the test if we are not. Unfortunately
a bug in the check meant that we always skipped the test regardless of the
platform.

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18983)

(cherry picked from commit 7c82a7a8f3a66f47f727d31691d6298d88ed158b)

test/sslapitest.c

index ac49f3ba91be9bfd596dbbb785dc486488820de3..4a3e9648fa520d682c0b3aaa7da3170546a93a30 100644 (file)
@@ -8437,7 +8437,7 @@ static int test_multiblock_write(int test_index)
      * Check if the cipher exists before attempting to use it since it only has
      * a hardware specific implementation.
      */
-    ciph = EVP_CIPHER_fetch(NULL, fetchable_ciphers[test_index], "");
+    ciph = EVP_CIPHER_fetch(libctx, fetchable_ciphers[test_index], "");
     if (ciph == NULL) {
         TEST_skip("Multiblock cipher is not available for %s", cipherlist);
         return 1;