Don't set client_version to the ServerHello version.
authorAdam Langley <agl@google.com>
Sat, 13 Dec 2014 20:13:10 +0000 (20:13 +0000)
committerMatt Caswell <matt@openssl.org>
Tue, 16 Dec 2014 14:44:17 +0000 (14:44 +0000)
The client_version needs to be preserved for the RSA key exchange.

This change also means that renegotiation will, like TLS, repeat the old
client_version rather than advertise only the final version. (Either way,
version change on renego is not allowed.) This is necessary in TLS to work
around an SChannel bug, but it's not strictly necessary in DTLS.

(From BoringSSL)

Reviewed-by: Emilia Käsper <emilia@openssl.org>
ssl/s3_clnt.c

index e178fe1..1aff833 100644 (file)
@@ -944,7 +944,7 @@ int ssl3_get_server_hello(SSL *s)
                        al = SSL_AD_PROTOCOL_VERSION;
                        goto f_err;
                        }
-               s->version = s->client_version = s->method->version;
+               s->version = s->method->version;
                }
 
        if ((p[0] != (s->version>>8)) || (p[1] != (s->version&0xff)))