Use of sparse_array.c only in the shared libssl
authorRichard Levitte <levitte@openssl.org>
Wed, 8 Feb 2023 07:23:41 +0000 (08:23 +0100)
committerRichard Levitte <levitte@openssl.org>
Tue, 14 Feb 2023 15:01:19 +0000 (16:01 +0100)
Conditioning it on $disabled{shared} isn't right, it will still end up
in the static variant of the library.  It's better to use SHARED_SOURCE
for these sorts of things.

Fixes #20238

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20240)

crypto/build.info

index f07c16d90ea5a169fe66a2f57dae156341c6cc55..5c45cd703bf6e52dc8fff6368f70c66f95594d31 100644 (file)
@@ -101,9 +101,7 @@ $UTIL_COMMON=\
         context.c sparse_array.c asn1_dsa.c packet.c param_build.c \
         param_build_set.c der_writer.c threads_lib.c params_dup.c
 
-IF[{- !$disabled{shared} -}]
-  SOURCE[../libssl]=sparse_array.c
-ENDIF
+SHARED_SOURCE[../libssl]=sparse_array.c
 
 SOURCE[../libcrypto]=$UTIL_COMMON \
         mem.c mem_sec.c \