dh: fix coverty 1474423: resource leak
authorPauli <ppzgs1@gmail.com>
Sun, 21 Mar 2021 22:47:58 +0000 (08:47 +1000)
committerPauli <pauli@openssl.org>
Tue, 23 Mar 2021 23:40:26 +0000 (09:40 +1000)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14637)

crypto/dh/dh_backend.c

index 8da830f9d8efb01132501a930f4d232833bc9146..97f5271a5ad2f47fe7699827e555e8296bdd0200 100644 (file)
@@ -161,6 +161,7 @@ DH *ossl_dh_key_from_pkcs8(const PKCS8_PRIV_KEY_INFO *p8inf,
     if ((privkey_bn = BN_secure_new()) == NULL
         || !ASN1_INTEGER_to_BN(privkey, privkey_bn)) {
         ERR_raise(ERR_LIB_DH, DH_R_BN_ERROR);
+        BN_clear_free(privkey_bn);
         goto dherr;
     }
     if (!DH_set0_key(dh, NULL, privkey_bn))