add OSSL_STACK_OF_X509_free() for commonly used pattern

Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/17307)

diff --git a/apps/ca.c b/apps/ca.c
index 1e77bf50c5a72ef855d1f1a8f65b1cc2a96ce61a..a9d6c5c1a60ff4bc2ea283316e79fe28b7631a3b 100644 (file)
--- a/apps/ca.c
+++ b/apps/ca.c
@@ -1325,7 +1325,7 @@ end_of_options:
     BIO_free_all(Sout);
     BIO_free_all(out);
     BIO_free_all(in);
     BIO_free_all(Sout);
     BIO_free_all(out);
     BIO_free_all(in);

-    sk_X509_pop_free(cert_sk, X509_free);
+    OSSL_STACK_OF_X509_free(cert_sk);

 
     cleanse(passin);
     if (free_passin)
 
     cleanse(passin);
     if (free_passin)

diff --git a/apps/cmp.c b/apps/cmp.c
index f994b83b18a4876a1c15e7c8545cc39f686c70cd..0f810129b3924cc0e55b8fbbcfbbdfa85c13c823 100644 (file)
--- a/apps/cmp.c
+++ b/apps/cmp.c
@@ -933,7 +933,7 @@ static int setup_certs(char *files, const char *desc, void *ctx,
     if ((certs = load_certs_multifile(files, opt_otherpass, desc, vpm)) == NULL)
         return 0;
     ok = (*set1_fn)(ctx, certs);
     if ((certs = load_certs_multifile(files, opt_otherpass, desc, vpm)) == NULL)
         return 0;
     ok = (*set1_fn)(ctx, certs);

-    sk_X509_pop_free(certs, X509_free);
+    OSSL_STACK_OF_X509_free(certs);

     return ok;
 }
 
     return ok;
 }
 


@@ -1262,7 +1262,7 @@ static SSL_CTX *setup_ssl_ctx(OSSL_CMP_CTX *ctx, const char *host,
         if (!ok || !SSL_CTX_set0_chain(ssl_ctx, certs)) {
             CMP_err1("unable to use client TLS certificate file '%s'",
                      opt_tls_cert);
         if (!ok || !SSL_CTX_set0_chain(ssl_ctx, certs)) {
             CMP_err1("unable to use client TLS certificate file '%s'",
                      opt_tls_cert);

-            sk_X509_pop_free(certs, X509_free);
+            OSSL_STACK_OF_X509_free(certs);

             goto err;
         }
         for (i = 0; i < sk_X509_num(untrusted); i++) {
             goto err;
         }
         for (i = 0; i < sk_X509_num(untrusted); i++) {


@@ -1441,7 +1441,7 @@ static int setup_protection_ctx(OSSL_CMP_CTX *ctx, ENGINE *engine)
             ok = ok && OSSL_CMP_CTX_build_cert_chain(ctx, own_trusted, certs);
         }
         X509_STORE_free(own_trusted);
             ok = ok && OSSL_CMP_CTX_build_cert_chain(ctx, own_trusted, certs);
         }
         X509_STORE_free(own_trusted);

-        sk_X509_pop_free(certs, X509_free);
+        OSSL_STACK_OF_X509_free(certs);

         if (!ok)
             return 0;
     } else if (opt_own_trusted != NULL) {
         if (!ok)
             return 0;
     } else if (opt_own_trusted != NULL) {


@@ -2020,7 +2020,7 @@ static int save_free_certs(OSSL_CMP_CTX *ctx,
 
  end:
     BIO_free(bio);
 
  end:
     BIO_free(bio);

-    sk_X509_pop_free(certs, X509_free);
+    OSSL_STACK_OF_X509_free(certs);

     return n;
 }
 
     return n;
 }
 

diff --git a/apps/cms.c b/apps/cms.c
index 18671fdc308e843747b31917aae0b90ed85e288d..b49d1e3a68894acc0cd2ce0a48979312f4b8ba81 100644 (file)
--- a/apps/cms.c
+++ b/apps/cms.c
@@ -909,7 +909,7 @@ int cms_main(int argc, char **argv)
                 ret = 5;
                 goto end;
             }
                 ret = 5;
                 goto end;
             }

-            sk_X509_pop_free(allcerts, X509_free);
+            OSSL_STACK_OF_X509_free(allcerts);

         }
     }
 
         }
     }
 


@@ -1237,8 +1237,8 @@ int cms_main(int argc, char **argv)
  end:
     if (ret)
         ERR_print_errors(bio_err);
  end:
     if (ret)
         ERR_print_errors(bio_err);

-    sk_X509_pop_free(encerts, X509_free);
-    sk_X509_pop_free(other, X509_free);
+    OSSL_STACK_OF_X509_free(encerts);
+    OSSL_STACK_OF_X509_free(other);

     X509_VERIFY_PARAM_free(vpm);
     sk_OPENSSL_STRING_free(sksigners);
     sk_OPENSSL_STRING_free(skkeys);
     X509_VERIFY_PARAM_free(vpm);
     sk_OPENSSL_STRING_free(sksigners);
     sk_OPENSSL_STRING_free(skkeys);

diff --git a/apps/lib/apps.c b/apps/lib/apps.c
index 6f697ab481b917a18b5aee8639a73b8490b87ad5..88c4f7b97ae23e58e12610d7942710e65b4321b4 100644 (file)
--- a/apps/lib/apps.c
+++ b/apps/lib/apps.c
@@ -696,7 +696,7 @@ int load_cert_certs(const char *uri,
             warn_cert(uri, *pcert, 0, vpm);
         warn_certs(uri, *pcerts, 1, vpm);
     } else {
             warn_cert(uri, *pcert, 0, vpm);
         warn_certs(uri, *pcerts, 1, vpm);
     } else {

-        sk_X509_pop_free(*pcerts, X509_free);
+        OSSL_STACK_OF_X509_free(*pcerts);

         *pcerts = NULL;
     }
     return ret;
         *pcerts = NULL;
     }
     return ret;


@@ -721,7 +721,7 @@ STACK_OF(X509) *load_certs_multifile(char *files, const char *pass,
         if (!X509_add_certs(result, certs,
                             X509_ADD_FLAG_UP_REF | X509_ADD_FLAG_NO_DUP))
             goto oom;
         if (!X509_add_certs(result, certs,
                             X509_ADD_FLAG_UP_REF | X509_ADD_FLAG_NO_DUP))
             goto oom;

-        sk_X509_pop_free(certs, X509_free);
+        OSSL_STACK_OF_X509_free(certs);

         certs = NULL;
         files = next;
     }
         certs = NULL;
         files = next;
     }


@@ -730,8 +730,8 @@ STACK_OF(X509) *load_certs_multifile(char *files, const char *pass,
  oom:
     BIO_printf(bio_err, "out of memory\n");
  err:
  oom:
     BIO_printf(bio_err, "out of memory\n");
  err:

-    sk_X509_pop_free(certs, X509_free);
-    sk_X509_pop_free(result, X509_free);
+    OSSL_STACK_OF_X509_free(certs);
+    OSSL_STACK_OF_X509_free(result);

     return NULL;
 }
 
     return NULL;
 }
 


@@ -772,7 +772,7 @@ X509_STORE *load_certstore(char *input, const char *pass, const char *desc,
             return NULL;
         }
         ok = (store = sk_X509_to_store(store, certs)) != NULL;
             return NULL;
         }
         ok = (store = sk_X509_to_store(store, certs)) != NULL;

-        sk_X509_pop_free(certs, X509_free);
+        OSSL_STACK_OF_X509_free(certs);

         certs = NULL;
         if (!ok)
             return NULL;
         certs = NULL;
         if (!ok)
             return NULL;


@@ -794,7 +794,7 @@ int load_certs(const char *uri, int maybe_stdin, STACK_OF(X509) **certs,
                                   NULL, NULL, certs, NULL, NULL);
 
     if (!ret && was_NULL) {
                                   NULL, NULL, certs, NULL, NULL);
 
     if (!ret && was_NULL) {

-        sk_X509_pop_free(*certs, X509_free);
+        OSSL_STACK_OF_X509_free(*certs);

         *certs = NULL;
     }
     return ret;
         *certs = NULL;
     }
     return ret;

diff --git a/apps/lib/cmp_mock_srv.c b/apps/lib/cmp_mock_srv.c
index 419b74ce6af4d7630f7888b06c5d9430f7e217a3..5cd2b237374c6d43fedf6b296fdfcdd52f6b84d4 100644 (file)
--- a/apps/lib/cmp_mock_srv.c
+++ b/apps/lib/cmp_mock_srv.c
@@ -38,8 +38,8 @@ static void mock_srv_ctx_free(mock_srv_ctx *ctx)
 
     OSSL_CMP_PKISI_free(ctx->statusOut);
     X509_free(ctx->certOut);
 
     OSSL_CMP_PKISI_free(ctx->statusOut);
     X509_free(ctx->certOut);

-    sk_X509_pop_free(ctx->chainOut, X509_free);
-    sk_X509_pop_free(ctx->caPubsOut, X509_free);
+    OSSL_STACK_OF_X509_free(ctx->chainOut);
+    OSSL_STACK_OF_X509_free(ctx->caPubsOut);

     OSSL_CMP_MSG_free(ctx->certReq);
     OPENSSL_free(ctx);
 }
     OSSL_CMP_MSG_free(ctx->certReq);
     OPENSSL_free(ctx);
 }


@@ -91,7 +91,7 @@ int ossl_cmp_mock_srv_set1_chainOut(OSSL_CMP_SRV_CTX *srv_ctx,
     }
     if (chain != NULL && (chain_copy = X509_chain_up_ref(chain)) == NULL)
         return 0;
     }
     if (chain != NULL && (chain_copy = X509_chain_up_ref(chain)) == NULL)
         return 0;

-    sk_X509_pop_free(ctx->chainOut, X509_free);
+    OSSL_STACK_OF_X509_free(ctx->chainOut);

     ctx->chainOut = chain_copy;
     return 1;
 }
     ctx->chainOut = chain_copy;
     return 1;
 }


@@ -108,7 +108,7 @@ int ossl_cmp_mock_srv_set1_caPubsOut(OSSL_CMP_SRV_CTX *srv_ctx,
     }
     if (caPubs != NULL && (caPubs_copy = X509_chain_up_ref(caPubs)) == NULL)
         return 0;
     }
     if (caPubs != NULL && (caPubs_copy = X509_chain_up_ref(caPubs)) == NULL)
         return 0;

-    sk_X509_pop_free(ctx->caPubsOut, X509_free);
+    OSSL_STACK_OF_X509_free(ctx->caPubsOut);

     ctx->caPubsOut = caPubs_copy;
     return 1;
 }
     ctx->caPubsOut = caPubs_copy;
     return 1;
 }


@@ -252,9 +252,9 @@ static OSSL_CMP_PKISI *process_cert_request(OSSL_CMP_SRV_CTX *srv_ctx,
  err:
     X509_free(*certOut);
     *certOut = NULL;
  err:
     X509_free(*certOut);
     *certOut = NULL;

-    sk_X509_pop_free(*chainOut, X509_free);
+    OSSL_STACK_OF_X509_free(*chainOut);

     *chainOut = NULL;
     *chainOut = NULL;

-    sk_X509_pop_free(*caPubs, X509_free);
+    OSSL_STACK_OF_X509_free(*caPubs);

     *caPubs = NULL;
     return NULL;
 }
     *caPubs = NULL;
     return NULL;
 }

diff --git a/apps/lib/s_cb.c b/apps/lib/s_cb.c
index 50bf00f67121266297a147c2159836a7173dcb93..77ddbc9d7b5152c67676af370634727be007c195 100644 (file)
--- a/apps/lib/s_cb.c
+++ b/apps/lib/s_cb.c
@@ -992,7 +992,7 @@ void ssl_excert_free(SSL_EXCERT *exc)
     while (exc) {
         X509_free(exc->cert);
         EVP_PKEY_free(exc->key);
     while (exc) {
         X509_free(exc->cert);
         EVP_PKEY_free(exc->key);

-        sk_X509_pop_free(exc->chain, X509_free);
+        OSSL_STACK_OF_X509_free(exc->chain);

         curr = exc;
         exc = exc->next;
         OPENSSL_free(curr);
         curr = exc;
         exc = exc->next;
         OPENSSL_free(curr);

diff --git a/apps/ocsp.c b/apps/ocsp.c
index b0d030a940a2b46760331be1b84371f91da89bff..d8e45ccd4388ba5510f8738cc37841782ec6c694 100644 (file)
--- a/apps/ocsp.c
+++ b/apps/ocsp.c
@@ -855,9 +855,9 @@ redo_accept:
     EVP_MD_free(rsign_md);
     EVP_MD_free(resp_certid_md);
     X509_free(cert);
     EVP_MD_free(rsign_md);
     EVP_MD_free(resp_certid_md);
     X509_free(cert);

-    sk_X509_pop_free(issuers, X509_free);
+    OSSL_STACK_OF_X509_free(issuers);

     X509_free(rsigner);
     X509_free(rsigner);

-    sk_X509_pop_free(rca_cert, X509_free);
+    OSSL_STACK_OF_X509_free(rca_cert);

     free_index(rdb);
     BIO_free_all(cbio);
     BIO_free_all(acbio);
     free_index(rdb);
     BIO_free_all(cbio);
     BIO_free_all(acbio);


@@ -867,8 +867,8 @@ redo_accept:
     OCSP_BASICRESP_free(bs);
     sk_OPENSSL_STRING_free(reqnames);
     sk_OCSP_CERTID_free(ids);
     OCSP_BASICRESP_free(bs);
     sk_OPENSSL_STRING_free(reqnames);
     sk_OCSP_CERTID_free(ids);

-    sk_X509_pop_free(sign_other, X509_free);
-    sk_X509_pop_free(verify_other, X509_free);
+    OSSL_STACK_OF_X509_free(sign_other);
+    OSSL_STACK_OF_X509_free(verify_other);

     sk_CONF_VALUE_pop_free(headers, X509V3_conf_free);
     OPENSSL_free(thost);
     OPENSSL_free(tport);
     sk_CONF_VALUE_pop_free(headers, X509V3_conf_free);
     OPENSSL_free(thost);
     OPENSSL_free(tport);

diff --git a/apps/pkcs12.c b/apps/pkcs12.c
index 65dcdad38ac4d7207ea26aabd558454839273036..44b53b0b54ccd7a76a59bc26795a5b5e11b6646a 100644 (file)
--- a/apps/pkcs12.c
+++ b/apps/pkcs12.c
@@ -610,7 +610,7 @@ int pkcs12_main(int argc, char **argv)
                 /* Add the remaining certs (except for duplicates) */
                 add_certs = X509_add_certs(certs, chain2, X509_ADD_FLAG_UP_REF
                                            | X509_ADD_FLAG_NO_DUP);
                 /* Add the remaining certs (except for duplicates) */
                 add_certs = X509_add_certs(certs, chain2, X509_ADD_FLAG_UP_REF
                                            | X509_ADD_FLAG_NO_DUP);

-                sk_X509_pop_free(chain2, X509_free);
+                OSSL_STACK_OF_X509_free(chain2);

                 if (!add_certs)
                     goto export_end;
             } else {
                 if (!add_certs)
                     goto export_end;
             } else {


@@ -697,8 +697,8 @@ int pkcs12_main(int argc, char **argv)
 
         EVP_PKEY_free(key);
         EVP_MD_free(macmd);
 
         EVP_PKEY_free(key);
         EVP_MD_free(macmd);

-        sk_X509_pop_free(certs, X509_free);
-        sk_X509_pop_free(untrusted_certs, X509_free);
+        OSSL_STACK_OF_X509_free(certs);
+        OSSL_STACK_OF_X509_free(untrusted_certs);

         X509_free(ee_cert);
 
         ERR_print_errors(bio_err);
         X509_free(ee_cert);
 
         ERR_print_errors(bio_err);

diff --git a/apps/s_client.c b/apps/s_client.c
index b905fbd3ec93a207546246d7233703c7b568c1da..cdff15a1b60d7646fc63225f6ec770c5860c871e 100644 (file)
--- a/apps/s_client.c
+++ b/apps/s_client.c
@@ -3048,7 +3048,7 @@ int s_client_main(int argc, char **argv)
     X509_free(cert);
     sk_X509_CRL_pop_free(crls, X509_CRL_free);
     EVP_PKEY_free(key);
     X509_free(cert);
     sk_X509_CRL_pop_free(crls, X509_CRL_free);
     EVP_PKEY_free(key);

-    sk_X509_pop_free(chain, X509_free);
+    OSSL_STACK_OF_X509_free(chain);

     OPENSSL_free(pass);
 #ifndef OPENSSL_NO_SRP
     OPENSSL_free(srp_arg.srppassin);
     OPENSSL_free(pass);
 #ifndef OPENSSL_NO_SRP
     OPENSSL_free(srp_arg.srppassin);

diff --git a/apps/s_server.c b/apps/s_server.c
index e0a52287eec3a3ea6c0e8a1f3aa4027d542e0859..9f05cb120add5ba392c0cd554283c6fd196e526c 100644 (file)
--- a/apps/s_server.c
+++ b/apps/s_server.c
@@ -2240,8 +2240,8 @@ int s_server_main(int argc, char *argv[])
     X509_free(s_dcert);
     EVP_PKEY_free(s_key);
     EVP_PKEY_free(s_dkey);
     X509_free(s_dcert);
     EVP_PKEY_free(s_key);
     EVP_PKEY_free(s_dkey);

-    sk_X509_pop_free(s_chain, X509_free);
-    sk_X509_pop_free(s_dchain, X509_free);
+    OSSL_STACK_OF_X509_free(s_chain);
+    OSSL_STACK_OF_X509_free(s_dchain);

     OPENSSL_free(pass);
     OPENSSL_free(dpass);
     OPENSSL_free(host);
     OPENSSL_free(pass);
     OPENSSL_free(dpass);
     OPENSSL_free(host);

diff --git a/apps/smime.c b/apps/smime.c
index 6cf6ab3a452d864708f360ac1f8abe82eecb565c..9677f056ed229ddf6af33a6a9eae90537e12444d 100644 (file)
--- a/apps/smime.c
+++ b/apps/smime.c
@@ -651,8 +651,8 @@ int smime_main(int argc, char **argv)
  end:
     if (ret)
         ERR_print_errors(bio_err);
  end:
     if (ret)
         ERR_print_errors(bio_err);

-    sk_X509_pop_free(encerts, X509_free);
-    sk_X509_pop_free(other, X509_free);
+    OSSL_STACK_OF_X509_free(encerts);
+    OSSL_STACK_OF_X509_free(other);

     X509_VERIFY_PARAM_free(vpm);
     sk_OPENSSL_STRING_free(sksigners);
     sk_OPENSSL_STRING_free(skkeys);
     X509_VERIFY_PARAM_free(vpm);
     sk_OPENSSL_STRING_free(sksigners);
     sk_OPENSSL_STRING_free(skkeys);

diff --git a/apps/verify.c b/apps/verify.c
index acf80c65c4e1253d2b2069e380ff410a2fb5ca98..24bbebf3f399f215f0fe98408f21479eaaa4f794 100644 (file)
--- a/apps/verify.c
+++ b/apps/verify.c
@@ -234,8 +234,8 @@ int verify_main(int argc, char **argv)
  end:
     X509_VERIFY_PARAM_free(vpm);
     X509_STORE_free(store);
  end:
     X509_VERIFY_PARAM_free(vpm);
     X509_STORE_free(store);

-    sk_X509_pop_free(untrusted, X509_free);
-    sk_X509_pop_free(trusted, X509_free);
+    OSSL_STACK_OF_X509_free(untrusted);
+    OSSL_STACK_OF_X509_free(trusted);

     sk_X509_CRL_pop_free(crls, X509_CRL_free);
     sk_OPENSSL_STRING_free(vfyopts);
     release_engine(e);
     sk_X509_CRL_pop_free(crls, X509_CRL_free);
     sk_OPENSSL_STRING_free(vfyopts);
     release_engine(e);


@@ -307,7 +307,7 @@ static int check(X509_STORE *ctx, const char *file,
                     BIO_printf(bio_out, " (untrusted)");
                 BIO_printf(bio_out, "\n");
             }
                     BIO_printf(bio_out, " (untrusted)");
                 BIO_printf(bio_out, "\n");
             }

-            sk_X509_pop_free(chain, X509_free);
+            OSSL_STACK_OF_X509_free(chain);

         }
     } else {
         BIO_printf(bio_err,
         }
     } else {
         BIO_printf(bio_err,

diff --git a/crypto/cmp/cmp_client.c b/crypto/cmp/cmp_client.c
index c7674ce088695c62957da0e3ca8937032822b71b..4a7a87ff74278855816679158d69e847b34a28d7 100644 (file)
--- a/crypto/cmp/cmp_client.c
+++ b/crypto/cmp/cmp_client.c
@@ -514,7 +514,7 @@ int OSSL_CMP_certConf_cb(OSSL_CMP_CTX *ctx, X509 *cert, int fail_info,
                        "success building approximate chain for newly enrolled cert");
     }
     (void)ossl_cmp_ctx_set1_newChain(ctx, chain);
                        "success building approximate chain for newly enrolled cert");
     }
     (void)ossl_cmp_ctx_set1_newChain(ctx, chain);

-    sk_X509_pop_free(chain, X509_free);
+    OSSL_STACK_OF_X509_free(chain);

 
     return fail_info;
 }
 
     return fail_info;
 }

diff --git a/crypto/cmp/cmp_ctx.c b/crypto/cmp/cmp_ctx.c
index 8b53a8a23702d57247228e4e7f5f512eb81320b4..75418a60b81e719a6025818b542a950717479a12 100644 (file)
--- a/crypto/cmp/cmp_ctx.c
+++ b/crypto/cmp/cmp_ctx.c
@@ -61,9 +61,6 @@ DEFINE_OSSL_set0_NAME(OSSL_CMP_CTX, trustedStore, trusted, X509_STORE)
 /* Get current list of non-trusted intermediate certs */
 DEFINE_OSSL_CMP_CTX_get0(untrusted, STACK_OF(X509))
 
 /* Get current list of non-trusted intermediate certs */
 DEFINE_OSSL_CMP_CTX_get0(untrusted, STACK_OF(X509))
 

-#define X509_STACK_free(certs) \
-    sk_X509_pop_free(certs, X509_free)
-

 /*
  * Set untrusted certificates for path construction in authentication of
  * the CMP server and potentially others (TLS server, newly enrolled cert).
 /*
  * Set untrusted certificates for path construction in authentication of
  * the CMP server and potentially others (TLS server, newly enrolled cert).


@@ -79,11 +76,11 @@ int OSSL_CMP_CTX_set1_untrusted(OSSL_CMP_CTX *ctx, STACK_OF(X509) *certs)
     if (!ossl_x509_add_certs_new(&untrusted, certs,
                                  X509_ADD_FLAG_UP_REF | X509_ADD_FLAG_NO_DUP))
         goto err;
     if (!ossl_x509_add_certs_new(&untrusted, certs,
                                  X509_ADD_FLAG_UP_REF | X509_ADD_FLAG_NO_DUP))
         goto err;

-    X509_STACK_free(ctx->untrusted);
+    OSSL_STACK_OF_X509_free(ctx->untrusted);

     ctx->untrusted = untrusted;
     return 1;
  err:
     ctx->untrusted = untrusted;
     return 1;
  err:

-    X509_STACK_free(untrusted);
+    OSSL_STACK_OF_X509_free(untrusted);

     return 0;
 }
 
     return 0;
 }
 


@@ -202,10 +199,10 @@ void OSSL_CMP_CTX_free(OSSL_CMP_CTX *ctx)
     X509_free(ctx->validatedSrvCert);
     X509_NAME_free(ctx->expected_sender);
     X509_STORE_free(ctx->trusted);
     X509_free(ctx->validatedSrvCert);
     X509_NAME_free(ctx->expected_sender);
     X509_STORE_free(ctx->trusted);

-    X509_STACK_free(ctx->untrusted);
+    OSSL_STACK_OF_X509_free(ctx->untrusted);

 
     X509_free(ctx->cert);
 
     X509_free(ctx->cert);

-    X509_STACK_free(ctx->chain);
+    OSSL_STACK_OF_X509_free(ctx->chain);

     EVP_PKEY_free(ctx->pkey);
     ASN1_OCTET_STRING_free(ctx->referenceValue);
     if (ctx->secretValue != NULL)
     EVP_PKEY_free(ctx->pkey);
     ASN1_OCTET_STRING_free(ctx->referenceValue);
     if (ctx->secretValue != NULL)


@@ -219,7 +216,7 @@ void OSSL_CMP_CTX_free(OSSL_CMP_CTX *ctx)
     ASN1_OCTET_STRING_free(ctx->senderNonce);
     ASN1_OCTET_STRING_free(ctx->recipNonce);
     OSSL_CMP_ITAVs_free(ctx->geninfo_ITAVs);
     ASN1_OCTET_STRING_free(ctx->senderNonce);
     ASN1_OCTET_STRING_free(ctx->recipNonce);
     OSSL_CMP_ITAVs_free(ctx->geninfo_ITAVs);

-    X509_STACK_free(ctx->extraCertsOut);
+    OSSL_STACK_OF_X509_free(ctx->extraCertsOut);

 
     EVP_PKEY_free(ctx->newPkey);
     X509_NAME_free(ctx->issuer);
 
     EVP_PKEY_free(ctx->newPkey);
     X509_NAME_free(ctx->issuer);


@@ -234,9 +231,9 @@ void OSSL_CMP_CTX_free(OSSL_CMP_CTX *ctx)
 
     OSSL_CMP_PKIFREETEXT_free(ctx->statusString);
     X509_free(ctx->newCert);
 
     OSSL_CMP_PKIFREETEXT_free(ctx->statusString);
     X509_free(ctx->newCert);

-    X509_STACK_free(ctx->newChain);
-    X509_STACK_free(ctx->caPubs);
-    X509_STACK_free(ctx->extraCertsIn);
+    OSSL_STACK_OF_X509_free(ctx->newChain);
+    OSSL_STACK_OF_X509_free(ctx->caPubs);
+    OSSL_STACK_OF_X509_free(ctx->extraCertsIn);

 
     OPENSSL_free(ctx);
 }
 
     OPENSSL_free(ctx);
 }


@@ -469,7 +466,7 @@ int PREFIX##_set1_##FIELD(OSSL_CMP_CTX *ctx, STACK_OF(X509) *certs) \
         ERR_raise(ERR_LIB_CMP, CMP_R_NULL_ARGUMENT); \
         return 0; \
     } \
         ERR_raise(ERR_LIB_CMP, CMP_R_NULL_ARGUMENT); \
         return 0; \
     } \

-    X509_STACK_free(ctx->FIELD); \
+    OSSL_STACK_OF_X509_free(ctx->FIELD); \

     ctx->FIELD = NULL; \
     return certs == NULL || (ctx->FIELD = X509_chain_up_ref(certs)) != NULL; \
 }
     ctx->FIELD = NULL; \
     return certs == NULL || (ctx->FIELD = X509_chain_up_ref(certs)) != NULL; \
 }

diff --git a/crypto/cmp/cmp_server.c b/crypto/cmp/cmp_server.c
index c32737d0e3bb74465ee2bb2d56c5c12d362f8a7a..bf5c5fdb57488b407fb758ca8a4ea0630e7ab0d9 100644 (file)
--- a/crypto/cmp/cmp_server.c
+++ b/crypto/cmp/cmp_server.c
@@ -234,8 +234,8 @@ static OSSL_CMP_MSG *process_cert_request(OSSL_CMP_SRV_CTX *srv_ctx,
  err:
     OSSL_CMP_PKISI_free(si);
     X509_free(certOut);
  err:
     OSSL_CMP_PKISI_free(si);
     X509_free(certOut);

-    sk_X509_pop_free(chainOut, X509_free);
-    sk_X509_pop_free(caPubs, X509_free);
+    OSSL_STACK_OF_X509_free(chainOut);
+    OSSL_STACK_OF_X509_free(caPubs);

     return msg;
 }
 
     return msg;
 }
 

diff --git a/crypto/cmp/cmp_vfy.c b/crypto/cmp/cmp_vfy.c
index bea7e506b672c2cef8119e9fc7af25c995a244a2..e5ca1083d76bb224c377f33484863f5e74f4ab38 100644 (file)
--- a/crypto/cmp/cmp_vfy.c
+++ b/crypto/cmp/cmp_vfy.c
@@ -432,7 +432,7 @@ static int check_msg_all_certs(OSSL_CMP_CTX *ctx, const OSSL_CMP_MSG *msg,
                                              : "certs in trusted store",
                                    msg->extraCerts, ctx->untrusted,
                                    msg, mode_3gpp);
                                              : "certs in trusted store",
                                    msg->extraCerts, ctx->untrusted,
                                    msg, mode_3gpp);

-        sk_X509_pop_free(trusted, X509_free);
+        OSSL_STACK_OF_X509_free(trusted);

     }
     return ret;
 }
     }
     return ret;
 }

diff --git a/crypto/cms/cms_lib.c b/crypto/cms/cms_lib.c
index 4ad9302910f3ea2f7869453f881802a9cd41bea6..0b25bc234eb9f470ea2e7dd125aebe8a25aa43cb 100644 (file)
--- a/crypto/cms/cms_lib.c
+++ b/crypto/cms/cms_lib.c
@@ -634,7 +634,7 @@ STACK_OF(X509) *CMS_get1_certs(CMS_ContentInfo *cms)
         if (cch->type == 0) {
             if (!ossl_x509_add_cert_new(&certs, cch->d.certificate,
                                         X509_ADD_FLAG_UP_REF)) {
         if (cch->type == 0) {
             if (!ossl_x509_add_cert_new(&certs, cch->d.certificate,
                                         X509_ADD_FLAG_UP_REF)) {

-                sk_X509_pop_free(certs, X509_free);
+                OSSL_STACK_OF_X509_free(certs);

                 return NULL;
             }
         }
                 return NULL;
             }
         }

diff --git a/crypto/cms/cms_smime.c b/crypto/cms/cms_smime.c
index 4e80a13b4daa0a3335132807695e23b90bd0b8eb..b82eee32cb2157bfbac75cb4ec8022ff458a4d17 100644 (file)
--- a/crypto/cms/cms_smime.c
+++ b/crypto/cms/cms_smime.c
@@ -478,10 +478,10 @@ int CMS_verify(CMS_ContentInfo *cms, STACK_OF(X509) *certs,
  err2:
     if (si_chains != NULL) {
         for (i = 0; i < scount; ++i)
  err2:
     if (si_chains != NULL) {
         for (i = 0; i < scount; ++i)

-            sk_X509_pop_free(si_chains[i], X509_free);
+            OSSL_STACK_OF_X509_free(si_chains[i]);

         OPENSSL_free(si_chains);
     }
         OPENSSL_free(si_chains);
     }

-    sk_X509_pop_free(cms_certs, X509_free);
+    OSSL_STACK_OF_X509_free(cms_certs);

     sk_X509_CRL_pop_free(crls, X509_CRL_free);
 
     return ret;
     sk_X509_CRL_pop_free(crls, X509_CRL_free);
 
     return ret;

diff --git a/crypto/ocsp/ocsp_vfy.c b/crypto/ocsp/ocsp_vfy.c
index 7a4a45d537db02e12a8e847335da2524067d5a21..ceefafc2a618d3cc906327b8bcf9fec018c1d407 100644 (file)
--- a/crypto/ocsp/ocsp_vfy.c
+++ b/crypto/ocsp/ocsp_vfy.c
@@ -153,7 +153,7 @@ int OCSP_basic_verify(OCSP_BASICRESP *bs, STACK_OF(X509) *certs,
     }
 
  end:
     }
 
  end:

-    sk_X509_pop_free(chain, X509_free);
+    OSSL_STACK_OF_X509_free(chain);

     sk_X509_free(untrusted);
     return ret;
 }
     sk_X509_free(untrusted);
     return ret;
 }

diff --git a/crypto/pkcs12/p12_kiss.c b/crypto/pkcs12/p12_kiss.c
index 229b34cf64295f577416bc4985c10a5fd74e13e3..ed1105cee42b4b602551a61d5d303d6bc762d94c 100644 (file)
--- a/crypto/pkcs12/p12_kiss.c
+++ b/crypto/pkcs12/p12_kiss.c
@@ -125,7 +125,7 @@ int PKCS12_parse(PKCS12 *p12, const char *pass, EVP_PKEY **pkey, X509 **cert,
         *cert = NULL;
     }
     X509_free(x);
         *cert = NULL;
     }
     X509_free(x);

-    sk_X509_pop_free(ocerts, X509_free);
+    OSSL_STACK_OF_X509_free(ocerts);

     return 0;
 
 }
     return 0;
 
 }

diff --git a/crypto/store/store_result.c b/crypto/store/store_result.c
index 3a0dc9dfba9357d4b7f229160ad9ec13c6b7e3e1..3f21c904f4ebee3b97dcafdb3124f790a55f3aa2 100644 (file)
--- a/crypto/store/store_result.c
+++ b/crypto/store/store_result.c
@@ -603,7 +603,7 @@ static int try_pkcs12(struct extracted_param_data_st *data, OSSL_STORE_INFO **v,
                 }
                 EVP_PKEY_free(pkey);
                 X509_free(cert);
                 }
                 EVP_PKEY_free(pkey);
                 X509_free(cert);

-                sk_X509_pop_free(chain, X509_free);
+                OSSL_STACK_OF_X509_free(chain);

                 OSSL_STORE_INFO_free(osi_pkey);
                 OSSL_STORE_INFO_free(osi_cert);
                 OSSL_STORE_INFO_free(osi_ca);
                 OSSL_STORE_INFO_free(osi_pkey);
                 OSSL_STORE_INFO_free(osi_cert);
                 OSSL_STORE_INFO_free(osi_ca);

diff --git a/crypto/ts/ts_conf.c b/crypto/ts/ts_conf.c
index fd2ad90754b04f20756f84c4f43f042c28bc5905..c415839995df11c87782f490b000723e9f52edf2 100644 (file)
--- a/crypto/ts/ts_conf.c
+++ b/crypto/ts/ts_conf.c
@@ -78,7 +78,7 @@ STACK_OF(X509) *TS_CONF_load_certs(const char *file)
 
         if (xi->x509 != NULL) {
             if (!X509_add_cert(othercerts, xi->x509, X509_ADD_FLAG_DEFAULT)) {
 
         if (xi->x509 != NULL) {
             if (!X509_add_cert(othercerts, xi->x509, X509_ADD_FLAG_DEFAULT)) {

-                sk_X509_pop_free(othercerts, X509_free);
+                OSSL_STACK_OF_X509_free(othercerts);

                 othercerts = NULL;
                 goto end;
             }
                 othercerts = NULL;
                 goto end;
             }


@@ -233,7 +233,7 @@ int TS_CONF_set_certs(CONF *conf, const char *section, const char *certs,
  end:
     ret = 1;
  err:
  end:
     ret = 1;
  err:

-    sk_X509_pop_free(certs_obj, X509_free);
+    OSSL_STACK_OF_X509_free(certs_obj);

     return ret;
 }
 
     return ret;
 }
 

diff --git a/crypto/ts/ts_rsp_sign.c b/crypto/ts/ts_rsp_sign.c
index 8937bb2d6671e6f0d4b83b6d209e7d86613dc8cc..cf3e5443dee95ff43861ab029edc583ae8223f39 100644 (file)
--- a/crypto/ts/ts_rsp_sign.c
+++ b/crypto/ts/ts_rsp_sign.c
@@ -147,7 +147,7 @@ void TS_RESP_CTX_free(TS_RESP_CTX *ctx)
     OPENSSL_free(ctx->propq);
     X509_free(ctx->signer_cert);
     EVP_PKEY_free(ctx->signer_key);
     OPENSSL_free(ctx->propq);
     X509_free(ctx->signer_cert);
     EVP_PKEY_free(ctx->signer_key);

-    sk_X509_pop_free(ctx->certs, X509_free);
+    OSSL_STACK_OF_X509_free(ctx->certs);

     sk_ASN1_OBJECT_pop_free(ctx->policies, ASN1_OBJECT_free);
     ASN1_OBJECT_free(ctx->default_policy);
     sk_EVP_MD_free(ctx->mds);   /* No EVP_MD_free method exists. */
     sk_ASN1_OBJECT_pop_free(ctx->policies, ASN1_OBJECT_free);
     ASN1_OBJECT_free(ctx->default_policy);
     sk_EVP_MD_free(ctx->mds);   /* No EVP_MD_free method exists. */


@@ -197,7 +197,7 @@ int TS_RESP_CTX_set_def_policy(TS_RESP_CTX *ctx, const ASN1_OBJECT *def_policy)
 
 int TS_RESP_CTX_set_certs(TS_RESP_CTX *ctx, STACK_OF(X509) *certs)
 {
 
 int TS_RESP_CTX_set_certs(TS_RESP_CTX *ctx, STACK_OF(X509) *certs)
 {

-    sk_X509_pop_free(ctx->certs, X509_free);
+    OSSL_STACK_OF_X509_free(ctx->certs);

     ctx->certs = NULL;
 
     return certs == NULL || (ctx->certs = X509_chain_up_ref(certs)) != NULL;
     ctx->certs = NULL;
 
     return certs == NULL || (ctx->certs = X509_chain_up_ref(certs)) != NULL;

diff --git a/crypto/ts/ts_rsp_verify.c b/crypto/ts/ts_rsp_verify.c
index 792a27ce572b32c3a8c2fda59021e66c2fd952e7..410f6882559db69e3448e9988f5e289a7debd9e3 100644 (file)
--- a/crypto/ts/ts_rsp_verify.c
+++ b/crypto/ts/ts_rsp_verify.c
@@ -158,7 +158,7 @@ int TS_RESP_verify_signature(PKCS7 *token, STACK_OF(X509) *certs,
  err:
     BIO_free_all(p7bio);
     sk_X509_free(untrusted);
  err:
     BIO_free_all(p7bio);
     sk_X509_free(untrusted);

-    sk_X509_pop_free(chain, X509_free);
+    OSSL_STACK_OF_X509_free(chain);

     sk_X509_free(signers);
 
     return ret;
     sk_X509_free(signers);
 
     return ret;

diff --git a/crypto/ts/ts_verify_ctx.c b/crypto/ts/ts_verify_ctx.c
index 2f6f00c0ccd694747645ed3d5626421a1b173e5a..127e35623e7171a42e3d6f331314413193d9fa86 100644 (file)
--- a/crypto/ts/ts_verify_ctx.c
+++ b/crypto/ts/ts_verify_ctx.c
@@ -82,7 +82,7 @@ void TS_VERIFY_CTX_cleanup(TS_VERIFY_CTX *ctx)
         return;
 
     X509_STORE_free(ctx->store);
         return;
 
     X509_STORE_free(ctx->store);

-    sk_X509_pop_free(ctx->certs, X509_free);
+    OSSL_STACK_OF_X509_free(ctx->certs);

 
     ASN1_OBJECT_free(ctx->policy);
 
 
     ASN1_OBJECT_free(ctx->policy);
 

diff --git a/crypto/x509/t_x509.c b/crypto/x509/t_x509.c
index 13ccb35508a5f9139ef888039c8bb4512951009f..3e022ccbcb220ab3e1f005558a633b1903a1ec37 100644 (file)
--- a/crypto/x509/t_x509.c
+++ b/crypto/x509/t_x509.c
@@ -17,6 +17,11 @@
 #include "crypto/asn1.h"
 #include "crypto/x509.h"
 
 #include "crypto/asn1.h"
 #include "crypto/x509.h"
 

+void OSSL_STACK_OF_X509_free(STACK_OF(X509) *certs)
+{
+    sk_X509_pop_free(certs, X509_free);
+}
+

 #ifndef OPENSSL_NO_STDIO
 int X509_print_fp(FILE *fp, X509 *x)
 {
 #ifndef OPENSSL_NO_STDIO
 int X509_print_fp(FILE *fp, X509 *x)
 {


@@ -456,7 +461,7 @@ static int print_store_certs(BIO *bio, X509_STORE *store)
         STACK_OF(X509) *certs = X509_STORE_get1_all_certs(store);
         int ret = print_certs(bio, certs);
 
         STACK_OF(X509) *certs = X509_STORE_get1_all_certs(store);
         int ret = print_certs(bio, certs);
 

-        sk_X509_pop_free(certs, X509_free);
+        OSSL_STACK_OF_X509_free(certs);

         return ret;
     } else {
         return BIO_printf(bio, "    (no trusted store)\n") >= 0;
         return ret;
     } else {
         return BIO_printf(bio, "    (no trusted store)\n") >= 0;

diff --git a/crypto/x509/x509_lu.c b/crypto/x509/x509_lu.c
index 3b76b92f713856819cbccfcc2cdfa01fa9bf499c..34bc7417aca9fbf92e12ca5241836da22fbf0f7a 100644 (file)
--- a/crypto/x509/x509_lu.c
+++ b/crypto/x509/x509_lu.c
@@ -567,7 +567,7 @@ STACK_OF(X509) *X509_STORE_get1_all_certs(X509_STORE *store)
 
  err:
     X509_STORE_unlock(store);
 
  err:
     X509_STORE_unlock(store);

-    sk_X509_pop_free(sk, X509_free);
+    OSSL_STACK_OF_X509_free(sk);

     return NULL;
 }
 
     return NULL;
 }
 


@@ -615,7 +615,7 @@ STACK_OF(X509) *X509_STORE_CTX_get1_certs(X509_STORE_CTX *ctx,
         x = obj->data.x509;
         if (!X509_add_cert(sk, x, X509_ADD_FLAG_UP_REF)) {
             X509_STORE_unlock(store);
         x = obj->data.x509;
         if (!X509_add_cert(sk, x, X509_ADD_FLAG_UP_REF)) {
             X509_STORE_unlock(store);

-            sk_X509_pop_free(sk, X509_free);
+            OSSL_STACK_OF_X509_free(sk);

             return NULL;
         }
     }
             return NULL;
         }
     }

diff --git a/crypto/x509/x509_vfy.c b/crypto/x509/x509_vfy.c
index 8ab6381daf3983d30a02c4806e63c3da8ad25ad2..8a7f1ba8e830cff0494c6b9916244d7674651fb1 100644 (file)
--- a/crypto/x509/x509_vfy.c
+++ b/crypto/x509/x509_vfy.c
@@ -138,7 +138,7 @@ static int lookup_cert_match(X509 **result, X509_STORE_CTX *ctx, X509 *x)
         else
             *result = xtmp;
     }
         else
             *result = xtmp;
     }

-    sk_X509_pop_free(certs, X509_free);
+    OSSL_STACK_OF_X509_free(certs);

     return ret;
 }
 
     return ret;
 }
 


@@ -385,7 +385,7 @@ static STACK_OF(X509) *lookup_certs_sk(X509_STORE_CTX *ctx,
         x = sk_X509_value(ctx->other_ctx, i);
         if (X509_NAME_cmp(nm, X509_get_subject_name(x)) == 0) {
             if (!X509_add_cert(sk, x, X509_ADD_FLAG_UP_REF)) {
         x = sk_X509_value(ctx->other_ctx, i);
         if (X509_NAME_cmp(nm, X509_get_subject_name(x)) == 0) {
             if (!X509_add_cert(sk, x, X509_ADD_FLAG_UP_REF)) {

-                sk_X509_pop_free(sk, X509_free);
+                OSSL_STACK_OF_X509_free(sk);

                 ctx->error = X509_V_ERR_OUT_OF_MEM;
                 return NULL;
             }
                 ctx->error = X509_V_ERR_OUT_OF_MEM;
                 return NULL;
             }


@@ -2484,7 +2484,7 @@ void X509_STORE_CTX_cleanup(X509_STORE_CTX *ctx)
     }
     X509_policy_tree_free(ctx->tree);
     ctx->tree = NULL;
     }
     X509_policy_tree_free(ctx->tree);
     ctx->tree = NULL;

-    sk_X509_pop_free(ctx->chain, X509_free);
+    OSSL_STACK_OF_X509_free(ctx->chain);

     ctx->chain = NULL;
     CRYPTO_free_ex_data(CRYPTO_EX_INDEX_X509_STORE_CTX, ctx, &(ctx->ex_data));
     memset(&ctx->ex_data, 0, sizeof(ctx->ex_data));
     ctx->chain = NULL;
     CRYPTO_free_ex_data(CRYPTO_EX_INDEX_X509_STORE_CTX, ctx, &(ctx->ex_data));
     memset(&ctx->ex_data, 0, sizeof(ctx->ex_data));


@@ -2523,7 +2523,7 @@ void X509_STORE_CTX_set0_untrusted(X509_STORE_CTX *ctx, STACK_OF(X509) *sk)
 
 void X509_STORE_CTX_set0_verified_chain(X509_STORE_CTX *ctx, STACK_OF(X509) *sk)
 {
 
 void X509_STORE_CTX_set0_verified_chain(X509_STORE_CTX *ctx, STACK_OF(X509) *sk)
 {

-    sk_X509_pop_free(ctx->chain, X509_free);
+    OSSL_STACK_OF_X509_free(ctx->chain);

     ctx->chain = sk;
 }
 
     ctx->chain = sk;
 }
 

diff --git a/demos/cms/cms_denc.c b/demos/cms/cms_denc.c
index 60b0aa192bc008ddf2ea5bfb3136283c6e12e834..4a2219dee3e8935f0157b774967cec0be2b23386 100644 (file)
--- a/demos/cms/cms_denc.c
+++ b/demos/cms/cms_denc.c
@@ -46,8 +46,8 @@ int main(int argc, char **argv)
         goto err;
 
     /*
         goto err;
 
     /*

-     * sk_X509_pop_free will free up recipient STACK and its contents so set
-     * rcert to NULL so it isn't freed up twice.
+     * OSSL_STACK_OF_X509_free() free up recipient STACK and its contents
+     * so set rcert to NULL so it isn't freed up twice.

      */
     rcert = NULL;
 
      */
     rcert = NULL;
 


@@ -88,7 +88,7 @@ int main(int argc, char **argv)
 
     CMS_ContentInfo_free(cms);
     X509_free(rcert);
 
     CMS_ContentInfo_free(cms);
     X509_free(rcert);

-    sk_X509_pop_free(recips, X509_free);
+    OSSL_STACK_OF_X509_free(recips);

     BIO_free(in);
     BIO_free(out);
     BIO_free(dout);
     BIO_free(in);
     BIO_free(out);
     BIO_free(dout);

diff --git a/demos/cms/cms_enc.c b/demos/cms/cms_enc.c
index 9ef7a395583dc8191e1d1cee093631a7f3ea9e18..ff5632a714fdce7ef5f2e166e0f3f6a40e3af8ee 100644 (file)
--- a/demos/cms/cms_enc.c
+++ b/demos/cms/cms_enc.c
@@ -47,8 +47,8 @@ int main(int argc, char **argv)
         goto err;
 
     /*
         goto err;
 
     /*

-     * sk_X509_pop_free will free up recipient STACK and its contents so set
-     * rcert to NULL so it isn't freed up twice.
+     * OSSL_STACK_OF_X509_free() will free up recipient STACK and its contents
+     * so set rcert to NULL so it isn't freed up twice.

      */
     rcert = NULL;
 
      */
     rcert = NULL;
 


@@ -84,7 +84,7 @@ int main(int argc, char **argv)
 
     CMS_ContentInfo_free(cms);
     X509_free(rcert);
 
     CMS_ContentInfo_free(cms);
     X509_free(rcert);

-    sk_X509_pop_free(recips, X509_free);
+    OSSL_STACK_OF_X509_free(recips);

     BIO_free(in);
     BIO_free(out);
     BIO_free(tbio);
     BIO_free(in);
     BIO_free(out);
     BIO_free(tbio);

diff --git a/demos/pkcs12/pkread.c b/demos/pkcs12/pkread.c
index 3b153f8edf151fbbaaccc48f693912b1179325ab..7deeef9ef0096a999ca28415299d682c11a00049 100644 (file)
--- a/demos/pkcs12/pkread.c
+++ b/demos/pkcs12/pkread.c
@@ -105,7 +105,7 @@ int main(int argc, char **argv)
     OPENSSL_free(name);
     X509_free(cert);
     EVP_PKEY_free(pkey);
     OPENSSL_free(name);
     X509_free(cert);
     EVP_PKEY_free(pkey);

-    sk_X509_pop_free(ca, X509_free);
+    OSSL_STACK_OF_X509_free(ca);

 
     return ret;
 }
 
     return ret;
 }

diff --git a/demos/smime/smenc.c b/demos/smime/smenc.c
index 0714dddfd2c917cfff61c02df9639f1d2310e5e6..ab44a22bb38f17d40039026a94d1970dc4ee7a1f 100644 (file)
--- a/demos/smime/smenc.c
+++ b/demos/smime/smenc.c
@@ -47,8 +47,8 @@ int main(int argc, char **argv)
         goto err;
 
     /*
         goto err;
 
     /*

-     * sk_X509_pop_free will free up recipient STACK and its contents so set
-     * rcert to NULL so it isn't freed up twice.
+     * OSSL_STACK_OF_X509_free() will free up recipient STACK and its contents
+     * so set rcert to NULL so it isn't freed up twice.

      */
     rcert = NULL;
 
      */
     rcert = NULL;
 


@@ -82,7 +82,7 @@ int main(int argc, char **argv)
     }
     PKCS7_free(p7);
     X509_free(rcert);
     }
     PKCS7_free(p7);
     X509_free(rcert);

-    sk_X509_pop_free(recips, X509_free);
+    OSSL_STACK_OF_X509_free(recips);

     BIO_free(in);
     BIO_free(out);
     BIO_free(tbio);
     BIO_free(in);
     BIO_free(out);
     BIO_free(tbio);

diff --git a/doc/man3/X509_STORE_CTX_get_error.pod b/doc/man3/X509_STORE_CTX_get_error.pod
index 04005f3ecdb385ce3f88c7cfa1a4a7f772c55497..901113c9173245f87cb8ba69692e2daa810c2986 100644 (file)
--- a/doc/man3/X509_STORE_CTX_get_error.pod
+++ b/doc/man3/X509_STORE_CTX_get_error.pod
@@ -72,7 +72,7 @@ verification is successful. Otherwise the returned chain may be incomplete or
 invalid.  The returned chain persists after the I<ctx> structure is freed.
 When it is no longer needed it should be free up using:
 
 invalid.  The returned chain persists after the I<ctx> structure is freed.
 When it is no longer needed it should be free up using:
 

- sk_X509_pop_free(chain, X509_free);
+ OSSL_STACK_OF_X509_free(chain);

 
 X509_verify_cert_error_string() returns a human readable error string for
 verification error I<n>.
 
 X509_verify_cert_error_string() returns a human readable error string for
 verification error I<n>.

diff --git a/doc/man3/X509_new.pod b/doc/man3/X509_new.pod
index ea2b3a2cc9b0dc7ae9bb99e31e9877eb4f09cb14..f1d07bf79e214069a3ad8c4878849db1b949cab0 100644 (file)
--- a/doc/man3/X509_new.pod
+++ b/doc/man3/X509_new.pod
@@ -4,7 +4,9 @@
 
 X509_new, X509_new_ex,
 X509_free, X509_up_ref,
 
 X509_new, X509_new_ex,
 X509_free, X509_up_ref,

-X509_chain_up_ref - X509 certificate ASN1 allocation functions
+X509_chain_up_ref,
+OSSL_STACK_OF_X509_free
+- X509 certificate ASN1 allocation and deallocation functions

 
 =head1 SYNOPSIS
 
 
 =head1 SYNOPSIS
 


@@ -15,6 +17,7 @@ X509_chain_up_ref - X509 certificate ASN1 allocation functions
  void X509_free(X509 *a);
  int X509_up_ref(X509 *a);
  STACK_OF(X509) *X509_chain_up_ref(STACK_OF(X509) *x);
  void X509_free(X509 *a);
  int X509_up_ref(X509 *a);
  STACK_OF(X509) *X509_chain_up_ref(STACK_OF(X509) *x);

+ void OSSL_STACK_OF_X509_free(STACK_OF(X509) *certs);

 
 =head1 DESCRIPTION
 
 
 =head1 DESCRIPTION
 


@@ -40,6 +43,9 @@ X509_up_ref() increments the reference count of B<a>.
 X509_chain_up_ref() increases the reference count of all certificates in
 chain B<x> and returns a copy of the stack, or an empty stack if B<a> is NULL.
 
 X509_chain_up_ref() increases the reference count of all certificates in
 chain B<x> and returns a copy of the stack, or an empty stack if B<a> is NULL.
 

+OSSL_STACK_OF_X509_free() deallocates the given list of pointers to
+certificates after calling X509_free() on all its elements.
+

 =head1 NOTES
 
 The function X509_up_ref() if useful if a certificate structure is being
 =head1 NOTES
 
 The function X509_up_ref() if useful if a certificate structure is being


@@ -61,6 +67,8 @@ X509_up_ref() returns 1 for success and 0 for failure.
 
 X509_chain_up_ref() returns a copy of the stack or NULL if an error occurred.
 
 
 X509_chain_up_ref() returns a copy of the stack or NULL if an error occurred.
 

+OSSL_STACK_OF_X509_free() has no return value.
+

 =head1 SEE ALSO
 
 L<d2i_X509(3)>,
 =head1 SEE ALSO
 
 L<d2i_X509(3)>,


@@ -82,7 +90,9 @@ L<X509_verify_cert(3)>
 
 =head1 HISTORY
 
 
 =head1 HISTORY
 

-The function X509_new_ex() was added in OpenSSL 3.0.
+X509_new_ex() was added in OpenSSL 3.0.
+
+OSSL_STACK_OF_X509_free() was added in OpenSSL 3.1.

 
 =head1 COPYRIGHT
 
 
 =head1 COPYRIGHT
 

diff --git a/engines/e_loader_attic.c b/engines/e_loader_attic.c
index e675b006a84a04b9d549d4a4796ff333d7a42e8c..e2a5474c1ce75d434feff84bf1a4f7f53ab57863 100644 (file)
--- a/engines/e_loader_attic.c
+++ b/engines/e_loader_attic.c
@@ -375,7 +375,7 @@ static OSSL_STORE_INFO *try_decode_PKCS12(const char *pem_name,
                 }
                 EVP_PKEY_free(pkey);
                 X509_free(cert);
                 }
                 EVP_PKEY_free(pkey);
                 X509_free(cert);

-                sk_X509_pop_free(chain, X509_free);
+                OSSL_STACK_OF_X509_free(chain);

                 store_info_free(osi_pkey);
                 store_info_free(osi_cert);
                 store_info_free(osi_ca);
                 store_info_free(osi_pkey);
                 store_info_free(osi_cert);
                 store_info_free(osi_ca);

diff --git a/include/openssl/x509.h.in b/include/openssl/x509.h.in
index b4efbb55ddbab20d8e3128db25897518ec94259d..aee3a44dc26e29d3d0152a60756f7e1db5e1c199 100644 (file)
--- a/include/openssl/x509.h.in
+++ b/include/openssl/x509.h.in
@@ -763,6 +763,7 @@ int X509_chain_check_suiteb(int *perror_depth,
                             X509 *x, STACK_OF(X509) *chain,
                             unsigned long flags);
 int X509_CRL_check_suiteb(X509_CRL *crl, EVP_PKEY *pk, unsigned long flags);
                             X509 *x, STACK_OF(X509) *chain,
                             unsigned long flags);
 int X509_CRL_check_suiteb(X509_CRL *crl, EVP_PKEY *pk, unsigned long flags);

+void OSSL_STACK_OF_X509_free(STACK_OF(X509) *certs);

 STACK_OF(X509) *X509_chain_up_ref(STACK_OF(X509) *chain);
 
 int X509_issuer_and_serial_cmp(const X509 *a, const X509 *b);
 STACK_OF(X509) *X509_chain_up_ref(STACK_OF(X509) *chain);
 
 int X509_issuer_and_serial_cmp(const X509 *a, const X509 *b);

diff --git a/ssl/s3_lib.c b/ssl/s3_lib.c
index 874b36fad0038c5fe48c0d234e7230a37f81810d..120b5cedebf5bd1946713ba0ab626077be2d37cf 100644 (file)
--- a/ssl/s3_lib.c
+++ b/ssl/s3_lib.c
@@ -3956,7 +3956,7 @@ long ssl3_ctx_ctrl(SSL_CTX *ctx, int cmd, long larg, void *parg)
         break;
 
     case SSL_CTRL_CLEAR_EXTRA_CHAIN_CERTS:
         break;
 
     case SSL_CTRL_CLEAR_EXTRA_CHAIN_CERTS:

-        sk_X509_pop_free(ctx->extra_certs, X509_free);
+        OSSL_STACK_OF_X509_free(ctx->extra_certs);

         ctx->extra_certs = NULL;
         break;
 
         ctx->extra_certs = NULL;
         break;
 

diff --git a/ssl/ssl_cert.c b/ssl/ssl_cert.c
index 82028ec5b76d0e6c2794475c51fe3f2c86d03454..4cfd005ebe85be4b524cfedffb03af79645fabcf 100644 (file)
--- a/ssl/ssl_cert.c
+++ b/ssl/ssl_cert.c
@@ -212,7 +212,7 @@ void ssl_cert_clear_certs(CERT *c)
         cpk->x509 = NULL;
         EVP_PKEY_free(cpk->privatekey);
         cpk->privatekey = NULL;
         cpk->x509 = NULL;
         EVP_PKEY_free(cpk->privatekey);
         cpk->privatekey = NULL;

-        sk_X509_pop_free(cpk->chain, X509_free);
+        OSSL_STACK_OF_X509_free(cpk->chain);

         cpk->chain = NULL;
         OPENSSL_free(cpk->serverinfo);
         cpk->serverinfo = NULL;
         cpk->chain = NULL;
         OPENSSL_free(cpk->serverinfo);
         cpk->serverinfo = NULL;


@@ -264,7 +264,7 @@ int ssl_cert_set0_chain(SSL *s, SSL_CTX *ctx, STACK_OF(X509) *chain)
             return 0;
         }
     }
             return 0;
         }
     }

-    sk_X509_pop_free(cpk->chain, X509_free);
+    OSSL_STACK_OF_X509_free(cpk->chain);

     cpk->chain = chain;
     return 1;
 }
     cpk->chain = chain;
     return 1;
 }


@@ -278,7 +278,7 @@ int ssl_cert_set1_chain(SSL *s, SSL_CTX *ctx, STACK_OF(X509) *chain)
     if (!dchain)
         return 0;
     if (!ssl_cert_set0_chain(s, ctx, dchain)) {
     if (!dchain)
         return 0;
     if (!ssl_cert_set0_chain(s, ctx, dchain)) {

-        sk_X509_pop_free(dchain, X509_free);
+        OSSL_STACK_OF_X509_free(dchain);

         return 0;
     }
     return 1;
         return 0;
     }
     return 1;


@@ -440,7 +440,7 @@ int ssl_verify_cert_chain(SSL *s, STACK_OF(X509) *sk)
     }
 
     s->verify_result = X509_STORE_CTX_get_error(ctx);
     }
 
     s->verify_result = X509_STORE_CTX_get_error(ctx);

-    sk_X509_pop_free(s->verified_chain, X509_free);
+    OSSL_STACK_OF_X509_free(s->verified_chain);

     s->verified_chain = NULL;
     if (X509_STORE_CTX_get0_chain(ctx) != NULL) {
         s->verified_chain = X509_STORE_CTX_get1_chain(ctx);
     s->verified_chain = NULL;
     if (X509_STORE_CTX_get0_chain(ctx) != NULL) {
         s->verified_chain = X509_STORE_CTX_get1_chain(ctx);


@@ -940,12 +940,12 @@ int ssl_build_cert_chain(SSL *s, SSL_CTX *ctx, int flags)
         rv = ssl_security_cert(s, ctx, x, 0, 0);
         if (rv != 1) {
             ERR_raise(ERR_LIB_SSL, rv);
         rv = ssl_security_cert(s, ctx, x, 0, 0);
         if (rv != 1) {
             ERR_raise(ERR_LIB_SSL, rv);

-            sk_X509_pop_free(chain, X509_free);
+            OSSL_STACK_OF_X509_free(chain);

             rv = 0;
             goto err;
         }
     }
             rv = 0;
             goto err;
         }
     }

-    sk_X509_pop_free(cpk->chain, X509_free);
+    OSSL_STACK_OF_X509_free(cpk->chain);

     cpk->chain = chain;
     if (rv == 0)
         rv = 1;
     cpk->chain = chain;
     if (rv == 0)
         rv = 1;

diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c
index dc5f7d2173edbcfae6716a197d945ef186352df8..20fe8bc786fc36a17cd2877d419bf83c76b5bf25 100644 (file)
--- a/ssl/ssl_lib.c
+++ b/ssl/ssl_lib.c
@@ -172,7 +172,7 @@ static void dane_final(SSL_DANE *dane)
     sk_danetls_record_pop_free(dane->trecs, tlsa_free);
     dane->trecs = NULL;
 
     sk_danetls_record_pop_free(dane->trecs, tlsa_free);
     dane->trecs = NULL;
 

-    sk_X509_pop_free(dane->certs, X509_free);
+    OSSL_STACK_OF_X509_free(dane->certs);

     dane->certs = NULL;
 
     X509_free(dane->mcert);
     dane->certs = NULL;
 
     X509_free(dane->mcert);


@@ -1243,7 +1243,7 @@ void SSL_free(SSL *s)
     sk_X509_NAME_pop_free(s->ca_names, X509_NAME_free);
     sk_X509_NAME_pop_free(s->client_ca_names, X509_NAME_free);
 
     sk_X509_NAME_pop_free(s->ca_names, X509_NAME_free);
     sk_X509_NAME_pop_free(s->client_ca_names, X509_NAME_free);
 

-    sk_X509_pop_free(s->verified_chain, X509_free);
+    OSSL_STACK_OF_X509_free(s->verified_chain);

 
     if (s->method != NULL)
         s->method->ssl_free(s);
 
     if (s->method != NULL)
         s->method->ssl_free(s);


@@ -3430,7 +3430,7 @@ void SSL_CTX_free(SSL_CTX *a)
     ssl_cert_free(a->cert);
     sk_X509_NAME_pop_free(a->ca_names, X509_NAME_free);
     sk_X509_NAME_pop_free(a->client_ca_names, X509_NAME_free);
     ssl_cert_free(a->cert);
     sk_X509_NAME_pop_free(a->ca_names, X509_NAME_free);
     sk_X509_NAME_pop_free(a->client_ca_names, X509_NAME_free);

-    sk_X509_pop_free(a->extra_certs, X509_free);
+    OSSL_STACK_OF_X509_free(a->extra_certs);

     a->comp_methods = NULL;
 #ifndef OPENSSL_NO_SRTP
     sk_SRTP_PROTECTION_PROFILE_free(a->srtp_profiles);
     a->comp_methods = NULL;
 #ifndef OPENSSL_NO_SRTP
     sk_SRTP_PROTECTION_PROFILE_free(a->srtp_profiles);

diff --git a/ssl/ssl_rsa.c b/ssl/ssl_rsa.c
index 5509389aa2ea22b70b2bb54a615d1758194c5ce0..bba005143784eb1b6a6077dc19610070fdfe5c4e 100644 (file)
--- a/ssl/ssl_rsa.c
+++ b/ssl/ssl_rsa.c
@@ -955,7 +955,7 @@ static int ssl_set_cert_and_key(SSL *ssl, SSL_CTX *ctx, X509 *x509, EVP_PKEY *pr
         }
     }
 
         }
     }
 

-    sk_X509_pop_free(c->pkeys[i].chain, X509_free);
+    OSSL_STACK_OF_X509_free(c->pkeys[i].chain);

     c->pkeys[i].chain = dup_chain;
 
     X509_free(c->pkeys[i].x509);
     c->pkeys[i].chain = dup_chain;
 
     X509_free(c->pkeys[i].x509);

diff --git a/ssl/ssl_sess.c b/ssl/ssl_sess.c
index 0e756c37c1ace14c8e25ce6d503f49a06a1f8ac0..765ae89916447f62288b179e2417ad78d9450aaf 100644 (file)
--- a/ssl/ssl_sess.c
+++ b/ssl/ssl_sess.c
@@ -828,7 +828,7 @@ void SSL_SESSION_free(SSL_SESSION *ss)
     OPENSSL_cleanse(ss->master_key, sizeof(ss->master_key));
     OPENSSL_cleanse(ss->session_id, sizeof(ss->session_id));
     X509_free(ss->peer);
     OPENSSL_cleanse(ss->master_key, sizeof(ss->master_key));
     OPENSSL_cleanse(ss->session_id, sizeof(ss->session_id));
     X509_free(ss->peer);

-    sk_X509_pop_free(ss->peer_chain, X509_free);
+    OSSL_STACK_OF_X509_free(ss->peer_chain);

     OPENSSL_free(ss->ext.hostname);
     OPENSSL_free(ss->ext.tick);
 #ifndef OPENSSL_NO_PSK
     OPENSSL_free(ss->ext.hostname);
     OPENSSL_free(ss->ext.tick);
 #ifndef OPENSSL_NO_PSK

diff --git a/ssl/statem/statem_clnt.c b/ssl/statem/statem_clnt.c
index 12f77690cd078cddf95f14d7a638c441ada4b097..10e778d681b6abf78d9020fc339d37ab8e4c5bb7 100644 (file)
--- a/ssl/statem/statem_clnt.c
+++ b/ssl/statem/statem_clnt.c
@@ -1841,7 +1841,7 @@ MSG_PROCESS_RETURN tls_process_server_certificate(SSL *s, PACKET *pkt)
 
  err:
     X509_free(x);
 
  err:
     X509_free(x);

-    sk_X509_pop_free(s->session->peer_chain, X509_free);
+    OSSL_STACK_OF_X509_free(s->session->peer_chain);

     s->session->peer_chain = NULL;
     return MSG_PROCESS_ERROR;
 }
     s->session->peer_chain = NULL;
     return MSG_PROCESS_ERROR;
 }

diff --git a/ssl/statem/statem_srvr.c b/ssl/statem/statem_srvr.c
index 271f5b4400e176d27541330c254bc8d5dcef1b0e..cda9b32156c151516a46415cb34fafbe1c2f5398 100644 (file)
--- a/ssl/statem/statem_srvr.c
+++ b/ssl/statem/statem_srvr.c
@@ -3554,7 +3554,7 @@ MSG_PROCESS_RETURN tls_process_client_certificate(SSL *s, PACKET *pkt)
     s->session->peer = sk_X509_shift(sk);
     s->session->verify_result = s->verify_result;
 
     s->session->peer = sk_X509_shift(sk);
     s->session->verify_result = s->verify_result;
 

-    sk_X509_pop_free(s->session->peer_chain, X509_free);
+    OSSL_STACK_OF_X509_free(s->session->peer_chain);

     s->session->peer_chain = sk;
     sk = NULL;
 
     s->session->peer_chain = sk;
     sk = NULL;
 


@@ -3589,7 +3589,7 @@ MSG_PROCESS_RETURN tls_process_client_certificate(SSL *s, PACKET *pkt)
 
  err:
     X509_free(x);
 
  err:
     X509_free(x);

-    sk_X509_pop_free(sk, X509_free);
+    OSSL_STACK_OF_X509_free(sk);

     return ret;
 }
 
     return ret;
 }
 

diff --git a/test/cmp_client_test.c b/test/cmp_client_test.c
index f4f664a49e2b14ad281abb854a502ab7653837fa..70543b3b01c4e287a18a6d5c8a5418cdf67800ec 100644 (file)
--- a/test/cmp_client_test.c
+++ b/test/cmp_client_test.c
@@ -116,7 +116,7 @@ static int execute_exec_certrequest_ses_test(CMP_SES_TEST_FIXTURE *fixture)
         STACK_OF(X509) *caPubs = OSSL_CMP_CTX_get1_caPubs(fixture->cmp_ctx);
         int ret = TEST_int_eq(STACK_OF_X509_cmp(fixture->caPubs, caPubs), 0);
 
         STACK_OF(X509) *caPubs = OSSL_CMP_CTX_get1_caPubs(fixture->cmp_ctx);
         int ret = TEST_int_eq(STACK_OF_X509_cmp(fixture->caPubs, caPubs), 0);
 

-        sk_X509_pop_free(caPubs, X509_free);
+        OSSL_STACK_OF_X509_free(caPubs);

         return ret;
     }
     return 1;
         return ret;
     }
     return 1;

diff --git a/test/cmp_ctx_test.c b/test/cmp_ctx_test.c
index 71fa679ff40579a012e807c4d17d91ab0086d4fa..1e0d6db5387c5f93eadcfdfad3a39511951ba932 100644 (file)
--- a/test/cmp_ctx_test.c
+++ b/test/cmp_ctx_test.c
@@ -59,7 +59,7 @@ static STACK_OF(X509) *sk_X509_new_1(void)
 
 static void sk_X509_pop_X509_free(STACK_OF(X509) *sk)
 {
 
 static void sk_X509_pop_X509_free(STACK_OF(X509) *sk)
 {

-    sk_X509_pop_free(sk, X509_free);
+    OSSL_STACK_OF_X509_free(sk);

 }
 
 static int execute_CTX_reinit_test(OSSL_CMP_CTX_TEST_FIXTURE *fixture)
 }
 
 static int execute_CTX_reinit_test(OSSL_CMP_CTX_TEST_FIXTURE *fixture)

diff --git a/test/cmp_protect_test.c b/test/cmp_protect_test.c
index 9111b89423303a624f1397aa127ade490f4477e5..a24acace2cfc639fb12bbffd0a066b7aa3868da0 100644 (file)
--- a/test/cmp_protect_test.c
+++ b/test/cmp_protect_test.c
@@ -340,7 +340,7 @@ static int execute_cmp_build_cert_chain_test(CMP_PROTECT_TEST_FIXTURE *fixture)
     if (TEST_ptr(chain)) {
         /* Check whether chain built is equal to the expected one */
         ret = TEST_int_eq(0, STACK_OF_X509_cmp(chain, fixture->chain));
     if (TEST_ptr(chain)) {
         /* Check whether chain built is equal to the expected one */
         ret = TEST_int_eq(0, STACK_OF_X509_cmp(chain, fixture->chain));

-        sk_X509_pop_free(chain, X509_free);
+        OSSL_STACK_OF_X509_free(chain);

     }
     if (!ret)
         return 0;
     }
     if (!ret)
         return 0;


@@ -355,7 +355,7 @@ static int execute_cmp_build_cert_chain_test(CMP_PROTECT_TEST_FIXTURE *fixture)
         if (ret && chain != NULL) {
             /* Check whether chain built is equal to the expected one */
             ret = TEST_int_eq(0, STACK_OF_X509_cmp(chain, fixture->chain));
         if (ret && chain != NULL) {
             /* Check whether chain built is equal to the expected one */
             ret = TEST_int_eq(0, STACK_OF_X509_cmp(chain, fixture->chain));

-            sk_X509_pop_free(chain, X509_free);
+            OSSL_STACK_OF_X509_free(chain);

         }
     }
     X509_STORE_free(store);
         }
     }
     X509_STORE_free(store);


@@ -475,7 +475,7 @@ static int execute_X509_STORE_test(CMP_PROTECT_TEST_FIXTURE *fixture)
     res = 1;
  err:
     X509_STORE_free(store);
     res = 1;
  err:
     X509_STORE_free(store);

-    sk_X509_pop_free(sk, X509_free);
+    OSSL_STACK_OF_X509_free(sk);

     return res;
 
 }
     return res;
 
 }

diff --git a/test/crltest.c b/test/crltest.c
index 5d255d368a1ca506454c6cb1b74a14c49f64f662..3b76f4f0ae5e3519e62802868017a14ea4119126 100644 (file)
--- a/test/crltest.c
+++ b/test/crltest.c
@@ -264,7 +264,7 @@ static int verify(X509 *leaf, X509 *root, STACK_OF(X509_CRL) *crls,
     status = X509_verify_cert(ctx) == 1 ? X509_V_OK
                                         : X509_STORE_CTX_get_error(ctx);
 err:
     status = X509_verify_cert(ctx) == 1 ? X509_V_OK
                                         : X509_STORE_CTX_get_error(ctx);
 err:

-    sk_X509_pop_free(roots, X509_free);
+    OSSL_STACK_OF_X509_free(roots);

     sk_X509_CRL_pop_free(crls, X509_CRL_free);
     X509_VERIFY_PARAM_free(param);
     X509_STORE_CTX_free(ctx);
     sk_X509_CRL_pop_free(crls, X509_CRL_free);
     X509_VERIFY_PARAM_free(param);
     X509_STORE_CTX_free(ctx);

diff --git a/test/danetest.c b/test/danetest.c
index 0ed460039d4819c96261bd3893f79ce3691fdf2f..d7ef87b6d2674f4a112dc81599ef9175ffa693bc 100644 (file)
--- a/test/danetest.c
+++ b/test/danetest.c
@@ -143,7 +143,7 @@ err:
     OPENSSL_free(name);
     OPENSSL_free(header);
     OPENSSL_free(data);
     OPENSSL_free(name);
     OPENSSL_free(header);
     OPENSSL_free(data);

-    sk_X509_pop_free(chain, X509_free);
+    OSSL_STACK_OF_X509_free(chain);

     return NULL;
 }
 
     return NULL;
 }
 


@@ -344,7 +344,7 @@ static int test_tlsafile(SSL_CTX *ctx, const char *base_name,
         }
 
         ok = verify_chain(ssl, chain);
         }
 
         ok = verify_chain(ssl, chain);

-        sk_X509_pop_free(chain, X509_free);
+        OSSL_STACK_OF_X509_free(chain);

         err = SSL_get_verify_result(ssl);
         /*
          * Peek under the hood, normally TLSA match data is hidden when
         err = SSL_get_verify_result(ssl);
         /*
          * Peek under the hood, normally TLSA match data is hidden when

diff --git a/test/sslapitest.c b/test/sslapitest.c
index 29c125004aa7787833b91c89fb72b55e729670fa..6e0da6299a597cd382f9cb26fa149e572c910d99 100644 (file)
--- a/test/sslapitest.c
+++ b/test/sslapitest.c
@@ -8038,7 +8038,7 @@ static int cert_cb(SSL *s, void *arg)
     EVP_PKEY_free(pkey);
     X509_free(x509);
     X509_free(rootx);
     EVP_PKEY_free(pkey);
     X509_free(x509);
     X509_free(rootx);

-    sk_X509_pop_free(chain, X509_free);
+    OSSL_STACK_OF_X509_free(chain);

     return ret;
 }
 
     return ret;
 }
 

diff --git a/test/testutil/load.c b/test/testutil/load.c
index d776a7f167cfd5dbe3c41dd5caf8d4fbfc62a34b..982e0a39a9b22fbcbcef7d772de4b8f1e44cb88b 100644 (file)
--- a/test/testutil/load.c
+++ b/test/testutil/load.c
@@ -49,7 +49,7 @@ STACK_OF(X509) *load_certs_pem(const char *file)
     do {
         x = PEM_read_bio_X509(bio, NULL, 0, NULL);
         if (x != NULL && !sk_X509_push(certs, x)) {
     do {
         x = PEM_read_bio_X509(bio, NULL, 0, NULL);
         if (x != NULL && !sk_X509_push(certs, x)) {

-            sk_X509_pop_free(certs, X509_free);
+            OSSL_STACK_OF_X509_free(certs);

             BIO_free(bio);
             return NULL;
         } else if (x == NULL) {
             BIO_free(bio);
             return NULL;
         } else if (x == NULL) {

diff --git a/test/verify_extra_test.c b/test/verify_extra_test.c
index 6ab779671f66060181b00218a7ae3f2c80bd1d7d..d03dc0c71ddf95b7d549febb484764df4491b883 100644 (file)
--- a/test/verify_extra_test.c
+++ b/test/verify_extra_test.c
@@ -94,7 +94,7 @@ static int test_alt_chains_cert_forgery(void)
  err:
     X509_STORE_CTX_free(sctx);
     X509_free(x);
  err:
     X509_STORE_CTX_free(sctx);
     X509_free(x);

-    sk_X509_pop_free(untrusted, X509_free);
+    OSSL_STACK_OF_X509_free(untrusted);

     X509_STORE_free(store);
     return ret;
 }
     X509_STORE_free(store);
     return ret;
 }

diff --git a/util/libcrypto.num b/util/libcrypto.num
index 10b4e57d7969d547a328b9dba31c765b7f5204d2..681cbf31b0d8d88f6feef0ea97ef946bf9e3c2aa 100644 (file)
--- a/util/libcrypto.num
+++ b/util/libcrypto.num
@@ -5425,3 +5425,4 @@ ASN1_item_d2i_ex                        5552      3_0_0   EXIST::FUNCTION:
 ASN1_TIME_print_ex                      5553   3_0_0   EXIST::FUNCTION:
 EVP_PKEY_get0_provider                  5554   3_0_0   EXIST::FUNCTION:
 EVP_PKEY_CTX_get0_provider              5555   3_0_0   EXIST::FUNCTION:
 ASN1_TIME_print_ex                      5553   3_0_0   EXIST::FUNCTION:
 EVP_PKEY_get0_provider                  5554   3_0_0   EXIST::FUNCTION:
 EVP_PKEY_CTX_get0_provider              5555   3_0_0   EXIST::FUNCTION:

+OSSL_STACK_OF_X509_free                 ?      3_1_0   EXIST::FUNCTION: