PR: 2908

Submitted by: Dmitry Belyavsky <beldmit@gmail.com>

Fix DH double free if parameter generation fails.

diff --git a/apps/dhparam.c b/apps/dhparam.c
index 79c0d64c519eeafe0c9153b33fa445485fc09f58..f5d7126af7a5d16bedbcb9dc9713f9212e56c189 100644 (file)
--- a/apps/dhparam.c
+++ b/apps/dhparam.c
@@ -332,7 +332,6 @@ bad:
                        BIO_printf(bio_err,"This is going to take a long time\n");
                        if(!dh || !DH_generate_parameters_ex(dh, num, g, &cb))
                                {
                        BIO_printf(bio_err,"This is going to take a long time\n");
                        if(!dh || !DH_generate_parameters_ex(dh, num, g, &cb))
                                {

-                               if(dh) DH_free(dh);

                                ERR_print_errors(bio_err);
                                goto end;
                                }
                                ERR_print_errors(bio_err);
                                goto end;
                                }