Print out OID of unknown signature or public key

algorithms.

diff --git a/CHANGES b/CHANGES
index a83e26c9f7b2f502b4a47f4f6756b8dbdc306332..24be99630bccbf2afe86f64544972502d32b8d76 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -3,6 +3,10 @@
 
  Changes between 0.9.6 and 0.9.7  [xx XXX 2000]
 
 
  Changes between 0.9.6 and 0.9.7  [xx XXX 2000]
 

+  *) If signature or public key algorithm is unrecognized print out its
+     OID rather that just UNKOWN.
+     [Steve Henson]
+

   *) Avoid coredump with unsupported or invalid public keys by checking if
      X509_get_pubkey() fails in PKCS7_verify(). Fix memory leak when
      PKCS7_verify() fails with non detached data.
   *) Avoid coredump with unsupported or invalid public keys by checking if
      X509_get_pubkey() fails in PKCS7_verify(). Fix memory leak when
      PKCS7_verify() fails with non detached data.

diff --git a/crypto/asn1/t_x509.c b/crypto/asn1/t_x509.c
index f142f65900670998679aaf22e4912be491a1c7ff..22b547d7925c788ad5c115e0cbe4861096561e24 100644 (file)
--- a/crypto/asn1/t_x509.c
+++ b/crypto/asn1/t_x509.c
@@ -165,9 +165,11 @@ int X509_print_ex(BIO *bp, X509 *x, unsigned long nmflags, unsigned long cflag)
 
        if(!(cflag & X509_FLAG_NO_SIGNAME))
                {
 
        if(!(cflag & X509_FLAG_NO_SIGNAME))
                {

-               i=OBJ_obj2nid(ci->signature->algorithm);
-               if (BIO_printf(bp,"%8sSignature Algorithm: %s\n","",
-                       (i == NID_undef)?"UNKNOWN":OBJ_nid2ln(i)) <= 0)
+               if (BIO_printf(bp,"%8sSignature Algorithm: ","") <= 0) 
+                       goto err;
+               if (i2a_ASN1_OBJECT(bp, ci->signature->algorithm) <= 0)
+                       goto err;
+               if (BIO_puts(bp, "\n") <= 0)

                        goto err;
                }
 
                        goto err;
                }
 


@@ -194,9 +196,12 @@ int X509_print_ex(BIO *bp, X509 *x, unsigned long nmflags, unsigned long cflag)
                {
                if (BIO_write(bp,"\n        Subject Public Key Info:\n",34) <= 0)
                        goto err;
                {
                if (BIO_write(bp,"\n        Subject Public Key Info:\n",34) <= 0)
                        goto err;

-               i=OBJ_obj2nid(ci->key->algor->algorithm);
-               if (BIO_printf(bp,"%12sPublic Key Algorithm: %s\n","",
-                       (i == NID_undef)?"UNKNOWN":OBJ_nid2ln(i)) <= 0) goto err;
+               if (BIO_printf(bp,"%12sPublic Key Algorithm: ","") <= 0)
+                       goto err;
+               if (i2a_ASN1_OBJECT(bp, ci->key->algor->algorithm) <= 0)
+                       goto err;
+               if (BIO_puts(bp, "\n") <= 0)
+                       goto err;

 
                pkey=X509_get_pubkey(x);
                if (pkey == NULL)
 
                pkey=X509_get_pubkey(x);
                if (pkey == NULL)