Quiet false warning about uninitialised variable
authorHugo Landau <hlandau@openssl.org>
Mon, 22 Jan 2024 14:17:24 +0000 (14:17 +0000)
committerHugo Landau <hlandau@openssl.org>
Thu, 8 Feb 2024 16:50:00 +0000 (16:50 +0000)
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/23360)

ssl/quic/quic_impl.c
test/quic_multistream_test.c

index f760f5f84d119fcaf2f5ec0b810098287be6ad1f..84214bd5f7e33e3c0d8cb33e5aa0ce8a91f2b167 100644 (file)
@@ -3207,7 +3207,7 @@ static int qc_getset_idle_timeout(QCTX *ctx, uint32_t class_,
                                   uint64_t *p_value_out, uint64_t *p_value_in)
 {
     int ret = 0;
-    uint64_t value_out, value_in;
+    uint64_t value_out = 0, value_in;
 
     quic_lock(ctx->qc);
 
index aeb4ca4d7e0def79ca7cf44b5c78cf46fb2b897e..b7fa98dbd60d7534276a980708058105b9b4c5be 100644 (file)
@@ -5241,7 +5241,7 @@ static int modify_idle_timeout(struct helper *h, struct helper_local *hl)
     /* Test bad value is rejected. */
     if (!TEST_false(SSL_set_feature_request_uint(h->c_conn,
                                                  SSL_VALUE_QUIC_IDLE_TIMEOUT,
-                                                 (1UL << 62))))
+                                                 (1ULL << 62))))
         return 0;
 
     /* Set value. */