Avoid calling memcpy with lenght of 0

We can call memcpy() with a pointer 1 past the last allocated byte and length
of 0 and you can argue that that's undefined behaviour.

Reported by tis-interpreter

Reviewed-by: Rich Salz <rsalz@openssl.org>
GH: #1132

diff --git a/crypto/asn1/a_bitstr.c b/crypto/asn1/a_bitstr.c
index 2f0d8f8c2d58c4da0edb165c3a29f6fdd2ebeabe..33be907f9d5edd33c2d086404d815fcb4b7b9f3b 100644 (file)
--- a/crypto/asn1/a_bitstr.c
+++ b/crypto/asn1/a_bitstr.c
@@ -66,10 +66,11 @@ int i2c_ASN1_BIT_STRING(ASN1_BIT_STRING *a, unsigned char **pp)
 
     *(p++) = (unsigned char)bits;
     d = a->data;
 
     *(p++) = (unsigned char)bits;
     d = a->data;

-    memcpy(p, d, len);
-    p += len;
-    if (len > 0)
+    if (len > 0) {
+        memcpy(p, d, len);
+        p += len;

         p[-1] &= (0xff << bits);
         p[-1] &= (0xff << bits);

+    }

     *pp = p;
     return (ret);
 }
     *pp = p;
     return (ret);
 }