Coverity 1545176: dereference before NULL check
authorPauli <pauli@openssl.org>
Thu, 28 Sep 2023 01:34:48 +0000 (11:34 +1000)
committerPauli <pauli@openssl.org>
Mon, 2 Oct 2023 08:18:21 +0000 (19:18 +1100)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from https://github.com/openssl/openssl/pull/22211)

crypto/rand/rand_lib.c

index 46e294a37835e0cd4fb13ef8aed4b74cd7a1e9fa..7fbbb0275b0bc85d8320cc3db617f220c9838edd 100644 (file)
@@ -536,13 +536,14 @@ static EVP_RAND_CTX *rand_new_seed(OSSL_LIB_CTX *libctx)
     EVP_RAND *rand;
     RAND_GLOBAL *dgbl = rand_get_global(libctx);
     EVP_RAND_CTX *ctx = NULL;
-    const char *propq = dgbl->seed_propq;
+    const char *propq;
     char *name, *props = NULL;
     size_t props_len;
     OSSL_PROPERTY_LIST *pl1, *pl2, *pl3 = NULL;
 
     if (dgbl == NULL)
         return NULL;
+    propq = dgbl->seed_propq;
     if (dgbl->seed_name != NULL) {
         name = dgbl->seed_name;
     } else {