MCSV is now called SCSV.
Don't send SCSV if renegotiating.
Also note if RI is empty in debug messages.
#endif
/* Magic Cipher Suite Value. NB: bogus value used for testing */
#endif
/* Magic Cipher Suite Value. NB: bogus value used for testing */
-#ifndef SSL3_CK_MCSV
-#define SSL3_CK_MCSV 0x03000FEC
+#ifndef SSL3_CK_SCSV
+#define SSL3_CK_SCSV 0x03000FEC
#endif
#define SSL3_CK_RSA_NULL_MD5 0x03000001
#endif
#define SSL3_CK_RSA_NULL_MD5 0x03000001
p+=j;
}
/* If p == q, no ciphers and caller indicates an error, otherwise
p+=j;
}
/* If p == q, no ciphers and caller indicates an error, otherwise
+ * add SCSV if not renegotiating
+ if (p != q && !s->new_session)
{
static SSL_CIPHER msvc =
{
{
static SSL_CIPHER msvc =
{
- 0, NULL, SSL3_CK_MCSV, 0, 0, 0, 0, 0, 0, 0, 0, 0
+ 0, NULL, SSL3_CK_SCSV, 0, 0, 0, 0, 0, 0, 0, 0, 0
};
j = put_cb ? put_cb(&msvc,p) : ssl_put_cipher_by_char(s,&msvc,p);
p+=j;
#ifdef OPENSSL_RI_DEBUG
};
j = put_cb ? put_cb(&msvc,p) : ssl_put_cipher_by_char(s,&msvc,p);
p+=j;
#ifdef OPENSSL_RI_DEBUG
- fprintf(stderr, "MCSV sent by client\n");
+ fprintf(stderr, "SCSV sent by client\n");
if (s->s3 && (n != 3 || !p[0]) &&
if (s->s3 && (n != 3 || !p[0]) &&
- (p[n-2] == ((SSL3_CK_MCSV >> 8) & 0xff)) &&
- (p[n-1] == (SSL3_CK_MCSV & 0xff)))
+ (p[n-2] == ((SSL3_CK_SCSV >> 8) & 0xff)) &&
+ (p[n-1] == (SSL3_CK_SCSV & 0xff)))
{
s->s3->send_connection_binding = 1;
p += n;
#ifdef OPENSSL_RI_DEBUG
{
s->s3->send_connection_binding = 1;
p += n;
#ifdef OPENSSL_RI_DEBUG
- fprintf(stderr, "MCSV received by server\n");
+ fprintf(stderr, "SCSV received by server\n");
memcpy(p, s->s3->previous_client_finished,
s->s3->previous_client_finished_len);
#ifdef OPENSSL_RI_DEBUG
memcpy(p, s->s3->previous_client_finished,
s->s3->previous_client_finished_len);
#ifdef OPENSSL_RI_DEBUG
- fprintf(stderr, "RI extension sent by client\n");
+ fprintf(stderr, "%s RI extension sent by client\n",
+ s->s3->previous_client_finished_len ? "Non-empty" : "Empty");
return 0;
}
#ifdef OPENSSL_RI_DEBUG
return 0;
}
#ifdef OPENSSL_RI_DEBUG
- fprintf(stderr, "RI extension received by server\n");
+ fprintf(stderr, "%s RI extension received by server\n",
+ ilen ? "Non-empty" : "Empty");
#endif
s->s3->send_connection_binding=1;
#endif
s->s3->send_connection_binding=1;
memcpy(p, s->s3->previous_server_finished,
s->s3->previous_server_finished_len);
#ifdef OPENSSL_RI_DEBUG
memcpy(p, s->s3->previous_server_finished,
s->s3->previous_server_finished_len);
#ifdef OPENSSL_RI_DEBUG
- fprintf(stderr, "RI extension sent by server\n");
+ fprintf(stderr, "%s RI extension sent by server\n",
+ s->s3->previous_client_finished_len ? "Non-empty" : "Empty");
return 0;
}
#ifdef OPENSSL_RI_DEBUG
return 0;
}
#ifdef OPENSSL_RI_DEBUG
- fprintf(stderr, "RI extension received by client\n");
+ fprintf(stderr, "%s RI extension received by client\n",
+ ilen ? "Non-empty" : "Empty");
#endif
s->s3->send_connection_binding=1;
#endif
s->s3->send_connection_binding=1;