when building with OPENSSL_NO_DEPRECATED defined BN_zero is a macro

which cannot be evaluated in an if statement

diff --git a/crypto/dsa/dsa_gen.c b/crypto/dsa/dsa_gen.c
index 74da6becd558a54a5317cc37e7d55da78e19a1b2..6a6be3b57537d864aae8d49692f9abb63ee9e427 100644 (file)
--- a/crypto/dsa/dsa_gen.c
+++ b/crypto/dsa/dsa_gen.c
@@ -210,7 +210,7 @@ static int dsa_builtin_paramgen(DSA *ret, int bits,
                                goto err;
 
                        /* step 7 */
-                       if (!BN_zero(W)) goto err;
+                       BN_zero(W);
                        /* now 'buf' contains "SEED + offset - 1" */
                        for (k=0; k<=n; k++)
                                {