Configurations/10-main.conf: remove MIPS bn_div_3_words.
authorAndy Polyakov <appro@openssl.org>
Mon, 12 Nov 2018 14:03:39 +0000 (15:03 +0100)
committerMatt Caswell <matt@openssl.org>
Wed, 5 Dec 2018 10:33:28 +0000 (10:33 +0000)
It's being replaced with constant-time alternative.

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/7589)

Configurations/10-main.conf
crypto/bn/asm/mips.pl

index d86691c596d08fad0380c168e43dcb5261fb8853..6506203077cc1e468ce532536f6eff35d2bac4ca 100644 (file)
@@ -360,7 +360,7 @@ my %targets = (
         inherit_from     => [ "BASE_unix" ],
         template         => 1,
         cppflags         => threads("-D_SGI_MP_SOURCE"),
-        lib_cppflags     => "-DB_ENDIAN -DBN_DIV3W",
+        lib_cppflags     => "-DB_ENDIAN",
         ex_libs          => add(threads("-lpthread")),
         thread_scheme    => "pthreads",
         dso_scheme       => "dlfcn",
@@ -733,7 +733,6 @@ my %targets = (
         inherit_from     => [ "linux-generic32", asm("mips32_asm") ],
         cflags           => add("-mabi=32"),
         cxxflags         => add("-mabi=32"),
-        lib_cppflags     => add("-DBN_DIV3W"),
         perlasm_scheme   => "o32",
     },
     # mips32 and mips64 below refer to contemporary MIPS Architecture
@@ -742,7 +741,6 @@ my %targets = (
         inherit_from     => [ "linux-generic32", asm("mips64_asm") ],
         cflags           => add("-mabi=n32"),
         cxxflags         => add("-mabi=n32"),
-        lib_cppflags     => add("-DBN_DIV3W"),
         bn_ops           => "SIXTY_FOUR_BIT RC4_CHAR",
         perlasm_scheme   => "n32",
         multilib         => "32",
@@ -751,7 +749,6 @@ my %targets = (
         inherit_from     => [ "linux-generic64", asm("mips64_asm") ],
         cflags           => add("-mabi=64"),
         cxxflags         => add("-mabi=64"),
-        lib_cppflags     => add("-DBN_DIV3W"),
         perlasm_scheme   => "64",
         multilib         => "64",
     },
index da35ec1b30cea5496b758ba0da317a8c6c1ccc3a..3875132bd25d484947dc83a2c3f80b147e07a306 100644 (file)
@@ -798,6 +798,11 @@ $code.=<<___;
        move    $a0,$v0
 .end   bn_sub_words_internal
 
+#if 0
+/*
+ * The bn_div_3_words entry point is re-used for constant-time interface.
+ * Implementation is retained as hystorical reference.
+ */
 .align 5
 .globl bn_div_3_words
 .ent   bn_div_3_words
@@ -877,6 +882,7 @@ $code.=<<___;
        jr      $ra
        move    $a0,$v0
 .end   bn_div_3_words_internal
+#endif
 
 .align 5
 .globl bn_div_words