generate_cookie_callback: free temporary memory on an error path
authorPauli <paul.dale@oracle.com>
Sun, 13 Sep 2020 21:47:26 +0000 (07:47 +1000)
committerPauli <paul.dale@oracle.com>
Tue, 15 Sep 2020 21:22:43 +0000 (07:22 +1000)
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
(Merged from https://github.com/openssl/openssl/pull/12870)

apps/lib/s_cb.c

index ec52cef15809d315c4e94364e23d11ccf32b573d..72fb98402d434944be4fa759101962447a60c6f6 100644 (file)
@@ -786,6 +786,7 @@ int generate_cookie_callback(SSL *ssl, unsigned char *cookie,
     /* Create buffer with peer's address and port */
     if (!BIO_ADDR_rawaddress(peer, NULL, &length)) {
         BIO_printf(bio_err, "Failed getting peer address\n");
+        BIO_ADDR_free(lpeer);
         return 0;
     }
     OPENSSL_assert(length != 0);