Minor fixes

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22674)

diff --git a/include/internal/quic_port.h b/include/internal/quic_port.h
index 81811b0110761894c97c3d7da4929e0f595a6193..bcb578c3f8d21efbd5f03e1b60f9650fa41ff946 100644 (file)
--- a/include/internal/quic_port.h
+++ b/include/internal/quic_port.h
@@ -70,8 +70,9 @@ void ossl_quic_port_free(QUIC_PORT *port);
 QUIC_CHANNEL *ossl_quic_port_create_outgoing(QUIC_PORT *port, SSL *tls);
 
 /*
- * Create an incoming channel using this port. XXX for temporary TSERVER use
- * only - will be removed.
+ * Create an incoming channel using this port.
+ *
+ * TODO(QUIC SERVER): temporary TSERVER use only - will be removed.
  */
 QUIC_CHANNEL *ossl_quic_port_create_incoming(QUIC_PORT *port, SSL *tls);
 

diff --git a/ssl/quic/quic_port.c b/ssl/quic/quic_port.c
index b4e2deeb84db6851f79f4daf059ddb4ffd739525..9976862138c09288eb920a53dad70676a6b94286 100644 (file)
--- a/ssl/quic/quic_port.c
+++ b/ssl/quic/quic_port.c
@@ -90,10 +90,9 @@ static int port_init(QUIC_PORT *port)
     port->rx_short_dcid_len = (unsigned char)rx_short_dcid_len;
     port->tx_init_dcid_len  = INIT_DCID_LEN;
     port->state             = QUIC_PORT_STATE_RUNNING;
-    if (port->engine != NULL) {
-        ossl_list_port_insert_tail(&port->engine->port_list, port);
-        port->on_engine_list    = 1;
-    }
+
+    ossl_list_port_insert_tail(&port->engine->port_list, port);
+    port->on_engine_list    = 1;
     return 1;
 
 err: