Address Coverity 1493387 Logically dead code
authorPauli <pauli@openssl.org>
Thu, 4 Nov 2021 02:46:58 +0000 (12:46 +1000)
committerPauli <pauli@openssl.org>
Sun, 7 Nov 2021 22:55:32 +0000 (08:55 +1000)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/16962)

crypto/evp/m_sigver.c

index 2972734d8d91755ae8338acd3b0d1772f9a669d8..80570973dd17fefe0e4b21518ba5a1b563142a40 100644 (file)
@@ -462,14 +462,14 @@ int EVP_DigestSignFinal(EVP_MD_CTX *ctx, unsigned char *sigret,
     if (sigret == NULL || (ctx->flags & EVP_MD_CTX_FLAG_FINALISE) != 0)
         return pctx->op.sig.signature->digest_sign_final(pctx->op.sig.algctx,
                                                          sigret, siglen,
-                                                         (sigret == NULL) ? 0 : *siglen);
+                                                         (siglen == NULL) ? 0 : *siglen);
     dctx = EVP_PKEY_CTX_dup(pctx);
     if (dctx == NULL)
         return 0;
 
     r = dctx->op.sig.signature->digest_sign_final(dctx->op.sig.algctx,
                                                   sigret, siglen,
-                                                  (sigret == NULL) ? 0 : *siglen);
+                                                  (siglen == NULL) ? 0 : *siglen);
     EVP_PKEY_CTX_free(dctx);
     return r;