Rewrite the extension code to use an ASN1_ITEM structure
[openssl.git] / crypto / x509v3 / v3_conf.c
index f81cd277d8ad070817b54f2d9e1719979c01dece..909bc0a10a5eca66d02d8da98202c8da47bf2701 100644 (file)
 #include <stdio.h>
 #include <ctype.h>
 #include "cryptlib.h"
-#include "conf.h"
-#include "x509.h"
-#include "x509v3.h"
+#include <openssl/conf.h>
+#include <openssl/x509.h>
+#include <openssl/x509v3.h>
 
-#ifndef NOPROTO
 static int v3_check_critical(char **value);
 static int v3_check_generic(char **value);
 static X509_EXTENSION *do_ext_conf(LHASH *conf, X509V3_CTX *ctx, int ext_nid, int crit, char *value);
-static X509_EXTENSION *v3_generic_extension(char *ext, char *value, int crit, int type);
-#else
-static int v3_check_critical();
-static int v3_check_generic();
-static X509_EXTENSION *do_ext_conf();
-static X509V3_EXTENSION *v3_generic_extension();
-#endif
-
-X509_EXTENSION *X509V3_EXT_conf(conf, ctx, name, value)
-LHASH *conf;   /* Config file */
-X509V3_CTX *ctx;
-char *name;    /* Name */
-char *value;   /* Value */
+static X509_EXTENSION *v3_generic_extension(const char *ext, char *value, int crit, int type);
+static char *conf_lhash_get_string(void *db, char *section, char *value);
+static STACK_OF(CONF_VALUE) *conf_lhash_get_section(void *db, char *section);
+static X509_EXTENSION *do_ext_i2d(X509V3_EXT_METHOD *method, int ext_nid,
+                                                int crit, void *ext_struc);
+/* LHASH *conf:  Config file    */
+/* char *name:  Name    */
+/* char *value:  Value    */
+X509_EXTENSION *X509V3_EXT_conf(LHASH *conf, X509V3_CTX *ctx, char *name,
+            char *value)
 {
        int crit;
        int ext_type;
@@ -98,11 +94,10 @@ char *value;        /* Value */
        return ret;
 }
 
-X509_EXTENSION *X509V3_EXT_conf_nid(conf, ctx, ext_nid, value)
-LHASH *conf;   /* Config file */
-X509V3_CTX *ctx;
-int ext_nid;
-char *value;   /* Value */
+/* LHASH *conf:  Config file    */
+/* char *value:  Value    */
+X509_EXTENSION *X509V3_EXT_conf_nid(LHASH *conf, X509V3_CTX *ctx, int ext_nid,
+            char *value)
 {
        int crit;
        int ext_type;
@@ -113,20 +108,15 @@ char *value;      /* Value */
        return do_ext_conf(conf, ctx, ext_nid, crit, value);
 }
 
-static X509_EXTENSION *do_ext_conf(conf, ctx, ext_nid, crit, value)
-LHASH *conf;   /* Config file */
-X509V3_CTX *ctx;
-int ext_nid;
-int crit;
-char *value;   /* Value */
+/* LHASH *conf:  Config file    */
+/* char *value:  Value    */
+static X509_EXTENSION *do_ext_conf(LHASH *conf, X509V3_CTX *ctx, int ext_nid,
+            int crit, char *value)
 {
-       X509_EXTENSION *ext = NULL;
        X509V3_EXT_METHOD *method;
-       STACK *nval;
-       char *ext_struc;
-       char *ext_der, *p;
-       int ext_len;
-       ASN1_OCTET_STRING *ext_oct;
+       X509_EXTENSION *ext;
+       STACK_OF(CONF_VALUE) *nval;
+       void *ext_struc;
        if(ext_nid == NID_undef) {
                X509V3err(X509V3_F_DO_EXT_CONF,X509V3_R_UNKNOWN_EXTENSION_NAME);
                return NULL;
@@ -145,63 +135,101 @@ char *value;     /* Value */
                        return NULL;
                }
                ext_struc = method->v2i(method, ctx, nval);
-               if(*value != '@') sk_pop_free(nval, X509V3_conf_free);
+               if(*value != '@') sk_CONF_VALUE_pop_free(nval,
+                                                        X509V3_conf_free);
                if(!ext_struc) return NULL;
        } else if(method->s2i) {
                if(!(ext_struc = method->s2i(method, ctx, value))) return NULL;
+       } else if(method->r2i) {
+               if(!ctx->db) {
+                       X509V3err(X509V3_F_X509V3_EXT_CONF,X509V3_R_NO_CONFIG_DATABASE);
+                       return NULL;
+               }
+               if(!(ext_struc = method->r2i(method, ctx, value))) return NULL;
        } else {
                X509V3err(X509V3_F_X509V3_EXT_CONF,X509V3_R_EXTENSION_SETTING_NOT_SUPPORTED);
                ERR_add_error_data(2, "name=", OBJ_nid2sn(ext_nid));
                return NULL;
        }
 
-       /* We've now got the internal representation: convert to DER */
-       ext_len = method->i2d(ext_struc, NULL);
-       ext_der = Malloc(ext_len);
-       p = ext_der;
-       method->i2d(ext_struc, &p);
-       method->ext_free(ext_struc);
-       ext_oct = ASN1_OCTET_STRING_new();
+       ext  = do_ext_i2d(method, ext_nid, crit, ext_struc);
+       if(method->it) ASN1_item_free(ext_struc, method->it);
+       else method->ext_free(ext_struc);
+       return ext;
+
+}
+
+static X509_EXTENSION *do_ext_i2d(X509V3_EXT_METHOD *method, int ext_nid,
+                                                int crit, void *ext_struc)
+{
+       unsigned char *ext_der;
+       int ext_len;
+       ASN1_OCTET_STRING *ext_oct;
+       X509_EXTENSION *ext;
+       /* Convert internal representation to DER */
+       if(method->it) {
+               ext_len = ASN1_item_i2d(ext_struc, &ext_der, method->it);
+               if(ext_len < 0) goto merr;
+       } else {
+               unsigned char *p;
+               ext_len = method->i2d(ext_struc, NULL);
+               if(!(ext_der = OPENSSL_malloc(ext_len))) goto merr;
+               p = ext_der;
+               method->i2d(ext_struc, &p);
+       }
+       if(!(ext_oct = M_ASN1_OCTET_STRING_new())) goto merr;
        ext_oct->data = ext_der;
        ext_oct->length = ext_len;
-       
+
        ext = X509_EXTENSION_create_by_NID(NULL, ext_nid, crit, ext_oct);
-       ASN1_OCTET_STRING_free(ext_oct);
+       if(!ext) goto merr;
+       M_ASN1_OCTET_STRING_free(ext_oct);
 
        return ext;
 
+       merr:
+       X509V3err(X509V3_F_DO_EXT_I2D,ERR_R_MALLOC_FAILURE);
+       return NULL;
+
+}
+
+/* Given an internal structure, nid and critical flag create an extension */
+
+X509_EXTENSION *X509V3_EXT_i2d(int ext_nid, int crit, void *ext_struc)
+{
+       X509V3_EXT_METHOD *method;
+       if(!(method = X509V3_EXT_get_nid(ext_nid))) {
+               X509V3err(X509V3_F_X509V3_EXT_I2D,X509V3_R_UNKNOWN_EXTENSION);
+               return NULL;
+       }
+       return do_ext_i2d(method, ext_nid, crit, ext_struc);
 }
 
 /* Check the extension string for critical flag */
-static int v3_check_critical(value)
-char **value;
+static int v3_check_critical(char **value)
 {
        char *p = *value;
        if((strlen(p) < 9) || strncmp(p, "critical,", 9)) return 0;
        p+=9;
-       while(isspace(*p)) p++;
+       while(isspace((unsigned char)*p)) p++;
        *value = p;
        return 1;
 }
 
 /* Check extension string for generic extension and return the type */
-static int v3_check_generic(value)
-char **value;
+static int v3_check_generic(char **value)
 {
        char *p = *value;
-       if((strlen(p) < 4) || strncmp(p, "RAW:,", 4)) return 0;
+       if((strlen(p) < 4) || strncmp(p, "DER:,", 4)) return 0;
        p+=4;
-       while(isspace(*p)) p++;
+       while(isspace((unsigned char)*p)) p++;
        *value = p;
        return 1;
 }
 
-/* Create a generic extension: for now just handle RAW type */
-static X509_EXTENSION *v3_generic_extension(ext, value, crit, type)
-char *ext;
-char *value;
-int crit;
-int type;
+/* Create a generic extension: for now just handle DER type */
+static X509_EXTENSION *v3_generic_extension(const char *ext, char *value,
+            int crit, int type)
 {
 unsigned char *ext_der=NULL;
 long ext_len;
@@ -220,7 +248,7 @@ if(!(ext_der = string_to_hex(value, &ext_len))) {
        goto err;
 }
 
-if(!(oct = ASN1_OCTET_STRING_new())) {
+if(!(oct = M_ASN1_OCTET_STRING_new())) {
        X509V3err(X509V3_F_V3_GENERIC_EXTENSION,ERR_R_MALLOC_FAILURE);
        goto err;
 }
@@ -233,8 +261,8 @@ extension = X509_EXTENSION_create_by_OBJ(NULL, obj, crit, oct);
 
 err:
 ASN1_OBJECT_free(obj);
-ASN1_OCTET_STRING_free(oct);
-if(ext_der) Free(ext_der);
+M_ASN1_OCTET_STRING_free(oct);
+if(ext_der) OPENSSL_free(ext_der);
 return extension;
 }
 
@@ -243,19 +271,16 @@ return extension;
  * section
  */
 
-int X509V3_EXT_add_conf(conf, ctx, section, cert)
-LHASH *conf;
-X509V3_CTX *ctx;
-char *section;
-X509 *cert;
+int X509V3_EXT_add_conf(LHASH *conf, X509V3_CTX *ctx, char *section,
+            X509 *cert)
 {
        X509_EXTENSION *ext;
-       STACK *nval;
+       STACK_OF(CONF_VALUE) *nval;
        CONF_VALUE *val;        
        int i;
        if(!(nval = CONF_get_section(conf, section))) return 0;
-       for(i = 0; i < sk_num(nval); i++) {
-               val = (CONF_VALUE *)sk_value(nval, i);
+       for(i = 0; i < sk_CONF_VALUE_num(nval); i++) {
+               val = sk_CONF_VALUE_value(nval, i);
                if(!(ext = X509V3_EXT_conf(conf, ctx, val->name, val->value)))
                                                                return 0;
                if(cert) X509_add_ext(cert, ext, -1);
@@ -266,19 +291,16 @@ X509 *cert;
 
 /* Same as above but for a CRL */
 
-int X509V3_EXT_CRL_add_conf(conf, ctx, section, crl)
-LHASH *conf;
-X509V3_CTX *ctx;
-char *section;
-X509_CRL *crl;
+int X509V3_EXT_CRL_add_conf(LHASH *conf, X509V3_CTX *ctx, char *section,
+            X509_CRL *crl)
 {
        X509_EXTENSION *ext;
-       STACK *nval;
+       STACK_OF(CONF_VALUE) *nval;
        CONF_VALUE *val;        
        int i;
        if(!(nval = CONF_get_section(conf, section))) return 0;
-       for(i = 0; i < sk_num(nval); i++) {
-               val = (CONF_VALUE *)sk_value(nval, i);
+       for(i = 0; i < sk_CONF_VALUE_num(nval); i++) {
+               val = sk_CONF_VALUE_value(nval, i);
                if(!(ext = X509V3_EXT_conf(conf, ctx, val->name, val->value)))
                                                                return 0;
                if(crl) X509_CRL_add_ext(crl, ext, -1);
@@ -287,63 +309,66 @@ X509_CRL *crl;
        return 1;
 }
 
-/* Just check syntax of config file as far as possible */
-int X509V3_EXT_check_conf(conf, section)
-LHASH *conf;
-char *section;
+/* Add extensions to certificate request */
+
+int X509V3_EXT_REQ_add_conf(LHASH *conf, X509V3_CTX *ctx, char *section,
+            X509_REQ *req)
 {
-       static X509V3_CTX ctx_tst = { CTX_TEST, NULL, NULL, NULL, NULL };
-       return X509V3_EXT_add_conf(conf, &ctx_tst, section, NULL);
+       X509_EXTENSION *ext;
+       STACK_OF(X509_EXTENSION) *extlist = NULL;
+       STACK_OF(CONF_VALUE) *nval;
+       CONF_VALUE *val;        
+       int i;
+       if(!(nval = CONF_get_section(conf, section))) return 0;
+       for(i = 0; i < sk_CONF_VALUE_num(nval); i++) {
+               val = sk_CONF_VALUE_value(nval, i);
+               if(!(ext = X509V3_EXT_conf(conf, ctx, val->name, val->value)))
+                                                               return 0;
+               if(!extlist) extlist = sk_X509_EXTENSION_new_null();
+               sk_X509_EXTENSION_push(extlist, ext);
+       }
+       if(req) i = X509_REQ_add_extensions(req, extlist);
+       else i = 1;
+       sk_X509_EXTENSION_pop_free(extlist, X509_EXTENSION_free);
+       return i;
 }
 
 /* Config database functions */
 
-char * X509V3_get_string(ctx, name, section)
-X509V3_CTX *ctx;
-char *name;
-char *section;
+char * X509V3_get_string(X509V3_CTX *ctx, char *name, char *section)
 {
        if(ctx->db_meth->get_string)
                        return ctx->db_meth->get_string(ctx->db, name, section);
        return NULL;
 }
 
-STACK * X509V3_get_section(ctx, section)
-X509V3_CTX *ctx;
-char *section;
+STACK_OF(CONF_VALUE) * X509V3_get_section(X509V3_CTX *ctx, char *section)
 {
        if(ctx->db_meth->get_section)
                        return ctx->db_meth->get_section(ctx->db, section);
        return NULL;
 }
 
-void X509V3_free_string(ctx, str)
-X509V3_CTX *ctx;
-char *str;
+void X509V3_string_free(X509V3_CTX *ctx, char *str)
 {
+       if(!str) return;
        if(ctx->db_meth->free_string)
-                       return ctx->db_meth->free_string(ctx->db, str);
+                       ctx->db_meth->free_string(ctx->db, str);
 }
 
-void X509V3_free_section(ctx, section)
-X509V3_CTX *ctx;
-STACK *section;
+void X509V3_section_free(X509V3_CTX *ctx, STACK_OF(CONF_VALUE) *section)
 {
+       if(!section) return;
        if(ctx->db_meth->free_section)
-                       return ctx->db_meth->free_section(ctx->db, section);
+                       ctx->db_meth->free_section(ctx->db, section);
 }
 
-static char *conf_lhash_get_string(db, section, value)
-void *db;
-char *section;
-char *value;
+static char *conf_lhash_get_string(void *db, char *section, char *value)
 {
        return CONF_get_string(db, section, value);
 }
 
-static STACK *conf_lhash_get_section(db, section)
-void *db;
-char *section;
+static STACK_OF(CONF_VALUE) *conf_lhash_get_section(void *db, char *section)
 {
        return CONF_get_section(db, section);
 }
@@ -355,21 +380,14 @@ NULL,
 NULL
 };
 
-void X509V3_set_conf_lhash(ctx, lhash)
-X509V3_CTX *ctx;
-LHASH *lhash;
+void X509V3_set_conf_lhash(X509V3_CTX *ctx, LHASH *lhash)
 {
        ctx->db_meth = &conf_lhash_method;
        ctx->db = lhash;
 }
 
-void X509V3_set_ctx(ctx, issuer, subj, req, crl, flags)
-X509V3_CTX *ctx;
-X509 *issuer;
-X509 *subj;
-X509_REQ *req;
-X509_CRL *crl;
-int flags;
+void X509V3_set_ctx(X509V3_CTX *ctx, X509 *issuer, X509 *subj, X509_REQ *req,
+            X509_CRL *crl, int flags)
 {
        ctx->issuer_cert = issuer;
        ctx->subject_cert = subj;