mem_dbg.c: avoid compiler warnings.
[openssl.git] / crypto / mem_dbg.c
index 8316485217ac48847f59ce5ce8a51ba86df2ff97..ad5209b8175fe8cb0a3cdb9cc7788c210398546d 100644 (file)
  * copied and put under another distribution licence
  * [including the GNU Public Licence.]
  */
+/* ====================================================================
+ * Copyright (c) 1998-2006 The OpenSSL Project.  All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer. 
+ *
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in
+ *    the documentation and/or other materials provided with the
+ *    distribution.
+ *
+ * 3. All advertising materials mentioning features or use of this
+ *    software must display the following acknowledgment:
+ *    "This product includes software developed by the OpenSSL Project
+ *    for use in the OpenSSL Toolkit. (http://www.openssl.org/)"
+ *
+ * 4. The names "OpenSSL Toolkit" and "OpenSSL Project" must not be used to
+ *    endorse or promote products derived from this software without
+ *    prior written permission. For written permission, please contact
+ *    openssl-core@openssl.org.
+ *
+ * 5. Products derived from this software may not be called "OpenSSL"
+ *    nor may "OpenSSL" appear in their names without prior written
+ *    permission of the OpenSSL Project.
+ *
+ * 6. Redistributions of any form whatsoever must retain the following
+ *    acknowledgment:
+ *    "This product includes software developed by the OpenSSL Project
+ *    for use in the OpenSSL Toolkit (http://www.openssl.org/)"
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE OpenSSL PROJECT ``AS IS'' AND ANY
+ * EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE OpenSSL PROJECT OR
+ * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+ * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+ * OF THE POSSIBILITY OF SUCH DAMAGE.
+ * ====================================================================
+ *
+ * This product includes cryptographic software written by Eric Young
+ * (eay@cryptsoft.com).  This product includes software written by Tim
+ * Hudson (tjh@cryptsoft.com).
+ *
+ */
 
 #include <stdio.h>
 #include <stdlib.h>
@@ -81,8 +134,11 @@ static int mh_mode=CRYPTO_MEM_CHECK_OFF;
  */
 
 static unsigned long order = 0; /* number of memory requests */
-static LHASH *mh=NULL; /* hash-table of memory requests (address as key);
-                        * access requires MALLOC2 lock */
+
+DECLARE_LHASH_OF(MEM);
+static LHASH_OF(MEM) *mh=NULL; /* hash-table of memory requests
+                               * (address as key); access requires
+                               * MALLOC2 lock */
 
 
 typedef struct app_mem_info_st
@@ -93,8 +149,9 @@ typedef struct app_mem_info_st
  *   CRYPTO_pop_info()           to pop an entry,
  *   CRYPTO_remove_all_info()    to pop all entries.
  */
-       {       
-       unsigned long thread;
+       {
+       unsigned long thread_id;
+       void *thread_idptr;
        const char *file;
        int line;
        const char *info;
@@ -104,10 +161,13 @@ typedef struct app_mem_info_st
 
 static void app_info_free(APP_INFO *);
 
-static LHASH *amih=NULL; /* hash-table with those app_mem_info_st's
-                          * that are at the top of their thread's stack
-                          * (with `thread' as key);
-                          * access requires MALLOC2 lock */
+DECLARE_LHASH_OF(APP_INFO);
+static LHASH_OF(APP_INFO) *amih=NULL; /* hash-table with those
+                                      * app_mem_info_st's that are at
+                                      * the top of their thread's
+                                      * stack (with `thread' as key);
+                                      * access requires MALLOC2
+                                      * lock */
 
 typedef struct mem_st
 /* memory-block description */
@@ -116,7 +176,8 @@ typedef struct mem_st
        int num;
        const char *file;
        int line;
-       unsigned long thread;
+       unsigned long thread_id;
+       void *thread_idptr;
        unsigned long order;
        time_t time;
        APP_INFO *app_info;
@@ -136,11 +197,13 @@ static unsigned int num_disable = 0; /* num_disable > 0
                                       *     iff
                                       * mh_mode == CRYPTO_MEM_CHECK_ON (w/o ..._ENABLE)
                                       */
-static unsigned long disabling_thread = 0; /* Valid iff num_disable > 0.
-                                            * CRYPTO_LOCK_MALLOC2 is locked
-                                            * exactly in this case (by the
-                                            * thread named in disabling_thread).
-                                            */
+
+/* The following two variables, disabling_thread_id and disabling_thread_idptr,
+ * are valid iff num_disable > 0.  CRYPTO_LOCK_MALLOC2 is locked exactly in
+ * this case (by the thread named in disabling_thread_id / disabling_thread_idptr).
+ */
+static unsigned long disabling_thread_id = 0;
+static void *disabling_thread_idptr = NULL;
 
 static void app_info_free(APP_INFO *inf)
        {
@@ -177,7 +240,9 @@ int CRYPTO_mem_ctrl(int mode)
        case CRYPTO_MEM_CHECK_DISABLE: /* aka MemCheck_off() */
                if (mh_mode & CRYPTO_MEM_CHECK_ON)
                        {
-                       if (!num_disable || (disabling_thread != CRYPTO_thread_id())) /* otherwise we already have the MALLOC2 lock */
+                       if (!num_disable
+                           || (disabling_thread_id != CRYPTO_thread_id())
+                           || (disabling_thread_idptr != CRYPTO_thread_idptr())) /* otherwise we already have the MALLOC2 lock */
                                {
                                /* Long-time lock CRYPTO_LOCK_MALLOC2 must not be claimed while
                                 * we're holding CRYPTO_LOCK_MALLOC, or we'll deadlock if
@@ -195,7 +260,8 @@ int CRYPTO_mem_ctrl(int mode)
                                CRYPTO_w_lock(CRYPTO_LOCK_MALLOC2);
                                CRYPTO_w_lock(CRYPTO_LOCK_MALLOC);
                                mh_mode &= ~CRYPTO_MEM_CHECK_ENABLE;
-                               disabling_thread=CRYPTO_thread_id();
+                               disabling_thread_id=CRYPTO_thread_id();
+                               disabling_thread_idptr=CRYPTO_thread_idptr();
                                }
                        num_disable++;
                        }
@@ -231,7 +297,8 @@ int CRYPTO_is_mem_check_on(void)
                CRYPTO_r_lock(CRYPTO_LOCK_MALLOC);
 
                ret = (mh_mode & CRYPTO_MEM_CHECK_ENABLE)
-                       || (disabling_thread != CRYPTO_thread_id());
+                       || (disabling_thread_id != CRYPTO_thread_id())
+                       || (disabling_thread_idptr != CRYPTO_thread_idptr());
 
                CRYPTO_r_unlock(CRYPTO_LOCK_MALLOC);
                }
@@ -249,49 +316,52 @@ long CRYPTO_dbg_get_options(void)
        return options;
        }
 
-/* static int mem_cmp(MEM *a, MEM *b) */
-static int mem_cmp(const void *a_void, const void *b_void)
+static int mem_cmp(const MEM *a, const MEM *b)
        {
 #ifdef _WIN64
-       const char *a=(const char *)((const MEM *)a_void)->addr,
-                  *b=(const char *)((const MEM *)b_void)->addr;
-       if (a==b)       return 0;
-       else if (a>b)   return 1;
+       const char *ap=(const char *)a->addr,
+                  *bp=(const char *)b->addr;
+       if (ap==bp)     return 0;
+       else if (ap>bp) return 1;
        else            return -1;
 #else
-       return((const char *)((const MEM *)a_void)->addr
-               - (const char *)((const MEM *)b_void)->addr);
+       return (const char *)a->addr - (const char *)b->addr;
 #endif
        }
+static IMPLEMENT_LHASH_COMP_FN(mem, MEM)
 
-/* static unsigned long mem_hash(MEM *a) */
-static unsigned long mem_hash(const void *a_void)
+static unsigned long mem_hash(const MEM *a)
        {
        unsigned long ret;
 
-       ret=(unsigned long)((const MEM *)a_void)->addr;
+       ret=(unsigned long)a->addr;
 
        ret=ret*17851+(ret>>14)*7+(ret>>4)*251;
        return(ret);
        }
+static IMPLEMENT_LHASH_HASH_FN(mem, MEM)
 
 /* static int app_info_cmp(APP_INFO *a, APP_INFO *b) */
 static int app_info_cmp(const void *a_void, const void *b_void)
        {
-       return(((const APP_INFO *)a_void)->thread
-               != ((const APP_INFO *)b_void)->thread);
+       return (((const APP_INFO *)a_void)->thread_id != ((const APP_INFO *)b_void)->thread_id)
+              || (((const APP_INFO *)a_void)->thread_idptr != ((const APP_INFO *)b_void)->thread_idptr);
        }
+static IMPLEMENT_LHASH_COMP_FN(app_info, APP_INFO)
 
-/* static unsigned long app_info_hash(APP_INFO *a) */
-static unsigned long app_info_hash(const void *a_void)
+static unsigned long app_info_hash(const APP_INFO *a)
        {
+       unsigned long id1, id2;
        unsigned long ret;
 
-       ret=(unsigned long)((const APP_INFO *)a_void)->thread;
+       id1=(unsigned long)a->thread_id;
+       id2=(unsigned long)a->thread_idptr;
+       ret = id1 + id2;
 
        ret=ret*17851+(ret>>14)*7+(ret>>4)*251;
        return(ret);
        }
+static IMPLEMENT_LHASH_HASH_FN(app_info, APP_INFO)
 
 static APP_INFO *pop_info(void)
        {
@@ -300,21 +370,22 @@ static APP_INFO *pop_info(void)
 
        if (amih != NULL)
                {
-               tmp.thread=CRYPTO_thread_id();
-               if ((ret=(APP_INFO *)lh_delete(amih,&tmp)) != NULL)
+               tmp.thread_id=CRYPTO_thread_id();
+               tmp.thread_idptr=CRYPTO_thread_idptr();
+               if ((ret=lh_APP_INFO_delete(amih,&tmp)) != NULL)
                        {
                        APP_INFO *next=ret->next;
 
                        if (next != NULL)
                                {
                                next->references++;
-                               lh_insert(amih,(char *)next);
+                               (void)lh_APP_INFO_insert(amih,next);
                                }
 #ifdef LEVITTE_DEBUG_MEM
-                       if (ret->thread != tmp.thread)
+                       if (ret->thread_id != tmp.thread_id || ret->thread_idptr != tmp.thread_idptr)
                                {
-                               fprintf(stderr, "pop_info(): deleted info has other thread ID (%lu) than the current thread (%lu)!!!!\n",
-                                       ret->thread, tmp.thread);
+                               fprintf(stderr, "pop_info(): deleted info has other thread ID (%lu/%p) than the current thread (%lu/%p)!!!!\n",
+                                       ret->thread_id, ret->thread_idptr, tmp.thread_id, tmp.thread_idptr);
                                abort();
                                }
 #endif
@@ -346,7 +417,7 @@ int CRYPTO_push_info_(const char *info, const char *file, int line)
                        }
                if (amih == NULL)
                        {
-                       if ((amih=lh_new(app_info_hash, app_info_cmp)) == NULL)
+                       if ((amih=lh_APP_INFO_new()) == NULL)
                                {
                                OPENSSL_free(ami);
                                ret=0;
@@ -354,20 +425,21 @@ int CRYPTO_push_info_(const char *info, const char *file, int line)
                                }
                        }
 
-               ami->thread=CRYPTO_thread_id();
+               ami->thread_id=CRYPTO_thread_id();
+               ami->thread_idptr=CRYPTO_thread_idptr();
                ami->file=file;
                ami->line=line;
                ami->info=info;
                ami->references=1;
                ami->next=NULL;
 
-               if ((amim=(APP_INFO *)lh_insert(amih,(char *)ami)) != NULL)
+               if ((amim=lh_APP_INFO_insert(amih,ami)) != NULL)
                        {
 #ifdef LEVITTE_DEBUG_MEM
-                       if (ami->thread != amim->thread)
+                       if (ami->thread_id != amim->thread_id || ami->thread_idptr != amim->thread_idptr)
                                {
-                               fprintf(stderr, "CRYPTO_push_info(): previous info has other thread ID (%lu) than the current thread (%lu)!!!!\n",
-                                       amim->thread, ami->thread);
+                               fprintf(stderr, "CRYPTO_push_info(): previous info has other thread ID (%lu/%p) than the current thread (%lu/%p)!!!!\n",
+                                       amim->thread_id, amim->thread_idptr, ami->thread_id, ami->thread_idptr);
                                abort();
                                }
 #endif
@@ -439,7 +511,7 @@ void CRYPTO_dbg_malloc(void *addr, int num, const char *file, int line,
                                }
                        if (mh == NULL)
                                {
-                               if ((mh=lh_new(mem_hash, mem_cmp)) == NULL)
+                               if ((mh=lh_MEM_new()) == NULL)
                                        {
                                        OPENSSL_free(addr);
                                        OPENSSL_free(m);
@@ -453,9 +525,15 @@ void CRYPTO_dbg_malloc(void *addr, int num, const char *file, int line,
                        m->line=line;
                        m->num=num;
                        if (options & V_CRYPTO_MDEBUG_THREAD)
-                               m->thread=CRYPTO_thread_id();
+                               {
+                               m->thread_id=CRYPTO_thread_id();
+                               m->thread_idptr=CRYPTO_thread_idptr();
+                               }
                        else
-                               m->thread=0;
+                               {
+                               m->thread_id=0;
+                               m->thread_idptr=NULL;
+                               }
 
                        if (order == break_order_num)
                                {
@@ -464,7 +542,7 @@ void CRYPTO_dbg_malloc(void *addr, int num, const char *file, int line,
                                }
                        m->order=order++;
 #ifdef LEVITTE_DEBUG_MEM
-                       fprintf(stderr, "LEVITTE_DEBUG_MEM: [%5d] %c 0x%p (%d)\n",
+                       fprintf(stderr, "LEVITTE_DEBUG_MEM: [%5ld] %c 0x%p (%d)\n",
                                m->order,
                                (before_p & 128) ? '*' : '+',
                                m->addr, m->num);
@@ -474,16 +552,17 @@ void CRYPTO_dbg_malloc(void *addr, int num, const char *file, int line,
                        else
                                m->time=0;
 
-                       tmp.thread=CRYPTO_thread_id();
+                       tmp.thread_id=CRYPTO_thread_id();
+                       tmp.thread_idptr=CRYPTO_thread_idptr();
                        m->app_info=NULL;
                        if (amih != NULL
-                               && (amim=(APP_INFO *)lh_retrieve(amih,(char *)&tmp)) != NULL)
+                           && (amim=lh_APP_INFO_retrieve(amih,&tmp)) != NULL)
                                {
                                m->app_info = amim;
                                amim->references++;
                                }
 
-                       if ((mm=(MEM *)lh_insert(mh,(char *)m)) != NULL)
+                       if ((mm=lh_MEM_insert(mh, m)) != NULL)
                                {
                                /* Not good, but don't sweat it */
                                if (mm->app_info != NULL)
@@ -516,11 +595,11 @@ void CRYPTO_dbg_free(void *addr, int before_p)
                        MemCheck_off(); /* make sure we hold MALLOC2 lock */
 
                        m.addr=addr;
-                       mp=(MEM *)lh_delete(mh,(char *)&m);
+                       mp=lh_MEM_delete(mh,&m);
                        if (mp != NULL)
                                {
 #ifdef LEVITTE_DEBUG_MEM
-                       fprintf(stderr, "LEVITTE_DEBUG_MEM: [%5d] - 0x%p (%d)\n",
+                       fprintf(stderr, "LEVITTE_DEBUG_MEM: [%5ld] - 0x%p (%d)\n",
                                mp->order, mp->addr, mp->num);
 #endif
                                if (mp->app_info != NULL)
@@ -566,18 +645,18 @@ void CRYPTO_dbg_realloc(void *addr1, void *addr2, int num,
                        MemCheck_off(); /* make sure we hold MALLOC2 lock */
 
                        m.addr=addr1;
-                       mp=(MEM *)lh_delete(mh,(char *)&m);
+                       mp=lh_MEM_delete(mh,&m);
                        if (mp != NULL)
                                {
 #ifdef LEVITTE_DEBUG_MEM
-                               fprintf(stderr, "LEVITTE_DEBUG_MEM: [%5d] * 0x%p (%d) -> 0x%p (%d)\n",
+                               fprintf(stderr, "LEVITTE_DEBUG_MEM: [%5ld] * 0x%p (%d) -> 0x%p (%d)\n",
                                        mp->order,
                                        mp->addr, mp->num,
                                        addr2, num);
 #endif
                                mp->addr=addr2;
                                mp->num=num;
-                               lh_insert(mh,(char *)mp);
+                               (void)lh_MEM_insert(mh,mp);
                                }
 
                        MemCheck_on(); /* release MALLOC2 lock
@@ -596,7 +675,7 @@ typedef struct mem_leak_st
        long bytes;
        } MEM_LEAK;
 
-static void print_leak(const MEM *m, MEM_LEAK *l)
+static void print_leak_doall_arg(const MEM *m, MEM_LEAK *l)
        {
        char buf[1024];
        char *bufp = buf;
@@ -604,6 +683,7 @@ static void print_leak(const MEM *m, MEM_LEAK *l)
        int ami_cnt;
        struct tm *lcl = NULL;
        unsigned long ti;
+       void *tip;
 
 #define BUF_REMAIN (sizeof buf - (size_t)(bufp - buf))
 
@@ -625,7 +705,7 @@ static void print_leak(const MEM *m, MEM_LEAK *l)
 
        if (options & V_CRYPTO_MDEBUG_THREAD)
                {
-               BIO_snprintf(bufp, BUF_REMAIN, "thread=%lu, ", m->thread);
+               BIO_snprintf(bufp, BUF_REMAIN, "thread=%lu/%p, ", m->thread_id, m->thread_idptr);
                bufp += strlen(bufp);
                }
 
@@ -642,7 +722,8 @@ static void print_leak(const MEM *m, MEM_LEAK *l)
        ami_cnt=0;
        if (!amip)
                return;
-       ti=amip->thread;
+       ti=amip->thread_id;
+       tip=amip->thread_idptr;
        
        do
                {
@@ -652,8 +733,8 @@ static void print_leak(const MEM *m, MEM_LEAK *l)
                ami_cnt++;
                memset(buf,'>',ami_cnt);
                BIO_snprintf(buf + ami_cnt, sizeof buf - ami_cnt,
-                       " thread=%lu, file=%s, line=%d, info=\"",
-                       amip->thread, amip->file, amip->line);
+                       " thread=%lu/%p, file=%s, line=%d, info=\"",
+                       amip->thread_id, amip->thread_idptr, amip->file, amip->line);
                buf_len=strlen(buf);
                info_len=strlen(amip->info);
                if (128 - buf_len - 3 < info_len)
@@ -673,8 +754,8 @@ static void print_leak(const MEM *m, MEM_LEAK *l)
 
                amip = amip->next;
                }
-       while(amip && amip->thread == ti);
-               
+       while(amip && amip->thread_id == ti && amip->thread_idptr == tip);
+
 #ifdef LEVITTE_DEBUG_MEM
        if (amip)
                {
@@ -684,7 +765,7 @@ static void print_leak(const MEM *m, MEM_LEAK *l)
 #endif
        }
 
-static IMPLEMENT_LHASH_DOALL_ARG_FN(print_leak, const MEM *, MEM_LEAK *)
+static IMPLEMENT_LHASH_DOALL_ARG_FN(print_leak, const MEM, MEM_LEAK)
 
 void CRYPTO_mem_leaks(BIO *b)
        {
@@ -699,8 +780,8 @@ void CRYPTO_mem_leaks(BIO *b)
        ml.bytes=0;
        ml.chunks=0;
        if (mh != NULL)
-               lh_doall_arg(mh, LHASH_DOALL_ARG_FN(print_leak),
-                               (char *)&ml);
+               lh_MEM_doall_arg(mh, LHASH_DOALL_ARG_FN(print_leak), MEM_LEAK,
+                                &ml);
        if (ml.chunks != 0)
                {
                BIO_printf(b,"%ld bytes leaked in %d chunks\n",
@@ -734,14 +815,14 @@ void CRYPTO_mem_leaks(BIO *b)
 
                if (mh != NULL)
                        {
-                       lh_free(mh);
+                       lh_MEM_free(mh);
                        mh = NULL;
                        }
                if (amih != NULL)
                        {
-                       if (lh_num_items(amih) == 0) 
+                       if (lh_APP_INFO_num_items(amih) == 0) 
                                {
-                               lh_free(amih);
+                               lh_APP_INFO_free(amih);
                                amih = NULL;
                                }
                        }
@@ -779,17 +860,26 @@ void CRYPTO_mem_leaks_fp(FILE *fp)
 /* NB: The prototypes have been typedef'd to CRYPTO_MEM_LEAK_CB inside crypto.h
  * If this code is restructured, remove the callback type if it is no longer
  * needed. -- Geoff Thorpe */
-static void cb_leak(const MEM *m, CRYPTO_MEM_LEAK_CB **cb)
+
+/* Can't pass CRYPTO_MEM_LEAK_CB directly to lh_MEM_doall_arg because it
+ * is a function pointer and conversion to void * is prohibited. Instead
+ * pass its address
+ */
+
+typedef CRYPTO_MEM_LEAK_CB *PCRYPTO_MEM_LEAK_CB;
+
+static void cb_leak_doall_arg(const MEM *m, PCRYPTO_MEM_LEAK_CB *cb)
        {
-       (**cb)(m->order,m->file,m->line,m->num,m->addr);
+       (*cb)(m->order,m->file,m->line,m->num,m->addr);
        }
 
-static IMPLEMENT_LHASH_DOALL_ARG_FN(cb_leak, const MEM *, CRYPTO_MEM_LEAK_CB **)
+static IMPLEMENT_LHASH_DOALL_ARG_FN(cb_leak, const MEM, PCRYPTO_MEM_LEAK_CB)
 
 void CRYPTO_mem_leaks_cb(CRYPTO_MEM_LEAK_CB *cb)
        {
        if (mh == NULL) return;
        CRYPTO_w_lock(CRYPTO_LOCK_MALLOC2);
-       lh_doall_arg(mh, LHASH_DOALL_ARG_FN(cb_leak), &cb);
+       lh_MEM_doall_arg(mh, LHASH_DOALL_ARG_FN(cb_leak), PCRYPTO_MEM_LEAK_CB,
+                        &cb);
        CRYPTO_w_unlock(CRYPTO_LOCK_MALLOC2);
        }