Initialise CMS signature buffer length properly.
[openssl.git] / crypto / cms / cms_sd.c
index 52860975f6086ea44e0cda67228ee205f4750a71..8f672890a076f6089b7ef41ab988e025c0f0533a 100644 (file)
@@ -87,6 +87,7 @@ static CMS_SignedData *cms_signed_data_init(CMS_ContentInfo *cms)
                cms->d.signedData->version = 1;
                cms->d.signedData->encapContentInfo->eContentType =
                                                OBJ_nid2obj(NID_pkcs7_data);
+               cms->d.signedData->encapContentInfo->partial = 1;
                ASN1_OBJECT_free(cms->contentType);
                cms->contentType = OBJ_nid2obj(NID_pkcs7_signed);
                return cms->d.signedData;
@@ -225,6 +226,12 @@ int cms_set1_SignerIdentifier(CMS_SignerIdentifier *sid, X509 *cert, int type)
                break;
 
                case CMS_SIGNERINFO_KEYIDENTIFIER:
+               if (!cert->skid)
+                       {
+                       CMSerr(CMS_F_CMS_SET1_SIGNERIDENTIFIER,
+                                       CMS_R_CERTIFICATE_HAS_NO_KEYID);
+                       return 0;
+                       }
                sid->d.subjectKeyIdentifier = ASN1_STRING_dup(cert->skid);
                if (!sid->d.subjectKeyIdentifier)
                        goto merr;
@@ -290,6 +297,27 @@ int cms_SignerIdentifier_cert_cmp(CMS_SignerIdentifier *sid, X509 *cert)
                return -1;
        }
 
+static int cms_sd_asn1_ctrl(CMS_SignerInfo *si, int cmd)
+       {
+       EVP_PKEY *pkey = si->pkey;
+       int i;
+       if (!pkey->ameth || !pkey->ameth->pkey_ctrl)
+               return 1;
+       i = pkey->ameth->pkey_ctrl(pkey, ASN1_PKEY_CTRL_CMS_SIGN, cmd, si);
+       if (i == -2)
+               {
+               CMSerr(CMS_F_CMS_SD_ASN1_CTRL,
+                               CMS_R_NOT_SUPPORTED_FOR_THIS_KEY_TYPE);
+               return 0;
+               }
+       if (i <= 0)
+               {
+               CMSerr(CMS_F_CMS_SD_ASN1_CTRL, CMS_R_CTRL_FAILURE);
+               return 0;
+               }
+       return 1;
+       }
+
 CMS_SignerInfo *CMS_add1_signer(CMS_ContentInfo *cms,
                        X509 *signer, EVP_PKEY *pk, const EVP_MD *md,
                        unsigned int flags)
@@ -317,6 +345,8 @@ CMS_SignerInfo *CMS_add1_signer(CMS_ContentInfo *cms,
 
        si->pkey = pk;
        si->signer = signer;
+       EVP_MD_CTX_init(&si->mctx);
+       si->pctx = NULL;
 
        if (flags & CMS_USE_KEYID)
                {
@@ -353,7 +383,7 @@ CMS_SignerInfo *CMS_add1_signer(CMS_ContentInfo *cms,
                goto err;
                }
 
-       cms_DigestAlgorithm_set(si->digestAlgorithm, md);
+       X509_ALGOR_set_md(si->digestAlgorithm, md);
 
        /* See if digest is present in digestAlgorithms */
        for (i = 0; i < sk_X509_ALGOR_num(sd->digestAlgorithms); i++)
@@ -370,7 +400,7 @@ CMS_SignerInfo *CMS_add1_signer(CMS_ContentInfo *cms,
                alg = X509_ALGOR_new();
                if (!alg)
                        goto merr;
-               cms_DigestAlgorithm_set(alg, md);
+               X509_ALGOR_set_md(alg, md);
                if (!sk_X509_ALGOR_push(sd->digestAlgorithms, alg))
                        {
                        X509_ALGOR_free(alg);
@@ -378,35 +408,21 @@ CMS_SignerInfo *CMS_add1_signer(CMS_ContentInfo *cms,
                        }
                }
 
-       if (pk->ameth && pk->ameth->pkey_ctrl)
+       if (!(flags & CMS_KEY_PARAM) && !cms_sd_asn1_ctrl(si, 0))
+               goto err;
+       if (!(flags & CMS_NOATTR))
                {
-               i = pk->ameth->pkey_ctrl(pk, ASN1_PKEY_CTRL_CMS_SIGN,
-                                               0, si);
-               if (i == -2)
-                       {
-                       CMSerr(CMS_F_CMS_ADD1_SIGNER,
-                               CMS_R_NOT_SUPPORTED_FOR_THIS_KEY_TYPE);
-                       goto err;
-                       }
-               if (i <= 0)
+               /* Initialialize signed attributes strutucture so other
+                * attributes such as signing time etc are added later
+                * even if we add none here.
+                */
+               if (!si->signedAttrs)
                        {
-                       CMSerr(CMS_F_CMS_ADD1_SIGNER, CMS_R_CTRL_FAILURE);
-                       goto err;
+                       si->signedAttrs = sk_X509_ATTRIBUTE_new_null();
+                       if (!si->signedAttrs)
+                               goto merr;
                        }
-               }
 
-       if (!(flags & CMS_NOATTR))
-               {
-               /* Copy content type across */
-               ASN1_OBJECT *ctype =
-                               OBJ_dup(sd->encapContentInfo->eContentType); 
-               if (!ctype)
-                       goto merr;
-               i = CMS_signed_add1_attr_by_NID(si, NID_pkcs9_contentType,
-                                               V_ASN1_OBJECT, ctype, -1);
-               ASN1_OBJECT_free(ctype);
-               if (i <= 0)
-                       goto merr;
                if (!(flags & CMS_NOSMIMECAP))
                        {
                        STACK_OF(X509_ALGOR) *smcap = NULL;
@@ -421,7 +437,7 @@ CMS_SignerInfo *CMS_add1_signer(CMS_ContentInfo *cms,
                        {
                        if (!cms_copy_messageDigest(cms, si))
                                goto err;
-                       if (!(flags & CMS_PARTIAL) &&
+                       if (!(flags & (CMS_PARTIAL|CMS_KEY_PARAM)) &&
                                        !CMS_SignerInfo_sign(si))
                                goto err;
                        }
@@ -434,6 +450,22 @@ CMS_SignerInfo *CMS_add1_signer(CMS_ContentInfo *cms,
                        goto merr;
                }
 
+       if (flags & CMS_KEY_PARAM)
+               {
+               if (flags & CMS_NOATTR)
+                       {
+                       si->pctx = EVP_PKEY_CTX_new(si->pkey, NULL);
+                       if (!si->pctx)
+                               goto err;
+                       if (EVP_PKEY_sign_init(si->pctx) <= 0)
+                               goto err;
+                       if (EVP_PKEY_CTX_set_signature_md(si->pctx, md) <= 0)
+                               goto err;
+                       }
+               else if (EVP_DigestSignInit(&si->mctx, &si->pctx, md, NULL, pk) <= 0)
+                       goto err;
+               }
+
        if (!sd->signerInfos)
                sd->signerInfos = sk_CMS_SignerInfo_new_null();
        if (!sd->signerInfos ||
@@ -451,7 +483,7 @@ CMS_SignerInfo *CMS_add1_signer(CMS_ContentInfo *cms,
 
        }
 
-int CMS_add1_signingTime(CMS_SignerInfo *si, ASN1_TIME *t)
+static int cms_add1_signingTime(CMS_SignerInfo *si, ASN1_TIME *t)
        {
        ASN1_TIME *tt;
        int r = 0;
@@ -481,6 +513,16 @@ int CMS_add1_signingTime(CMS_SignerInfo *si, ASN1_TIME *t)
 
        }
 
+EVP_PKEY_CTX *CMS_SignerInfo_get0_pkey_ctx(CMS_SignerInfo *si)
+       {
+       return si->pctx;
+       }
+
+EVP_MD_CTX *CMS_SignerInfo_get0_md_ctx(CMS_SignerInfo *si)
+       {
+       return &si->mctx;
+       }
+
 STACK_OF(CMS_SignerInfo) *CMS_get0_SignerInfos(CMS_ContentInfo *cms)
        {
        CMS_SignedData *sd;
@@ -608,13 +650,14 @@ void CMS_SignerInfo_get0_algs(CMS_SignerInfo *si, EVP_PKEY **pk, X509 **signer,
                *psig = si->signatureAlgorithm;
        }
 
-int cms_SignerInfo_content_sign(CMS_SignerInfo *si, BIO *chain)
+static int cms_SignerInfo_content_sign(CMS_ContentInfo *cms,
+                                       CMS_SignerInfo *si, BIO *chain)
        {
        EVP_MD_CTX mctx;
        int r = 0;
+       EVP_PKEY_CTX *pctx = NULL;
        EVP_MD_CTX_init(&mctx);
 
-
        if (!si->pkey)
                {
                CMSerr(CMS_F_CMS_SIGNERINFO_CONTENT_SIGN, CMS_R_NO_PRIVATE_KEY);
@@ -623,21 +666,52 @@ int cms_SignerInfo_content_sign(CMS_SignerInfo *si, BIO *chain)
 
        if (!cms_DigestAlgorithm_find_ctx(&mctx, chain, si->digestAlgorithm))
                goto err;
+       /* Set SignerInfo algortihm details if we used custom parametsr */
+       if (si->pctx && !cms_sd_asn1_ctrl(si, 0))
+               goto err;
 
        /* If any signed attributes calculate and add messageDigest attribute */
 
        if (CMS_signed_get_attr_count(si) >= 0)
                {
+               ASN1_OBJECT *ctype =
+                       cms->d.signedData->encapContentInfo->eContentType; 
                unsigned char md[EVP_MAX_MD_SIZE];
                unsigned int mdlen;
-               EVP_DigestFinal_ex(&mctx, md, &mdlen);
+               if (!EVP_DigestFinal_ex(&mctx, md, &mdlen))
+                       goto err;
                if (!CMS_signed_add1_attr_by_NID(si, NID_pkcs9_messageDigest,
                                                V_ASN1_OCTET_STRING,
                                                md, mdlen))
                        goto err;
+               /* Copy content type across */
+               if (CMS_signed_add1_attr_by_NID(si, NID_pkcs9_contentType,
+                                       V_ASN1_OBJECT, ctype, -1) <= 0)
+                       goto err;
                if (!CMS_SignerInfo_sign(si))
                        goto err;
                }
+       else if (si->pctx)
+               {
+               unsigned char *sig;
+               size_t siglen;
+               unsigned char md[EVP_MAX_MD_SIZE];
+               unsigned int mdlen;
+               pctx = si->pctx;
+               if (!EVP_DigestFinal_ex(&mctx, md, &mdlen))
+                       goto err;
+               siglen = EVP_PKEY_size(si->pkey);
+               sig = OPENSSL_malloc(siglen);
+               if (!sig)
+                       {
+                       CMSerr(CMS_F_CMS_SIGNERINFO_CONTENT_SIGN,
+                                       ERR_R_MALLOC_FAILURE);
+                       goto err;
+                       }
+               if (EVP_PKEY_sign(pctx, sig, &siglen, md, mdlen) <= 0)
+                       goto err;
+               ASN1_STRING_set0(si->signature, sig, siglen);
+               }
        else
                {
                unsigned char *sig;
@@ -663,6 +737,8 @@ int cms_SignerInfo_content_sign(CMS_SignerInfo *si, BIO *chain)
 
        err:
        EVP_MD_CTX_cleanup(&mctx);
+       if (pctx)
+               EVP_PKEY_CTX_free(pctx);
        return r;
 
        }
@@ -676,15 +752,16 @@ int cms_SignedData_final(CMS_ContentInfo *cms, BIO *chain)
        for (i = 0; i < sk_CMS_SignerInfo_num(sinfos); i++)
                {
                si = sk_CMS_SignerInfo_value(sinfos, i);
-               if (!cms_SignerInfo_content_sign(si, chain))
+               if (!cms_SignerInfo_content_sign(cms, si, chain))
                        return 0;
                }
+       cms->d.signedData->encapContentInfo->partial = 0;
        return 1;
        }
 
 int CMS_SignerInfo_sign(CMS_SignerInfo *si)
        {
-       EVP_MD_CTX mctx;
+       EVP_MD_CTX *mctx = &si->mctx;
        EVP_PKEY_CTX *pctx;
        unsigned char *abuf = NULL;
        int alen;
@@ -695,16 +772,21 @@ int CMS_SignerInfo_sign(CMS_SignerInfo *si)
        if (md == NULL)
                return 0;
 
-       EVP_MD_CTX_init(&mctx);
 
        if (CMS_signed_get_attr_by_NID(si, NID_pkcs9_signingTime, -1) < 0)
                {
-               if (!CMS_add1_signingTime(si, NULL))
+               if (!cms_add1_signingTime(si, NULL))
                        goto err;
                }
 
-       if (EVP_DigestSignInit(&mctx, &pctx, md, NULL, si->pkey) <= 0)
-               goto err;
+       if (si->pctx)
+               pctx = si->pctx;
+       else
+               {
+               EVP_MD_CTX_init(mctx);
+               if (EVP_DigestSignInit(mctx, &pctx, md, NULL, si->pkey) <= 0)
+                       goto err;
+               }
 
        if (EVP_PKEY_CTX_ctrl(pctx, -1, EVP_PKEY_OP_SIGN,
                                EVP_PKEY_CTRL_CMS_SIGN, 0, si) <= 0)
@@ -717,15 +799,15 @@ int CMS_SignerInfo_sign(CMS_SignerInfo *si)
                                ASN1_ITEM_rptr(CMS_Attributes_Sign));
        if(!abuf)
                goto err;
-       if (EVP_DigestSignUpdate(&mctx, abuf, alen) <= 0)
+       if (EVP_DigestSignUpdate(mctx, abuf, alen) <= 0)
                goto err;
-       if (EVP_DigestSignFinal(&mctx, NULL, &siglen) <= 0)
+       if (EVP_DigestSignFinal(mctx, NULL, &siglen) <= 0)
                goto err;
        OPENSSL_free(abuf);
        abuf = OPENSSL_malloc(siglen);
        if(!abuf)
                goto err;
-       if (EVP_DigestSignFinal(&mctx, abuf, &siglen) <= 0)
+       if (EVP_DigestSignFinal(mctx, abuf, &siglen) <= 0)
                goto err;
 
        if (EVP_PKEY_CTX_ctrl(pctx, -1, EVP_PKEY_OP_SIGN,
@@ -735,7 +817,7 @@ int CMS_SignerInfo_sign(CMS_SignerInfo *si)
                goto err;
                }
 
-       EVP_MD_CTX_cleanup(&mctx);
+       EVP_MD_CTX_cleanup(mctx);
 
        ASN1_STRING_set0(si->signature, abuf, siglen);
 
@@ -744,15 +826,14 @@ int CMS_SignerInfo_sign(CMS_SignerInfo *si)
        err:
        if (abuf)
                OPENSSL_free(abuf);
-       EVP_MD_CTX_cleanup(&mctx);
+       EVP_MD_CTX_cleanup(mctx);
        return 0;
 
        }
 
 int CMS_SignerInfo_verify(CMS_SignerInfo *si)
        {
-       EVP_MD_CTX mctx;
-       EVP_PKEY_CTX *pctx;
+       EVP_MD_CTX *mctx = &si->mctx;
        unsigned char *abuf = NULL;
        int alen, r = -1;
        const EVP_MD *md = NULL;
@@ -766,27 +847,30 @@ int CMS_SignerInfo_verify(CMS_SignerInfo *si)
        md = EVP_get_digestbyobj(si->digestAlgorithm->algorithm);
        if (md == NULL)
                return -1;
-       EVP_MD_CTX_init(&mctx);
-       if (EVP_DigestVerifyInit(&mctx, &pctx, md, NULL, si->pkey) <= 0)
+       EVP_MD_CTX_init(mctx);
+       if (EVP_DigestVerifyInit(mctx, &si->pctx, md, NULL, si->pkey) <= 0)
+               goto err;
+
+       if (!cms_sd_asn1_ctrl(si, 1))
                goto err;
 
        alen = ASN1_item_i2d((ASN1_VALUE *)si->signedAttrs,&abuf,
                                ASN1_ITEM_rptr(CMS_Attributes_Verify));
        if(!abuf)
                goto err;
-       r = EVP_DigestVerifyUpdate(&mctx, abuf, alen);
+       r = EVP_DigestVerifyUpdate(mctx, abuf, alen);
        OPENSSL_free(abuf);
        if (r <= 0)
                {
                r = -1;
                goto err;
                }
-       r = EVP_DigestVerifyFinal(&mctx,
+       r = EVP_DigestVerifyFinal(mctx,
                        si->signature->data, si->signature->length);
-       if (!r)
+       if (r <= 0)
                CMSerr(CMS_F_CMS_SIGNERINFO_VERIFY, CMS_R_VERIFICATION_FAILURE);
        err:
-       EVP_MD_CTX_cleanup(&mctx);
+       EVP_MD_CTX_cleanup(mctx);
        return r;
        }
 
@@ -798,9 +882,10 @@ BIO *cms_SignedData_init_bio(CMS_ContentInfo *cms)
        CMS_SignedData *sd;
        BIO *chain = NULL;
        sd = cms_get0_signed(cms);
-       cms_sd_set_version(sd);
        if (!sd)
                return NULL;
+       if (cms->d.signedData->encapContentInfo->partial)
+               cms_sd_set_version(sd);
        for (i = 0; i < sk_X509_ALGOR_num(sd->digestAlgorithms); i++)
                {
                X509_ALGOR *digestAlgorithm;
@@ -825,7 +910,10 @@ int CMS_SignerInfo_verify_content(CMS_SignerInfo *si, BIO *chain)
        {
        ASN1_OCTET_STRING *os = NULL;
        EVP_MD_CTX mctx;
+       EVP_PKEY_CTX *pkctx = NULL;
        int r = -1;
+       unsigned char mval[EVP_MAX_MD_SIZE];
+       unsigned int mlen;
        EVP_MD_CTX_init(&mctx);
        /* If we have any signed attributes look for messageDigest value */
        if (CMS_signed_get_attr_count(si) >= 0)
@@ -844,19 +932,18 @@ int CMS_SignerInfo_verify_content(CMS_SignerInfo *si, BIO *chain)
        if (!cms_DigestAlgorithm_find_ctx(&mctx, chain, si->digestAlgorithm))
                goto err;
 
+       if (EVP_DigestFinal_ex(&mctx, mval, &mlen) <= 0)
+               {
+               CMSerr(CMS_F_CMS_SIGNERINFO_VERIFY_CONTENT,
+                       CMS_R_UNABLE_TO_FINALIZE_CONTEXT);
+               goto err;
+               }
+
        /* If messageDigest found compare it */
 
        if (os)
                {
-               unsigned char mval[EVP_MAX_MD_SIZE];
-               unsigned int mlen;
-               if (EVP_DigestFinal_ex(&mctx, mval, &mlen) <= 0)
-                       {
-                       CMSerr(CMS_F_CMS_SIGNERINFO_VERIFY_CONTENT,
-                               CMS_R_UNABLE_TO_FINALIZE_CONTEXT);
-                       goto err;
-                       }
-               if (mlen != os->length)
+               if (mlen != (unsigned int)os->length)
                        {
                        CMSerr(CMS_F_CMS_SIGNERINFO_VERIFY_CONTENT,
                                CMS_R_MESSAGEDIGEST_ATTRIBUTE_WRONG_LENGTH);
@@ -874,8 +961,18 @@ int CMS_SignerInfo_verify_content(CMS_SignerInfo *si, BIO *chain)
                }
        else
                {
-               r = EVP_VerifyFinal(&mctx, si->signature->data,
-                                       si->signature->length, si->pkey);
+               const EVP_MD *md = EVP_MD_CTX_md(&mctx);
+               pkctx = EVP_PKEY_CTX_new(si->pkey, NULL);
+               if (EVP_PKEY_verify_init(pkctx) <= 0)
+                       goto err;
+               if (EVP_PKEY_CTX_set_signature_md(pkctx, md) <= 0)
+                       goto err;
+               si->pctx = pkctx;
+               if (!cms_sd_asn1_ctrl(si, 1))
+                       goto err;
+               r = EVP_PKEY_verify(pkctx, si->signature->data,
+                                       si->signature->length,
+                                       mval, mlen);
                if (r <= 0)
                        {
                        CMSerr(CMS_F_CMS_SIGNERINFO_VERIFY_CONTENT,
@@ -885,6 +982,8 @@ int CMS_SignerInfo_verify_content(CMS_SignerInfo *si, BIO *chain)
                }
 
        err:
+       if (pkctx)
+               EVP_PKEY_CTX_free(pkctx);
        EVP_MD_CTX_cleanup(&mctx);
        return r;