Get rid of hazardous EVP_DigestInit_dbg/EVP_DigestInit case

[openssl.git] / apps / verify.c

diff --git a/apps/verify.c b/apps/verify.c
index 5b9d719d9f127863efdc0bda75462685012bde95..b1a4dacb8b95d31bc0c0ff2b1c2863006293e4df 100644 (file)
--- a/apps/verify.c
+++ b/apps/verify.c
@@ -71,7 +71,7 @@
 #define PROG   verify_main
 
 static int MS_CALLBACK cb(int ok, X509_STORE_CTX *ctx);
-static int check(X509_STORE *ctx, char *file, STACK_OF(X509) *uchain, STACK_OF(X509) *tchain, int purpose);
+static int check(X509_STORE *ctx, char *file, STACK_OF(X509) *uchain, STACK_OF(X509) *tchain, int purpose, ENGINE *e);
 static STACK_OF(X509) *load_untrusted(char *file);
 static int v_verbose=0, vflags = 0;
 
@@ -166,23 +166,7 @@ int MAIN(int argc, char **argv)
                        break;
                }
 
-       if (engine != NULL)
-               {
-               if((e = ENGINE_by_id(engine)) == NULL)
-                       {
-                       BIO_printf(bio_err,"invalid engine \"%s\"\n",
-                               engine);
-                       goto end;
-                       }
-               if(!ENGINE_set_default(e, ENGINE_METHOD_ALL))
-                       {
-                       BIO_printf(bio_err,"can't use that engine\n");
-                       goto end;
-                       }
-               BIO_printf(bio_err,"engine \"%s\" set.\n", engine);
-               /* Free our "structural" reference. */
-               ENGINE_free(e);
-               }
+        e = setup_engine(bio_err, engine, 0);
 
        lookup=X509_STORE_add_lookup(cert_ctx,X509_LOOKUP_file());
        if (lookup == NULL) abort();
@@ -224,10 +208,10 @@ int MAIN(int argc, char **argv)
                }
        }
 
-       if (argc < 1) check(cert_ctx, NULL, untrusted, trusted, purpose);
+       if (argc < 1) check(cert_ctx, NULL, untrusted, trusted, purpose, e);
        else
                for (i=0; i<argc; i++)
-                       check(cert_ctx,argv[i], untrusted, trusted, purpose);
+                       check(cert_ctx,argv[i], untrusted, trusted, purpose, e);
        ret=0;
 end:
        if (ret == 1) {
@@ -243,42 +227,19 @@ end:
        if (cert_ctx != NULL) X509_STORE_free(cert_ctx);
        sk_X509_pop_free(untrusted, X509_free);
        sk_X509_pop_free(trusted, X509_free);
+       apps_shutdown();
        EXIT(ret);
        }
 
-static int check(X509_STORE *ctx, char *file, STACK_OF(X509) *uchain, STACK_OF(X509) *tchain, int purpose)
+static int check(X509_STORE *ctx, char *file, STACK_OF(X509) *uchain, STACK_OF(X509) *tchain, int purpose, ENGINE *e)
        {
        X509 *x=NULL;
-       BIO *in=NULL;
        int i=0,ret=0;
        X509_STORE_CTX *csc;
 
-       in=BIO_new(BIO_s_file());
-       if (in == NULL)
-               {
-               ERR_print_errors(bio_err);
-               goto end;
-               }
-
-       if (file == NULL)
-               BIO_set_fp(in,stdin,BIO_NOCLOSE);
-       else
-               {
-               if (BIO_read_filename(in,file) <= 0)
-                       {
-                       perror(file);
-                       goto end;
-                       }
-               }
-
-       x=PEM_read_bio_X509(in,NULL,NULL,NULL);
+       x = load_cert(bio_err, file, FORMAT_PEM, NULL, e, "certificate file");
        if (x == NULL)
-               {
-               fprintf(stdout,"%s: unable to load certificate file\n",
-                       (file == NULL)?"stdin":file);
-               ERR_print_errors(bio_err);
                goto end;
-               }
        fprintf(stdout,"%s: ",(file == NULL)?"stdin":file);
 
        csc = X509_STORE_CTX_new();
@@ -288,7 +249,11 @@ static int check(X509_STORE *ctx, char *file, STACK_OF(X509) *uchain, STACK_OF(X
                goto end;
                }
        X509_STORE_set_flags(ctx, vflags);
-       X509_STORE_CTX_init(csc,ctx,x,uchain);
+       if(!X509_STORE_CTX_init(csc,ctx,x,uchain))
+               {
+               ERR_print_errors(bio_err);
+               goto end;
+               }
        if(tchain) X509_STORE_CTX_trusted_stack(csc, tchain);
        if(purpose >= 0) X509_STORE_CTX_set_purpose(csc, purpose);
        i=X509_verify_cert(csc);
@@ -304,7 +269,6 @@ end:
        else
                ERR_print_errors(bio_err);
        if (x != NULL) X509_free(x);
-       if (in != NULL) BIO_free(in);
 
        return(ret);
        }