2 # Copyright 2002-2019 The OpenSSL Project Authors. All Rights Reserved.
4 # Licensed under the Apache License 2.0 (the "License"). You may not use
5 # this file except in compliance with the License. You can obtain a copy
6 # in the file LICENSE in the source distribution or at
7 # https://www.openssl.org/source/license.html
16 use File::Spec::Functions;
18 use lib catdir(dirname($0), "perl");
19 use OpenSSL::Util::Pod;
37 Find small errors (nits) in documentation. Options:
38 -d Detailed list of undocumented (implies -u)
39 -e Detailed list of new undocumented (implies -v)
40 -s Same as -e except no output is generated if nothing is undocumented
41 -o Causes -e/-v to count symbols added since 1.1.1 as new (implies -v)
43 -n Print nits in POD pages
44 -p Warn if non-public name documented (implies -n)
45 -u Count undocumented functions
46 -v Count new undocumented functions
47 -h Print this help message
48 -c List undocumented commands and options
53 my $temp = '/tmp/docnits.txt';
57 my %mandatory_sections =
58 ( '*' => [ 'NAME', 'DESCRIPTION', 'COPYRIGHT' ],
59 1 => [ 'SYNOPSIS', 'OPTIONS' ],
60 3 => [ 'SYNOPSIS', 'RETURN VALUES' ],
64 # Cross-check functions in the NAME and SYNOPSIS section.
71 # Get NAME section and all words in it.
72 return unless $contents =~ /=head1 NAME(.*)=head1 SYNOPSIS/ms;
75 print "$id trailing comma before - in NAME\n" if $tmp =~ /, *-/;
77 print "$id POD markup among the names in NAME\n" if $tmp =~ /[<>]/;
79 print "$id missing comma in NAME\n" if $tmp =~ /[^,] /;
81 my $dirname = dirname($filename);
82 my $simplename = basename(basename($filename, ".in"), ".pod");
83 my $foundfilename = 0;
84 my %foundfilenames = ();
86 foreach my $n ( split ',', $tmp ) {
89 print "$id the name '$n' contains white-space\n"
92 $foundfilename++ if $n eq $simplename;
93 $foundfilenames{$n} = 1
94 if ((-f "$dirname/$n.pod.in" || -f "$dirname/$n.pod")
95 && $n ne $simplename);
97 print "$id the following exist as other .pod or .pod.in files:\n",
98 join(" ", sort keys %foundfilenames), "\n"
100 print "$id $simplename (filename) missing from NAME section\n"
101 unless $foundfilename;
102 foreach my $n ( keys %names ) {
103 print "$id $n is not public\n"
104 if $opt_p and !defined $public{$n};
107 # Find all functions in SYNOPSIS
108 return unless $contents =~ /=head1 SYNOPSIS(.*)=head1 DESCRIPTION/ms;
110 foreach my $line ( split /\n+/, $syn ) {
111 next unless $line =~ /^\s/;
113 $line =~ s/STACK_OF\([^)]+\)/int/g;
114 $line =~ s/SPARSE_ARRAY_OF\([^)]+\)/int/g;
115 $line =~ s/__declspec\([^)]+\)//;
116 if ( $line =~ /env (\S*)=/ ) {
117 # environment variable env NAME=...
119 } elsif ( $line =~ /typedef.*\(\*(\S+)\)\(.*/ ) {
120 # a callback function pointer: typedef ... (*NAME)(...
122 } elsif ( $line =~ /typedef.* (\S+)\(.*/ ) {
123 # a callback function signature: typedef ... NAME(...
125 } elsif ( $line =~ /typedef.* (\S+);/ ) {
126 # a simple typedef: typedef ... NAME;
128 } elsif ( $line =~ /enum (\S*) \{/ ) {
129 # an enumeration: enum ... {
131 } elsif ( $line =~ /#(?:define|undef) ([A-Za-z0-9_]+)/ ) {
133 } elsif ( $line =~ /([A-Za-z0-9_]+)\(/ ) {
139 print "$id $sym missing from NAME section\n"
140 unless defined $names{$sym};
143 # Do some sanity checks on the prototype.
144 print "$id prototype missing spaces around commas: $line\n"
145 if ( $line =~ /[a-z0-9],[^ ]/ );
148 foreach my $n ( keys %names ) {
149 next if $names{$n} == 2;
150 print "$id $n missing from SYNOPSIS\n";
154 # Check if SECTION ($3) is located before BEFORE ($4)
155 sub check_section_location()
158 my $contents = shift;
163 unless $contents =~ /=head1 $section/ and $contents =~ /=head1 $before/;
164 print "$id $section should be placed before $before section\n"
165 if $contents =~ /=head1 $before.*=head1 $section/ms;
170 my $filename = shift;
171 my $dirname = basename(dirname($filename));
176 open POD, $filename or die "Couldn't open $filename, $!";
181 my $id = "${filename}:1:";
183 # Check ordering of some sections in man3
184 if ( $filename =~ m|man3/| ) {
185 &check_section_location($id, $contents, "RETURN VALUES", "EXAMPLES");
186 &check_section_location($id, $contents, "SEE ALSO", "HISTORY");
187 &check_section_location($id, $contents, "EXAMPLES", "SEE ALSO");
190 &name_synopsis($id, $filename, $contents)
191 unless $contents =~ /=for comment generic/
192 or $filename =~ m@man[157]/@;
194 print "$id doesn't start with =pod\n"
195 if $contents !~ /^=pod/;
196 print "$id doesn't end with =cut\n"
197 if $contents !~ /=cut\n$/;
198 print "$id more than one cut line.\n"
199 if $contents =~ /=cut.*=cut/ms;
200 print "$id EXAMPLE not EXAMPLES section.\n"
201 if $contents =~ /=head1 EXAMPLE[^S]/;
202 print "$id WARNING not WARNINGS section.\n"
203 if $contents =~ /=head1 WARNING[^S]/;
204 print "$id missing copyright\n"
205 if $contents !~ /Copyright .* The OpenSSL Project Authors/;
206 print "$id copyright not last\n"
207 if $contents =~ /head1 COPYRIGHT.*=head/ms;
208 print "$id head2 in All uppercase\n"
209 if $contents =~ /head2\s+[A-Z ]+\n/;
210 print "$id extra space after head\n"
211 if $contents =~ /=head\d\s\s+/;
212 print "$id period in NAME section\n"
213 if $contents =~ /=head1 NAME.*\.\n.*=head1 SYNOPSIS/ms;
214 print "$id Duplicate $1 in L<>\n"
215 if $contents =~ /L<([^>]*)\|([^>]*)>/ && $1 eq $2;
216 print "$id Bad =over $1\n"
217 if $contents =~ /=over([^ ][^24])/;
218 print "$id Possible version style issue\n"
219 if $contents =~ /OpenSSL version [019]/;
221 if ( $contents !~ /=for comment multiple includes/ ) {
222 # Look for multiple consecutive openssl #include lines
223 # (non-consecutive lines are okay; see man3/MD5.pod).
224 if ( $contents =~ /=head1 SYNOPSIS(.*)=head1 DESCRIPTION/ms ) {
226 foreach my $line ( split /\n+/, $1 ) {
227 if ( $line =~ m@include <openssl/@ ) {
228 print "$id has multiple includes\n" if ++$count == 2;
236 open my $OUT, '>', $temp
237 or die "Can't open $temp, $!";
238 podchecker($filename, $OUT);
240 open $OUT, '<', $temp
241 or die "Can't read $temp, $!";
243 next if /\(section\) in.*deprecated/;
247 unlink $temp || warn "Can't remove $temp, $!";
249 # Find what section this page is in; assume 3.
251 $section = $1 if $dirname =~ /man([1-9])/;
253 foreach ((@{$mandatory_sections{'*'}}, @{$mandatory_sections{$section}})) {
254 # Skip "return values" if not -s
255 print "$id: missing $_ head1 section\n"
256 if $contents !~ /^=head1\s+${_}\s*$/m;
267 open my $IN, '<', $file
268 or die "Can't open $file, $!, stopped";
272 next if /\bNOEXIST\b/;
273 my @fields = split();
274 die "Malformed line $_"
275 if scalar @fields != 2 && scalar @fields != 4;
276 push @apis, $fields[0];
281 print "# Found ", scalar(@apis), " in $file\n" unless $opt_p;
290 foreach my $pod ( glob("$dir/*.pod"), glob("$dir/*.pod.in") ) {
291 my %podinfo = extract_pod_info($pod);
292 foreach my $n ( @{$podinfo{names}} ) {
294 print "# Duplicate $n in $pod and $dups{$n}\n"
295 if defined $dups{$n} && $dups{$n} ne $pod;
307 my $missingfile = shift;
310 open FH, $missingfile
311 || die "Can't open $missingfile";
329 @missing = loadmissing('util/missingmacro111.txt');
331 @missing = loadmissing('util/missingmacro.txt');
334 print "# Checking macros (approximate)\n" if !$opt_s;
335 foreach my $f ( glob('include/openssl/*.h') ) {
336 # Skip some internals we don't want to document yet.
337 next if $f eq 'include/openssl/asn1.h';
338 next if $f eq 'include/openssl/asn1t.h';
339 next if $f eq 'include/openssl/err.h';
340 open(IN, $f) || die "Can't open $f, $!";
342 next unless /^#\s*define\s*(\S+)\(/;
344 next if $docced{$macro} || defined $seen{$macro};
345 next if $macro =~ /i2d_/
347 || $macro =~ /DEPRECATEDIN/
348 || $macro =~ /IMPLEMENT_/
349 || $macro =~ /DECLARE_/;
351 # Skip macros known to be missing
352 next if $opt_v && grep( /^$macro$/, @missing);
354 print "$f:$macro\n" if $opt_d || $opt_e;
360 print "# Found $count macros missing\n" if !$opt_s || $count > 0;
367 my $missingfile = shift;
371 my @missing = loadmissing($missingfile) if ($opt_v);
373 foreach my $func ( &parsenum($numfile) ) {
374 next if $docced{$func} || defined $seen{$func};
376 # Skip ASN1 utilities
377 next if $func =~ /^ASN1_/;
379 # Skip functions known to be missing
380 next if $opt_v && grep( /^$func$/, @missing);
382 print "$libname:$func\n" if $opt_d || $opt_e;
386 print "# Found $count missing from $numfile\n\n" if !$opt_s || $count > 0;
390 # Collection of links in each POD file.
391 # filename => [ "foo(1)", "bar(3)", ... ]
392 my %link_collection = ();
393 # Collection of names in each POD file.
394 # "name(s)" => filename
395 my %name_collection = ();
398 my $filename = shift;
399 $filename =~ m|man(\d)/|;
401 my $simplename = basename(basename($filename, ".in"), ".pod");
402 my $id = "${filename}:1:";
407 open POD, $filename or die "Couldn't open $filename, $!";
412 $contents =~ /=head1 NAME([^=]*)=head1 /ms;
414 unless (defined $tmp) {
415 print "$id weird name section\n";
422 map { s|/|-|g; $_ } # Treat slash as dash
423 map { s/^\s+//g; s/\s+$//g; $_ } # Trim prefix and suffix blanks
425 unless (grep { $simplename eq $_ } @names) {
426 print "$id missing $simplename\n";
427 push @names, $simplename;
429 foreach my $name (@names) {
432 print "$id '$name' contains white space\n";
434 my $name_sec = "$name($section)";
435 if (! exists $name_collection{$name_sec}) {
436 $name_collection{$name_sec} = $filename;
437 } elsif ($filename eq $name_collection{$name_sec}) {
438 print "$id $name_sec repeated in NAME section of $name_collection{$name_sec}\n"
440 print "$id $name_sec also in NAME section of $name_collection{$name_sec}\n";
445 map { map { s/\s+//g; $_ } split(/,/, $_) }
446 $contents =~ /=for\s+comment\s+foreign\s+manuals:\s*(.*)\n\n/;
447 foreach (@foreign_names) {
448 $name_collection{$_} = undef; # It still exists!
451 my @links = $contents =~ /L<
452 # if the link is of the form L<something|name(s)>,
453 # then remove 'something'. Note that 'something'
454 # may contain POD codes as well...
455 (?:(?:[^\|]|<[^>]*>)*\|)?
456 # we're only interested in references that have
457 # a one digit section number
460 $link_collection{$filename} = [ @links ];
464 foreach my $filename (sort keys %link_collection) {
465 foreach my $link (@{$link_collection{$filename}}) {
466 print "${filename}:1: reference to non-existing $link\n"
467 unless exists $name_collection{$link};
473 foreach my $name ( &parsenum('util/libcrypto.num') ) {
476 foreach my $name ( &parsenum('util/libssl.num') ) {
479 foreach my $name ( &parsenum('util/private.num') ) {
507 # Get the list of options in the command.
508 open CFH, "./apps/openssl list --options $cmd|"
509 || die "Can list options for $cmd, $!";
517 # Get the list of flags from the synopsis
518 open CFH, "<doc/man1/$cmd.pod"
519 || die "Can't open $cmd.pod, $!";
522 last if /DESCRIPTION/;
523 next unless /\[B<-([^ >]+)/;
528 # See what's in the command not the manpage.
530 foreach my $k ( keys %cmdopts ) {
531 push @undocced, $k unless $docopts{$k};
533 if ( scalar @undocced > 0 ) {
535 foreach ( @undocced ) {
536 print "doc/man1/$cmd.pod: Missing -$_\n";
540 # See what's in the command not the manpage.
542 foreach my $k ( keys %docopts ) {
543 push @unimpl, $k unless $cmdopts{$k};
545 if ( scalar @unimpl > 0 ) {
547 foreach ( @unimpl ) {
548 next if defined $skips{$_};
549 print "doc/man1/$cmd.pod: Not implemented -$_\n";
556 getopts('cdesolnphuv');
560 $opt_n = 1 if $opt_p;
561 $opt_u = 1 if $opt_d;
562 $opt_e = 1 if $opt_s;
563 $opt_v = 1 if $opt_o || $opt_e;
565 die "Cannot use both -u and -v" if $opt_u && $opt_v;
566 die "Cannot use both -d and -e" if $opt_d && $opt_e;
568 # We only need to check c, l, n, u and v.
569 # Options d, e, s, o and p imply one of the above.
570 die "Need one of -[cdesolnpuv] flags.\n"
571 unless $opt_c or $opt_l or $opt_n or $opt_u or $opt_v;
577 # Get list of commands.
578 open FH, "./apps/openssl list -1 -commands|"
579 || die "Can't list commands, $!";
586 # See if each has a manpage.
587 foreach ( @commands ) {
588 next if $_ eq 'help' || $_ eq 'exit';
589 if ( ! -f "doc/man1/$_.pod" ) {
590 print "doc/man1/$_.pod does not exist\n";
593 $ok = 0 if not &checkflags($_);
597 # See what help is missing.
598 open FH, "./apps/openssl list --missing-help |"
599 || die "Can't list missing help, $!";
602 my ($cmd, $flag) = split;
603 print "$cmd has no help for -$flag\n";
612 foreach (@ARGV ? @ARGV : (glob('doc/*/*.pod'), glob('doc/*/*.pod.in'),
613 glob('doc/internal/*/*.pod'))) {
620 &publicize() if $opt_p;
621 foreach (@ARGV ? @ARGV : (glob('doc/*/*.pod'), glob('doc/*/*.pod.in'))) {
625 local $opt_p = undef;
626 foreach (@ARGV ? @ARGV : glob('doc/internal/*/*.pod')) {
632 if ( $opt_u || $opt_v) {
633 my %temp = getdocced('doc/man3');
634 foreach ( keys %temp ) {
635 $docced{$_} = $temp{$_};
638 &printem('crypto', 'util/libcrypto.num', 'util/missingcrypto111.txt');
639 &printem('ssl', 'util/libssl.num', 'util/missingssl111.txt');
641 &printem('crypto', 'util/libcrypto.num', 'util/missingcrypto.txt');
642 &printem('ssl', 'util/libssl.num', 'util/missingssl.txt');