Do not define L_ENDIAN (for now) when we guessed linux64-loongarch64
authorXi Ruoyao <xry111@xry111.site>
Fri, 24 Nov 2023 08:14:05 +0000 (16:14 +0800)
committerTomas Mraz <tomas@openssl.org>
Tue, 28 Nov 2023 14:27:43 +0000 (15:27 +0100)
In 160f48941d14 I made L_ENDIAN defined when the system is guessed to be
linux64-loongarch64.  Unfortunately now I found it problematic:

1. This should be added into Configurations/10-main.conf, not here.
   Having it here causes a different configuration when
   linux64-loongarch64 is explicitly specified than guessed.
2. With LTO enabled, this causes many test failures on
   linux64-loongarch64 due to #12247.

So I think we should remove it for now (master and 3.2 branch), and
reintroduce it to Configurations/10-main.conf when we finally sort
out #12247.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22812)

util/perl/OpenSSL/config.pm

index 8125f48b1452ee7e19edfcad72467a8b70a14023..cda764b4edcc5f48e5c75b1c5fd3877271cd29a2 100755 (executable)
@@ -691,7 +691,6 @@ EOF
                 $disable = [];
             }
             return { target => "linux64-loongarch64",
-                     defines => [ 'L_ENDIAN' ],
                      disable => $disable, };
         }
       ],