From dd8710dc54f5123d0fa54b5c90fc2c3a9dae43fe Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Tue, 13 Sep 2016 23:59:11 +0100 Subject: [PATCH] Fix OCSP_RESPID processing bug introduced by WPACKET changes An OCSP_RESPID in a status request extension has 2 bytes for the length not 1. Reviewed-by: Rich Salz --- ssl/t1_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ssl/t1_lib.c b/ssl/t1_lib.c index 696998fe5e..4f5ea42b5a 100644 --- a/ssl/t1_lib.c +++ b/ssl/t1_lib.c @@ -1209,7 +1209,7 @@ int ssl_add_clienthello_tlsext(SSL *s, WPACKET *pkt, int *al) idlen = i2d_OCSP_RESPID(id, NULL); if (idlen <= 0 /* Sub-packet for an individual id */ - || !WPACKET_sub_allocate_bytes_u8(pkt, idlen, &idbytes) + || !WPACKET_sub_allocate_bytes_u16(pkt, idlen, &idbytes) || i2d_OCSP_RESPID(id, &idbytes) != idlen) { SSLerr(SSL_F_SSL_ADD_CLIENTHELLO_TLSEXT, ERR_R_INTERNAL_ERROR); return 0; -- 2.34.1