From 4e0e4d293753a67e5771c98ec312a37ca54cc3b0 Mon Sep 17 00:00:00 2001 From: FdaSilvaYY Date: Thu, 12 May 2016 00:29:22 +0200 Subject: [PATCH] Fix some missing OBJ_dup failure checks. Fix some missing OBJ_dup failure checks. Merged from https://boringssl.googlesource.com/boringssl/+/0ce78a757d815c0dde9ed5884229f3a5b2cb3e9c%5E! Reviewed-by: Kurt Roeckx Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/1057) --- crypto/x509/x509_att.c | 2 +- crypto/x509/x509_v3.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/x509/x509_att.c b/crypto/x509/x509_att.c index fb04cdcf68..8e2abdf52a 100644 --- a/crypto/x509/x509_att.c +++ b/crypto/x509/x509_att.c @@ -288,7 +288,7 @@ int X509_ATTRIBUTE_set1_object(X509_ATTRIBUTE *attr, const ASN1_OBJECT *obj) return (0); ASN1_OBJECT_free(attr->object); attr->object = OBJ_dup(obj); - return (1); + return attr->object != NULL; } int X509_ATTRIBUTE_set1_data(X509_ATTRIBUTE *attr, int attrtype, diff --git a/crypto/x509/x509_v3.c b/crypto/x509/x509_v3.c index f3fe305757..e835db7906 100644 --- a/crypto/x509/x509_v3.c +++ b/crypto/x509/x509_v3.c @@ -235,7 +235,7 @@ int X509_EXTENSION_set_object(X509_EXTENSION *ex, ASN1_OBJECT *obj) return (0); ASN1_OBJECT_free(ex->object); ex->object = OBJ_dup(obj); - return (1); + return ex->object != NULL; } int X509_EXTENSION_set_critical(X509_EXTENSION *ex, int crit) -- 2.34.1