From 460c5e1d2f7388216f12d345d13202381b30e2a3 Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Wed, 27 Apr 2016 14:06:40 +0100 Subject: [PATCH 1/1] Don't leak memory on error in PKCS12_key_gen_uni The PKCS12_key_gen_uni() had one error path which did not free memory correctly. Reviewed-by: Richard Levitte --- crypto/pkcs12/p12_key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/pkcs12/p12_key.c b/crypto/pkcs12/p12_key.c index 6a9a3254b1..1a1ea7059c 100644 --- a/crypto/pkcs12/p12_key.c +++ b/crypto/pkcs12/p12_key.c @@ -129,7 +129,7 @@ int PKCS12_key_gen_uni(unsigned char *pass, int passlen, unsigned char *salt, v = EVP_MD_block_size(md_type); u = EVP_MD_size(md_type); if (u < 0) - return 0; + goto err; D = OPENSSL_malloc(v); Ai = OPENSSL_malloc(u); B = OPENSSL_malloc(v + 1); -- 2.34.1