From 0ecb682a674c69caee4b8da1c08d23305f484cd8 Mon Sep 17 00:00:00 2001 From: Bernd Edlinger Date: Thu, 22 Dec 2016 10:12:03 +0100 Subject: [PATCH] Fix error handling in SSL_CTX_new Dont free rbuf_freelist here, SSL_CTX_free will do that. Signed-off-by: Kurt Roeckx Reviewed-by: Rich Salz GH: #2129 --- ssl/ssl_lib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c index 42b980ac26..f8054dae6b 100644 --- a/ssl/ssl_lib.c +++ b/ssl/ssl_lib.c @@ -2030,10 +2030,8 @@ SSL_CTX *SSL_CTX_new(const SSL_METHOD *meth) ret->rbuf_freelist->len = 0; ret->rbuf_freelist->head = NULL; ret->wbuf_freelist = OPENSSL_malloc(sizeof(SSL3_BUF_FREELIST)); - if (!ret->wbuf_freelist) { - OPENSSL_free(ret->rbuf_freelist); + if (!ret->wbuf_freelist) goto err; - } ret->wbuf_freelist->chunklen = 0; ret->wbuf_freelist->len = 0; ret->wbuf_freelist->head = NULL; -- 2.34.1