From: Richard Levitte <levitte@openssl.org>
Date: Mon, 15 Apr 2019 07:40:22 +0000 (+0200)
Subject: providers/common/digests/sha2.c: forward declare all dispatched functions
X-Git-Tag: openssl-3.0.0-alpha1~2178
X-Git-Url: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff_plain;h=f2dbb71cb6bf6cd570f96e7663a22dd87854f08b

providers/common/digests/sha2.c: forward declare all dispatched functions

Forward declare the dispatched functions using typedefs from
core_numbers.h.  This will ensure that they have correct signatures.

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/8747)
---

diff --git a/providers/common/digests/sha2.c b/providers/common/digests/sha2.c
index fb2bd95f52..3698046f20 100644
--- a/providers/common/digests/sha2.c
+++ b/providers/common/digests/sha2.c
@@ -11,6 +11,22 @@
 #include <openssl/crypto.h>
 #include <openssl/core_numbers.h>
 
+/*
+ * Forward declaration of everything implemented here.  This is not strictly
+ * necessary for the compiler, but provides an assurance that the signatures
+ * of the functions in the dispatch table are correct.
+ */
+static OSSL_OP_digest_newctx_fn sha256_newctx;
+#if 0                           /* Not defined here */
+static OSSL_OP_digest_init_fn sha256_init;
+static OSSL_OP_digest_update_fn sha256_update;
+#endif
+static OSSL_OP_digest_final_fn sha256_final;
+static OSSL_OP_digest_freectx_fn sha256_freectx;
+static OSSL_OP_digest_dupctx_fn sha256_dupctx;
+static OSSL_OP_digest_size_fn sha256_size;
+static OSSL_OP_digest_block_size_fn sha256_size;
+
 static int sha256_final(void *ctx,
                         unsigned char *md, size_t *mdl, size_t mdsz)
 {