From: Matt Caswell <matt@openssl.org>
Date: Fri, 29 Apr 2016 14:22:18 +0000 (+0100)
Subject: Remove some dead code from EC_GROUP_check()
X-Git-Tag: OpenSSL_1_1_0-pre6~987
X-Git-Url: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff_plain;h=b8c51459aa5b5b6b78cce56a7b898944f5314550

Remove some dead code from EC_GROUP_check()

EC_GROUP_check() was obtaining a temporary BIGNUM from the BN_CTX, but
then not using it.

Reviewed-by: Rich Salz <rsalz@openssl.org>
---

diff --git a/crypto/ec/ec_check.c b/crypto/ec/ec_check.c
index 601559f4c4..496b5fc7d1 100644
--- a/crypto/ec/ec_check.c
+++ b/crypto/ec/ec_check.c
@@ -73,9 +73,6 @@ int EC_GROUP_check(const EC_GROUP *group, BN_CTX *ctx)
             goto err;
         }
     }
-    BN_CTX_start(ctx);
-    if ((order = BN_CTX_get(ctx)) == NULL)
-        goto err;
 
     /* check the discriminant */
     if (!EC_GROUP_check_discriminant(group, ctx)) {
@@ -114,8 +111,6 @@ int EC_GROUP_check(const EC_GROUP *group, BN_CTX *ctx)
     ret = 1;
 
  err:
-    if (ctx != NULL)
-        BN_CTX_end(ctx);
     BN_CTX_free(new_ctx);
     EC_POINT_free(point);
     return ret;