From: Andy Polyakov <appro@openssl.org>
Date: Sun, 1 Apr 2018 16:18:46 +0000 (+0200)
Subject: rand/randfile.c: fix potential resource leak in RAND_load_file.
X-Git-Tag: OpenSSL_1_1_1-pre5~60
X-Git-Url: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff_plain;h=b791355b5c0c474ba1005008e3731a859de0754d

rand/randfile.c: fix potential resource leak in RAND_load_file.

Found by Coverity.

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5834)
---

diff --git a/crypto/rand/randfile.c b/crypto/rand/randfile.c
index 3a62b88cf0..c652ddcf1e 100644
--- a/crypto/rand/randfile.c
+++ b/crypto/rand/randfile.c
@@ -94,6 +94,7 @@ int RAND_load_file(const char *file, long bytes)
     if (fstat(fileno(in), &sb) < 0) {
         RANDerr(RAND_F_RAND_LOAD_FILE, RAND_R_INTERNAL_ERROR);
         ERR_add_error_data(2, "Filename=", file);
+        fclose(in);
         return -1;
     }