From: Richard Levitte <levitte@openssl.org>
Date: Thu, 11 Dec 2003 18:01:03 +0000 (+0000)
Subject: To figure out if we're going outside the buffer, use the size of the buffer,
X-Git-Tag: BEN_FIPS_TEST_5~13^2~15
X-Git-Url: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff_plain;h=a2b0de98af8ca4de5fd27484f4925cdc351a9020;hp=4775944f8138a52660f4511fcd5e75b0dbd0a409;ds=sidebyside

To figure out if we're going outside the buffer, use the size of the buffer,
not the size of the integer used to index in said buffer.

PR: 794
Notified by: Rhett Garber <rhett_garber@hp.com>
---

diff --git a/crypto/bio/b_print.c b/crypto/bio/b_print.c
index de74ec6df9..960a049bca 100644
--- a/crypto/bio/b_print.c
+++ b/crypto/bio/b_print.c
@@ -652,8 +652,8 @@ fmtfp(
             (caps ? "0123456789ABCDEF"
               : "0123456789abcdef")[intpart % 10];
         intpart = (intpart / 10);
-    } while (intpart && (iplace < (int)sizeof(iplace)));
-    if (iplace == sizeof iplace)
+    } while (intpart && (iplace < (int)sizeof(iconvert)));
+    if (iplace == sizeof iconvert)
         iplace--;
     iconvert[iplace] = 0;
 
@@ -664,7 +664,7 @@ fmtfp(
               : "0123456789abcdef")[fracpart % 10];
         fracpart = (fracpart / 10);
     } while (fplace < max);
-    if (fplace == sizeof fplace)
+    if (fplace == sizeof fconvert)
         fplace--;
     fconvert[fplace] = 0;