From: Bodo Möller <bodo@openssl.org>
Date: Wed, 31 May 2000 09:51:55 +0000 (+0000)
Subject: Add "FIXME" comment.
X-Git-Tag: OpenSSL-engine-0_9_6-beta1~66^2~24
X-Git-Url: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff_plain;h=939fff67995df626393a7f0fa6b054cbebaefc39

Add "FIXME" comment.
---

diff --git a/crypto/asn1/a_utctm.c b/crypto/asn1/a_utctm.c
index b855867dc1..e3e5c45906 100644
--- a/crypto/asn1/a_utctm.c
+++ b/crypto/asn1/a_utctm.c
@@ -291,5 +291,12 @@ time_t ASN1_UTCTIME_get(const ASN1_UTCTIME *s)
 		}
 #undef g2
 
-	return mktime(&tm)-offset*60;
+	return mktime(&tm)-offset*60; /* FIXME: mktime assumes the current timezone
+	                               * instead of UTC, and unless we rewrite OpenSSL
+				       * in Lisp we cannot locally change the timezone
+				       * without possibly interfering with other parts
+	                               * of the program. timegm, which uses UTC, is
+				       * non-standard.
+	                               * Also time_t is inappropriate for general
+	                               * UTC times because it may a 32 bit type. */
 	}