From: Dr. Stephen Henson <steve@openssl.org>
Date: Thu, 9 Jan 2014 22:47:22 +0000 (+0000)
Subject: Fix bug in X509_V_FLAG_IGNORE_CRITICAL CRL handling.
X-Git-Tag: master-post-reformat~1006
X-Git-Url: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff_plain;h=8f4077ca69076cebaca51b7b666db1ed49e46b9e;ds=sidebyside

Fix bug in X509_V_FLAG_IGNORE_CRITICAL CRL handling.
---

diff --git a/crypto/x509/x509_vfy.c b/crypto/x509/x509_vfy.c
index ab9bf8d184..b7e3f6e996 100644
--- a/crypto/x509/x509_vfy.c
+++ b/crypto/x509/x509_vfy.c
@@ -1614,10 +1614,9 @@ static int cert_crl(X509_STORE_CTX *ctx, X509_CRL *crl, X509 *x)
 	 * a certificate was revoked. This has since been changed since 
 	 * critical extension can change the meaning of CRL entries.
 	 */
-	if (crl->flags & EXFLAG_CRITICAL)
+	if (!(ctx->param->flags & X509_V_FLAG_IGNORE_CRITICAL)
+		&& (crl->flags & EXFLAG_CRITICAL))
 		{
-		if (ctx->param->flags & X509_V_FLAG_IGNORE_CRITICAL)
-			return 1;
 		ctx->error = X509_V_ERR_UNHANDLED_CRITICAL_CRL_EXTENSION;
 		ok = ctx->verify_cb(0, ctx);
 		if(!ok)