From: Arne Schwabe Date: Thu, 23 Apr 2020 10:42:51 +0000 (+0200) Subject: Fix type cast in SSL_CTX_set1_groups macro X-Git-Tag: openssl-3.0.0-alpha2~153 X-Git-Url: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff_plain;h=7ffce852372799b6cd856b711db21332f0048314;ds=sidebyside Fix type cast in SSL_CTX_set1_groups macro The macro casts the glist parameter to char* instead of (int *) like the documentation of the function suggest. Also the function tls1_set_groups that is called from SSL_CTX_ctrl takes an int * argument. This looks like a copy&paste error from SSL_CTX_set1_groups_list function. CLA: trivial Signed-off-by: Arne Schwabe Reviewed-by: Ben Kaduk Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/11614) --- diff --git a/include/openssl/ssl.h b/include/openssl/ssl.h index 7a2b418bf7..551ba40046 100644 --- a/include/openssl/ssl.h +++ b/include/openssl/ssl.h @@ -1416,7 +1416,7 @@ DECLARE_PEM_rw(SSL_SESSION, SSL_SESSION) # define SSL_get1_groups(s, glist) \ SSL_ctrl(s,SSL_CTRL_GET_GROUPS,0,(int*)(glist)) # define SSL_CTX_set1_groups(ctx, glist, glistlen) \ - SSL_CTX_ctrl(ctx,SSL_CTRL_SET_GROUPS,glistlen,(char *)(glist)) + SSL_CTX_ctrl(ctx,SSL_CTRL_SET_GROUPS,glistlen,(int *)(glist)) # define SSL_CTX_set1_groups_list(ctx, s) \ SSL_CTX_ctrl(ctx,SSL_CTRL_SET_GROUPS_LIST,0,(char *)(s)) # define SSL_set1_groups(s, glist, glistlen) \