From: Emilia Kasper Date: Mon, 24 Mar 2014 11:33:54 +0000 (+0100) Subject: Allow duplicate certs in ssl_build_cert_chain X-Git-Tag: master-post-reformat~898 X-Git-Url: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff_plain;h=7c5718be271d9a47e8538adfde1909cd58943244 Allow duplicate certs in ssl_build_cert_chain --- diff --git a/ssl/ssl_cert.c b/ssl/ssl_cert.c index fd59158128..09ea611d8a 100644 --- a/ssl/ssl_cert.c +++ b/ssl/ssl_cert.c @@ -1192,6 +1192,7 @@ int ssl_build_cert_chain(CERT *c, X509_STORE *chain_store, int flags) STACK_OF(X509) *chain = NULL, *untrusted = NULL; X509 *x; int i, rv = 0; + unsigned long error; if (!cpk->x509) { @@ -1208,11 +1209,23 @@ int ssl_build_cert_chain(CERT *c, X509_STORE *chain_store, int flags) { x = sk_X509_value(cpk->chain, i); if (!X509_STORE_add_cert(chain_store, x)) - goto err; + { + error = ERR_peek_last_error(); + if (ERR_GET_LIB(error) != ERR_LIB_X509 || + ERR_GET_REASON(error) != X509_R_CERT_ALREADY_IN_HASH_TABLE) + goto err; + ERR_clear_error(); + } } /* Add EE cert too: it might be self signed */ if (!X509_STORE_add_cert(chain_store, cpk->x509)) - goto err; + { + error = ERR_peek_last_error(); + if (ERR_GET_LIB(error) != ERR_LIB_X509 || + ERR_GET_REASON(error) != X509_R_CERT_ALREADY_IN_HASH_TABLE) + goto err; + ERR_clear_error(); + } } else {