From: Richard Levitte <levitte@openssl.org>
Date: Wed, 14 Nov 2001 22:32:19 +0000 (+0000)
Subject: After loading a dynamic engine, reset the command definitions to the
X-Git-Tag: OpenSSL_0_9_6c~26^2~36
X-Git-Url: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff_plain;h=5b8a57ecaee80b8abac431c201387bcebab2113f;hp=817dfc18a31cc1b1281f5e7396abf2064f0c2a10;ds=sidebyside

After loading a dynamic engine, reset the command definitions to the
empty set.  This prevents engines that do not set the command
definitions themselves to inherit the ones from "dynamic", which would
otherwise be very confusing.
---

diff --git a/crypto/engine/eng_dyn.c b/crypto/engine/eng_dyn.c
index 8fd7078678..bac5e71202 100644
--- a/crypto/engine/eng_dyn.c
+++ b/crypto/engine/eng_dyn.c
@@ -108,6 +108,9 @@ static const ENGINE_CMD_DEFN dynamic_cmd_defns[] = {
 		ENGINE_CMD_FLAG_NO_INPUT},
 	{0, NULL, NULL, 0}
 	};
+static const ENGINE_CMD_DEFN dynamic_cmd_defns_empty[] = {
+	{0, NULL, NULL, 0}
+	};
 
 /* Loading code stores state inside the ENGINE structure via the "ex_data"
  * element. We load all our state into a single structure and use that as a
@@ -402,6 +405,10 @@ static int dynamic_load(ENGINE *e, dynamic_data_ctx *ctx)
 	fns.lock_fns.dynlock_create_cb = CRYPTO_get_dynlock_create_callback();
 	fns.lock_fns.dynlock_lock_cb = CRYPTO_get_dynlock_lock_callback();
 	fns.lock_fns.dynlock_destroy_cb = CRYPTO_get_dynlock_destroy_callback();
+	/* Now that we've loaded the dynamic engine, initialise the command
+	   array to contain none */
+	ENGINE_set_cmd_defns(e, dynamic_cmd_defns_empty);
+
 	/* Try to bind the ENGINE onto our own ENGINE structure */
 	if(!ctx->bind_engine(e, ctx->engine_id, &fns))
 		{