From: Dr. Stephen Henson <steve@openssl.org>
Date: Sun, 23 Feb 2014 13:46:52 +0000 (+0000)
Subject: Only set current certificate to valid values.
X-Git-Tag: master-post-reformat~937
X-Git-Url: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff_plain;h=358d352aa244b4f2ef655bccff6658d92d5ce03c;ds=sidebyside

Only set current certificate to valid values.

When setting the current certificate check that it has a corresponding
private key.
---

diff --git a/ssl/ssl_cert.c b/ssl/ssl_cert.c
index ec208b507c..2c66460fe4 100644
--- a/ssl/ssl_cert.c
+++ b/ssl/ssl_cert.c
@@ -606,18 +606,20 @@ int ssl_cert_select_current(CERT *c, X509 *x)
 		return 0;
 	for (i = 0; i < SSL_PKEY_NUM; i++)
 		{
-		if (c->pkeys[i].x509 == x)
+		CERT_PKEY *cpk = c->pkeys + i;
+		if (cpk->x509 == x && cpk->privatekey)
 			{
-			c->key = &c->pkeys[i];
+			c->key = cpk;
 			return 1;
 			}
 		}
 
 	for (i = 0; i < SSL_PKEY_NUM; i++)
 		{
-		if (c->pkeys[i].x509 && !X509_cmp(c->pkeys[i].x509, x))
+		CERT_PKEY *cpk = c->pkeys + i;
+		if (cpk->privatekey && cpk->x509 && !X509_cmp(cpk->x509, x))
 			{
-			c->key = &c->pkeys[i];
+			c->key = cpk;
 			return 1;
 			}
 		}
@@ -641,9 +643,10 @@ int ssl_cert_set_current(CERT *c, long op)
 		return 0;
 	for (i = idx; i < SSL_PKEY_NUM; i++)
 		{
-		if (c->pkeys[i].x509)
+		CERT_PKEY *cpk = c->key + i;
+		if (cpk->x509 && cpk->privatekey)
 			{
-			c->key = &c->pkeys[i];
+			c->key = cpk;
 			return 1;
 			}
 		}