From: David Benjamin Date: Tue, 23 Aug 2016 05:39:24 +0000 (-0700) Subject: Fix math in BN_bn2dec comment. X-Git-Tag: OpenSSL_1_1_0~56 X-Git-Url: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff_plain;h=2338ad88859313922e3a861e07aec441a90464de Fix math in BN_bn2dec comment. The bound on log(2)/3 on the second line is incorrect and has an extra zero compared to the divisions in the third line. log(2)/3 = 0.10034... which is bounded by 0.101 and not 0.1001. The divisions actually correspond to 0.101 which is fine. The third line also dropped a factor of three. The actual code appears to be fine. Just the comments are wrong. Reviewed-by: Rich Salz Reviewed-by: Matt Caswell --- diff --git a/crypto/bn/bn_print.c b/crypto/bn/bn_print.c index e5f641b99d..39fb03412e 100644 --- a/crypto/bn/bn_print.c +++ b/crypto/bn/bn_print.c @@ -67,8 +67,8 @@ char *BN_bn2dec(const BIGNUM *a) /*- * get an upper bound for the length of the decimal integer * num <= (BN_num_bits(a) + 1) * log(2) - * <= 3 * BN_num_bits(a) * 0.1001 + log(2) + 1 (rounding error) - * <= BN_num_bits(a)/10 + BN_num_bits/1000 + 1 + 1 + * <= 3 * BN_num_bits(a) * 0.101 + log(2) + 1 (rounding error) + * <= 3 * BN_num_bits(a) / 10 + 3 * BN_num_bits / 1000 + 1 + 1 */ i = BN_num_bits(a) * 3; num = (i / 10 + i / 1000 + 1) + 1;