Add a TLS1.3 TODO for the msg callback
authorMatt Caswell <matt@openssl.org>
Mon, 21 Nov 2016 17:11:51 +0000 (17:11 +0000)
committerMatt Caswell <matt@openssl.org>
Mon, 5 Dec 2016 17:05:40 +0000 (17:05 +0000)
At the moment the msg callback only received the record header with the
outer record type in it. We never pass the inner record type - we probably
need to at some point.

Reviewed-by: Rich Salz <rsalz@openssl.org>
ssl/record/ssl3_record.c

index bf69676..d8e2552 100644 (file)
@@ -209,6 +209,11 @@ int ssl3_get_record(SSL *s)
                 }
             } else {
                 /* SSLv3+ style record */
+                /*
+                 * TODO(TLS1.3): This callback only provides the "outer" record
+                 * type to the callback. Somehow we need to pass the "inner"
+                 * record type
+                 */
                 if (s->msg_callback)
                     s->msg_callback(0, 0, SSL3_RT_HEADER, p, 5, s,
                                     s->msg_callback_arg);