aes/asm/{aes-armv4|bsaes-armv7}.pl: make it work with binutils-2.29.
authorAndy Polyakov <appro@openssl.org>
Fri, 3 Nov 2017 22:30:01 +0000 (23:30 +0100)
committerAndy Polyakov <appro@openssl.org>
Sun, 5 Nov 2017 15:56:32 +0000 (16:56 +0100)
It's not clear if it's a feature or bug, but binutils-2.29[.1]
interprets 'adr' instruction with Thumb2 code reference differently,
in a way that affects calculation of addresses of constants' tables.

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/4669)

crypto/aes/asm/aes-armv4.pl
crypto/aes/asm/bsaes-armv7.pl

index 16d79aa..c6474b8 100644 (file)
@@ -200,7 +200,7 @@ AES_encrypt:
 #ifndef        __thumb2__
        sub     r3,pc,#8                @ AES_encrypt
 #else
-       adr     r3,AES_encrypt
+       adr     r3,.
 #endif
        stmdb   sp!,{r1,r4-r12,lr}
 #ifdef __APPLE__
@@ -450,7 +450,7 @@ _armv4_AES_set_encrypt_key:
 #ifndef        __thumb2__
        sub     r3,pc,#8                @ AES_set_encrypt_key
 #else
-       adr     r3,AES_set_encrypt_key
+       adr     r3,.
 #endif
        teq     r0,#0
 #ifdef __thumb2__
@@ -976,7 +976,7 @@ AES_decrypt:
 #ifndef        __thumb2__
        sub     r3,pc,#8                @ AES_decrypt
 #else
-       adr     r3,AES_decrypt
+       adr     r3,.
 #endif
        stmdb   sp!,{r1,r4-r12,lr}
 #ifdef __APPLE__
index cc34859..0c5e762 100644 (file)
@@ -740,7 +740,7 @@ $code.=<<___;
 .type  _bsaes_decrypt8,%function
 .align 4
 _bsaes_decrypt8:
-       adr     $const,_bsaes_decrypt8
+       adr     $const,.
        vldmia  $key!, {@XMM[9]}                @ round 0 key
 #ifdef __APPLE__
        adr     $const,.LM0ISR
@@ -839,7 +839,7 @@ _bsaes_const:
 .type  _bsaes_encrypt8,%function
 .align 4
 _bsaes_encrypt8:
-       adr     $const,_bsaes_encrypt8
+       adr     $const,.
        vldmia  $key!, {@XMM[9]}                @ round 0 key
 #ifdef __APPLE__
        adr     $const,.LM0SR
@@ -947,7 +947,7 @@ $code.=<<___;
 .type  _bsaes_key_convert,%function
 .align 4
 _bsaes_key_convert:
-       adr     $const,_bsaes_key_convert
+       adr     $const,.
        vld1.8  {@XMM[7]},  [$inp]!             @ load round 0 key
 #ifdef __APPLE__
        adr     $const,.LM0