Fix coverity nit in handshake_helper.c
authorBenjamin Kaduk <bkaduk@akamai.com>
Thu, 7 Dec 2017 20:23:35 +0000 (14:23 -0600)
committerBen Kaduk <kaduk@mit.edu>
Fri, 8 Dec 2017 15:16:36 +0000 (09:16 -0600)
There's no reason to wrap this call in TEST_true() if we're not
checking the return value of TEST_true() -- all of the surrounding
similar calls do not have the macro wrapping them.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4873)

test/handshake_helper.c

index 78eaa01..0add973 100644 (file)
@@ -497,8 +497,8 @@ static int configure_handshake_ctx(SSL_CTX *server_ctx, SSL_CTX *server2_ctx,
     case TLSEXT_max_fragment_length_2048:
     case TLSEXT_max_fragment_length_4096:
     case TLSEXT_max_fragment_length_DISABLED:
-        TEST_true(SSL_CTX_set_tlsext_max_fragment_length(
-                        client_ctx, extra->client.max_fragment_len_mode));
+        SSL_CTX_set_tlsext_max_fragment_length(
+              client_ctx, extra->client.max_fragment_len_mode);
         break;
     }