Fix a bug in test_sslversions
authorMatt Caswell <matt@openssl.org>
Wed, 18 Jul 2018 15:19:05 +0000 (16:19 +0100)
committerMatt Caswell <matt@openssl.org>
Wed, 15 Aug 2018 11:33:30 +0000 (12:33 +0100)
The TLSv1.4 tolerance test wasn't testing what we thought it was.

Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/6741)

test/recipes/70-test_sslversions.t

index b0342740d30c0c0bd1f42f01122fda90a8dd4047..c2d76239dda847a81e0cddf6fdf0b04de047ac8c 100644 (file)
@@ -159,6 +159,7 @@ sub modify_supported_versions_filter
             } elsif ($testtype == WITH_TLS1_4) {
                     $ext = pack "C5",
                         0x04, # Length
             } elsif ($testtype == WITH_TLS1_4) {
                     $ext = pack "C5",
                         0x04, # Length
+                        0x03, 0x05, #TLSv1.4
                         0x03, 0x04; #TLSv1.3
             }
             if ($testtype == REVERSE_ORDER_VERSIONS
                         0x03, 0x04; #TLSv1.3
             }
             if ($testtype == REVERSE_ORDER_VERSIONS