Missing NULL check on OBJ_dup result in x509_name_canon
authorFdaSilvaYY <fdasilvayy@gmail.com>
Fri, 3 Jun 2016 22:14:52 +0000 (00:14 +0200)
committerRich Salz <rsalz@openssl.org>
Sat, 18 Jun 2016 20:30:24 +0000 (16:30 -0400)
Reviewed-by: Kurt Roeckx <kurt@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1168)

crypto/x509/x_name.c

index 5c624cb..d5b12f1 100644 (file)
@@ -322,6 +322,8 @@ static int x509_name_canon(X509_NAME *a)
         if (tmpentry == NULL)
             goto err;
         tmpentry->object = OBJ_dup(entry->object);
+        if (tmpentry->object == NULL)
+            goto err;
         if (!asn1_string_canon(tmpentry->value, entry->value))
             goto err;
         if (!sk_X509_NAME_ENTRY_push(entries, tmpentry))