Fix spurious bntest failures.

BN_bntest_rand generates a single-word zero BIGNUM with quite a large probability.

A zero BIGNUM in turn will end up having a NULL |d|-buffer, which we shouldn't dereference without checking.

Reviewed-by: Richard Levitte <levitte@openssl.org>

diff --git a/test/bntest.c b/test/bntest.c
index cf4d2ab3a65728a1e81566c571b5f8985a0636bf..430d2a02b81cbf7fae917f361d6eb8456eddf462 100644 (file)
--- a/test/bntest.c
+++ b/test/bntest.c
@@ -526,9 +526,9 @@ int test_div_word(BIO *bp)
         do {
             BN_bntest_rand(a, 512, -1, 0);
             BN_bntest_rand(b, BN_BITS2, -1, 0);
         do {
             BN_bntest_rand(a, 512, -1, 0);
             BN_bntest_rand(b, BN_BITS2, -1, 0);

-            s = b->d[0];
-        } while (!s);
+        } while (BN_is_zero(b));

 
 

+        s = b->d[0];

         BN_copy(b, a);
         r = BN_div_word(b, s);
 
         BN_copy(b, a);
         r = BN_div_word(b, s);