Comparing a pointer (data) with 0 using > is incorrect. The changed
authorRichard Levitte <levitte@openssl.org>
Wed, 20 Feb 2002 11:57:33 +0000 (11:57 +0000)
committerRichard Levitte <levitte@openssl.org>
Wed, 20 Feb 2002 11:57:33 +0000 (11:57 +0000)
comparison doesn't look right, but at least it compiles.  It would be nice
if the one who knows what this is supposed to do changed it to do it correctly

crypto/ecdsa/ecs_asn1.c

index b3bdd4e..542a987 100644 (file)
@@ -439,7 +439,9 @@ ECDSA         *ECDSA_x9_62parameters2ecdsa(const X9_62_EC_PARAMETERS *params, EC
                if ((point = EC_POINT_new(ret->group)) == NULL) goto err;
        }
        else OPENSSL_ECDSA_ABORT(ECDSA_R_WRONG_FIELD_IDENTIFIER)
-       if (params->curve->seed != NULL && params->curve->seed->data > 0)
+       /* FIXME!!!  It seems like the comparison of data with 0 isn't the
+          intended thing. */
+       if (params->curve->seed != NULL && params->curve->seed->data != 0)
        {
                if (ret->seed != NULL)
                        OPENSSL_free(ret->seed);