Simplify RI+SCSV logic:
authorDr. Stephen Henson <steve@openssl.org>
Thu, 7 Jan 2010 19:04:52 +0000 (19:04 +0000)
committerDr. Stephen Henson <steve@openssl.org>
Thu, 7 Jan 2010 19:04:52 +0000 (19:04 +0000)
1. Send SCSV is not renegotiating, never empty RI.
2. Send RI if renegotiating.

ssl/ssl_lib.c
ssl/t1_lib.c

index ee01a2c..6142b08 100644 (file)
@@ -1370,10 +1370,9 @@ int ssl_cipher_list_to_bytes(SSL *s,STACK_OF(SSL_CIPHER) *sk,unsigned char *p,
                p+=j;
                }
        /* If p == q, no ciphers and caller indicates an error. Otherwise
-        * add SCSV if no extensions (i.e. SSL3 is client_version)
-        * since spec RECOMMENDS not sending both RI and SCSV.
+        * add SCSV if not renegotiating.
         */
-       if (p != q && !s->new_session && s->client_version == SSL3_VERSION)
+       if (p != q && !s->new_session)
                {
                static SSL_CIPHER scsv =
                        {
index c467034..b50d2a5 100644 (file)
@@ -316,8 +316,9 @@ unsigned char *ssl_add_clienthello_tlsext(SSL *s, unsigned char *p, unsigned cha
                ret+=size_str;
                }
 
-        /* Add the renegotiation option: TODOEKR switch */
-        {
+        /* Add RI if renegotiating */
+        if (s->new_session)
+          {
           int el;
           
           if(!ssl_add_clienthello_renegotiate_ext(s, 0, &el, 0))