Don't complain about documented symbols with find-doc-nits -d -o
authorMatt Caswell <matt@openssl.org>
Fri, 31 Jan 2020 10:08:33 +0000 (10:08 +0000)
committerMatt Caswell <matt@openssl.org>
Mon, 3 Feb 2020 11:47:44 +0000 (11:47 +0000)
find-doc-nits can give a list of symbols that were added since 1.1.1 and
are undocumented (using -o). To do this it uses the missingcrypto111.txt
and missingssl111.txt files which give a snapshot of the undocumented
symbols at the time of the 1.1.1 release. Currently it complains about
symbols that are in those files that have subsequently been documented.
This isn't particularly helpful so we suppress that feature when "-o"
is being used.

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/10981)

util/find-doc-nits

index 293f603..901e34f 100755 (executable)
@@ -607,7 +607,7 @@ sub loadmissing($)
 
     for (@missing) {
         err("$missingfile:", "$_ is documented in $name_map{$_}")
 
     for (@missing) {
         err("$missingfile:", "$_ is documented in $name_map{$_}")
-            if exists $name_map{$_} && defined $name_map{$_};
+            if !$opt_o && exists $name_map{$_} && defined $name_map{$_};
     }
 
     return @missing;
     }
 
     return @missing;