Fix Coverity 1520485: logically dead code
authorPauli <pauli@openssl.org>
Tue, 24 Jan 2023 01:23:37 +0000 (12:23 +1100)
committerTomas Mraz <tomas@openssl.org>
Thu, 26 Jan 2023 09:25:33 +0000 (10:25 +0100)
The check is unnecessary as the condition is already checked
before the switch statement.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20121)

crypto/cmp/cmp_ctx.c

index d01be8ebc75c76f004aff018347aa30c9d16d43d..dcad9c89415f508399f44515e5a7eefa933dd44b 100644 (file)
@@ -919,13 +919,9 @@ int OSSL_CMP_CTX_set_option(OSSL_CMP_CTX *ctx, int opt, int val)
         ctx->keep_alive = val;
         break;
     case OSSL_CMP_OPT_MSG_TIMEOUT:
-        if (val < 0)
-            val = 0;
         ctx->msg_timeout = val;
         break;
     case OSSL_CMP_OPT_TOTAL_TIMEOUT:
-        if (val < 0)
-            val = 0;
         ctx->total_timeout = val;
         break;
     case OSSL_CMP_OPT_PERMIT_TA_IN_EXTRACERTS_FOR_IR: